diff mbox

[v2,14/21] travis: dump config.log if ./configure script fails

Message ID 20170622033231.19344-15-f4bug@amsat.org
State New
Headers show

Commit Message

Philippe Mathieu-Daudé June 22, 2017, 3:32 a.m. UTC
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alex Bennée June 22, 2017, 10:23 a.m. UTC | #1
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  .travis.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index 96ddc16cfd..bac5bea744 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -93,7 +93,7 @@ before_script:
>    - if [ -x "$(command -v ccache 2>/dev/null)" ]; then export CC="ccache ${CC}"; ccache -s -M 0 -z; fi
>    - echo "Using ${PARALLEL_JOBS} parallel jobs"
>    - export HOST_CC="${CC}"
> -  - ./configure ${CONFIG}
> +  - ./configure ${CONFIG} || cat config.log

Won't the explicit || mean the job will keep trying even if config is
broken? Should it be || cat config.log && false?

>  script:
>    - make -j${PARALLEL_JOBS} && ccache -s
>    - ${TEST_CMD}


--
Alex Bennée
Philippe Mathieu-Daudé June 23, 2017, 1:45 p.m. UTC | #2
On 06/22/2017 07:23 AM, Alex Bennée wrote:
> 
> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
[...]
>> -  - ./configure ${CONFIG}
>> +  - ./configure ${CONFIG} || cat config.log
> 
> Won't the explicit || mean the job will keep trying even if config is
> broken? Should it be || cat config.log && false?

Yes, you right. I actually copied it from the "Trusty build with latest 
stable clang" job from commit ae1a772c :p

I'll see to fix other occurrences.
diff mbox

Patch

diff --git a/.travis.yml b/.travis.yml
index 96ddc16cfd..bac5bea744 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -93,7 +93,7 @@  before_script:
   - if [ -x "$(command -v ccache 2>/dev/null)" ]; then export CC="ccache ${CC}"; ccache -s -M 0 -z; fi
   - echo "Using ${PARALLEL_JOBS} parallel jobs"
   - export HOST_CC="${CC}"
-  - ./configure ${CONFIG}
+  - ./configure ${CONFIG} || cat config.log
 script:
   - make -j${PARALLEL_JOBS} && ccache -s
   - ${TEST_CMD}