Message ID | 20170519112415.19191-1-kraxel@redhat.com |
---|---|
State | New |
Headers | show |
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170519112415.19191-1-kraxel@redhat.com Type: series Subject: [Qemu-devel] [PULL 0/3] audio patch queue. === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' bd45295 audio: Rename hw/audio/audio.h to hw/audio/soundhw.h d49234a audio: Rename audio_init() to soundhw_init() 2f8d27b audio: Move arch_init audio code to hw/audio/soundhw.c === OUTPUT BEGIN === Checking PATCH 1/3: audio: Move arch_init audio code to hw/audio/soundhw.c... ERROR: suspect code indent for conditional statements (8, 13) #248: FILE: hw/audio/soundhw.c:76: + if (soundhw_count) { + printf("Valid sound card names (comma separated):\n"); ERROR: suspect code indent for conditional statements (13, 17) #250: FILE: hw/audio/soundhw.c:78: + for (c = soundhw; c->name; ++c) { + printf ("%-11s %s\n", c->name, c->descr); ERROR: space prohibited between function name and open parenthesis '(' #251: FILE: hw/audio/soundhw.c:79: + printf ("%-11s %s\n", c->name, c->descr); ERROR: else should follow close brace '}' #260: FILE: hw/audio/soundhw.c:88: + } + else { ERROR: else should follow close brace '}' #289: FILE: hw/audio/soundhw.c:117: + } + else { WARNING: line over 80 characters #307: FILE: hw/audio/soundhw.c:135: + ISABus *isa_bus = (ISABus *) object_resolve_path_type("", TYPE_ISA_BUS, NULL); WARNING: line over 80 characters #308: FILE: hw/audio/soundhw.c:136: + PCIBus *pci_bus = (PCIBus *) object_resolve_path_type("", TYPE_PCI_BUS, NULL); total: 5 errors, 2 warnings, 320 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 2/3: audio: Rename audio_init() to soundhw_init()... Checking PATCH 3/3: audio: Rename hw/audio/audio.h to hw/audio/soundhw.h... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@freelists.org
On Fri, May 19, 2017 at 01:24:12PM +0200, Gerd Hoffmann wrote: > Hi, > > Smallish audio patch queue, renaming moving soundhw init code. > > please pull, > Gerd > > The following changes since commit 56821559f0ba682fe6b367815572e6f974d329ab: > > Merge remote-tracking branch 'dgilbert/tags/pull-hmp-20170517' into staging (2017-05-18 13:36:15 +0100) > > are available in the git repository at: > > git://git.kraxel.org/qemu tags/pull-audio-20170519-1 > > for you to fetch changes up to 8a824e4d74213a2da39323304f949c5b4243e1fb: > > audio: Rename hw/audio/audio.h to hw/audio/soundhw.h (2017-05-19 10:48:54 +0200) > > ---------------------------------------------------------------- > audio: move & rename soundhw init code. > > ---------------------------------------------------------------- > Eduardo Habkost (3): > audio: Move arch_init audio code to hw/audio/soundhw.c > audio: Rename audio_init() to soundhw_init() > audio: Rename hw/audio/audio.h to hw/audio/soundhw.h > > include/hw/audio/{audio.h => soundhw.h} | 3 + > include/sysemu/arch_init.h | 2 - > arch_init.c | 126 +------------------------- > hw/audio/ac97.c | 2 +- > hw/audio/adlib.c | 2 +- > hw/audio/cs4231a.c | 2 +- > hw/audio/es1370.c | 2 +- > hw/audio/gus.c | 2 +- > hw/audio/intel-hda.c | 2 +- > hw/audio/pcspk.c | 2 +- > hw/audio/sb16.c | 2 +- > hw/audio/soundhw.c | 156 ++++++++++++++++++++++++++++++++ > hw/ppc/prep.c | 3 +- > vl.c | 3 +- > hw/audio/Makefile.objs | 2 + > 15 files changed, 174 insertions(+), 137 deletions(-) > rename include/hw/audio/{audio.h => soundhw.h} (81%) > create mode 100644 hw/audio/soundhw.c > Coding style violations are pre-existing. That's fine. Thanks, applied to my staging tree: https://github.com/stefanha/qemu/commits/staging Stefan