From patchwork Fri May 12 23:38:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 761889 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wPmmC0nPMz9s7w for ; Sat, 13 May 2017 09:44:43 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="klCY5Xnx"; dkim-atps=neutral Received: from localhost ([::1]:55700 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9KEi-0004mK-Lu for incoming@patchwork.ozlabs.org; Fri, 12 May 2017 19:44:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9K9J-0008TL-LV for qemu-devel@nongnu.org; Fri, 12 May 2017 19:39:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d9K9I-0002a6-Or for qemu-devel@nongnu.org; Fri, 12 May 2017 19:39:05 -0400 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:36644) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d9K9I-0002ZZ-Ka; Fri, 12 May 2017 19:39:04 -0400 Received: by mail-qt0-x241.google.com with SMTP id j13so8688318qta.3; Fri, 12 May 2017 16:39:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ARntjubsQyR5+cZJSQIcfrChA/eTk2P8uu7CiiT9EvA=; b=klCY5Xnx55F7mI8kpKhxZmj/0n94BqiiHoWtKGaQ/JQdtq24x8fuhTExFB1OeJ1INM +zS/rHcCyoQ4Ba0gdqzdqY+vkyZiSELNZkHdbz1jA7Ie2ftlv/kTOSpcVBn2TK9Hm2QG 5NZAxvHESBVndBVhHlG5qGRSzdSlQaHFV7UYI0lhpb781YOY/3UdAXGrCKMq0lAeo5JF 4ZxefLuBnyLabsSWXAxzzfJp3AsVJ2HNl5tYRGAnkyiWFbIpRspDKtNGZjTj1DGYrriP OLyWz2QoJaMd9W0Bm0axTow8THc/GTnw82rHyAL/ZcCYjHZhFX+JIqfPQuxVyHiZ/9GD cRyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ARntjubsQyR5+cZJSQIcfrChA/eTk2P8uu7CiiT9EvA=; b=Rtj2B7EmLxymD1IjN1tgzJWbumDZa2nUCyehvwCtgxlsgTL4OiFySlL4MriYYsbytp yTF88Oial4tIinrrWjjR20MoLDOzL6D5KamdYUA0YQCnM1Qy0W1MC5qvnvAr8gCNfHxO FCuaxbtnFJ/HSzqEJn8vhh39L2WJ6fi2OX1hsUQnUJx5ZnfdHyAB644xbxraMHYrq8W2 o/n3gE2WNjLt002pCKznGSZC/sTEOV06cYXSMyzrry1MohZOREa96dcsiZ8mMdyDUPJ6 kjm8uRV/nxaikdhTkxbbz73IjAHqHyVcw1l3vuuE+rn4jkRQTcDVpB9pZdJFkAjE7zZP VHFw== X-Gm-Message-State: AODbwcDoVdPGIpFlkhGCheSELMemkn/f3F3G+hs4p8FA+LCLe8qI/N4A dkx3Jbb/shbtOA== X-Received: by 10.200.37.26 with SMTP id 26mr6736072qtm.278.1494632344095; Fri, 12 May 2017 16:39:04 -0700 (PDT) Received: from localhost.localdomain ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id n78sm3253857qki.60.2017.05.12.16.39.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 May 2017 16:39:03 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell , Aurelien Jarno , Richard Henderson , qemu-arm@nongnu.org Date: Fri, 12 May 2017 20:38:40 -0300 Message-Id: <20170512233843.27713-4-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170512233843.27713-1-f4bug@amsat.org> References: <20170512233843.27713-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH v4 3/6] target/arm: optimize rev16() using extract op X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Patch created mechanically using Coccinelle script via: $ spatch --macro-file scripts/cocci-macro-file.h --in-place \ --sp-file scripts/coccinelle/tcg_gen_extract.cocci --dir target Signed-off-by: Philippe Mathieu-Daudé --- target/arm/translate-a64.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 24de30d92c..759b2466ef 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -4038,14 +4038,12 @@ static void handle_rev16(DisasContext *s, unsigned int sf, tcg_gen_andi_i64(tcg_tmp, tcg_rn, 0xffff); tcg_gen_bswap16_i64(tcg_rd, tcg_tmp); - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 16); - tcg_gen_andi_i64(tcg_tmp, tcg_tmp, 0xffff); + tcg_gen_extract_i64(tcg_tmp, tcg_rn, 16, 16); tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp); tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, 16, 16); if (sf) { - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 32); - tcg_gen_andi_i64(tcg_tmp, tcg_tmp, 0xffff); + tcg_gen_extract_i64(tcg_tmp, tcg_rn, 32, 16); tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp); tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, 32, 16);