From patchwork Fri May 12 03:35:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 761431 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wPG18158zz9s7k for ; Fri, 12 May 2017 13:39:08 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="saq/o/O9"; dkim-atps=neutral Received: from localhost ([::1]:51161 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d91Q1-0000IS-Pd for incoming@patchwork.ozlabs.org; Thu, 11 May 2017 23:39:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47256) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d91NJ-0006YZ-1B for qemu-devel@nongnu.org; Thu, 11 May 2017 23:36:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d91NF-0003dD-0p for qemu-devel@nongnu.org; Thu, 11 May 2017 23:36:16 -0400 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:35437) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d91NE-0003cp-TK; Thu, 11 May 2017 23:36:12 -0400 Received: by mail-qt0-x241.google.com with SMTP id r58so5366380qtb.2; Thu, 11 May 2017 20:36:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nhTGRxVfoJ7Ah/YLU6COAHFDl7Y4Ci8qhe51bjgzQXc=; b=saq/o/O9iOxF4meuv42d7hLJHLuPQuyhgUdSNspUlyDYoXb80FUKFZ8sPpsEAcFvMS Dnt1/ThvckOroxFmrkxHML+cuZ5Yyb2uy0DX3dg7VKUUOyT8+kqp3YGr6lcLHN8hZwRW Wc9VvVCbRVad2PoSNia0sVY6WnewB8dJkvfeZE/QrcZf300IUitCSUv2nm2Fc6+XpIQg dlwAKI7irrzAsNRMwKfEpCBKN5rcvZt+emjDOLMMUwqKNuX2sOXArw1YPrxrB6waIRIe GeN1D/m/Tzp+ERL85K9uZ5PUN5WYLG1etZucqJdG2Kfv34VxcEeB/C7az1m8kEel4rhe t1pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=nhTGRxVfoJ7Ah/YLU6COAHFDl7Y4Ci8qhe51bjgzQXc=; b=h5SZbx+r++4hXUXCmVbcH9YUlamM/UiMYJqtld5riOf6GI8rS5Xfa0nNPirEexSvWX n0gHtLWmJGShK84kfSePsxCmrdEYip4BxGZuaJ96smsX5yZ6/M8c7vUqCBI0ye7l4pDo 8As6uVmRdxfwjayqo6xNWe9Jv5MnF44JhjKu/oBW0scWA4tDyJtGEDsanqyvHkaaSmks NqDk+livS1oJ7EZQGYaq7iIERNZ2ZnIADg2nYG6gh9/KoEfHI1eP5im9iVWCDVunOGox tnOFZLpszKNek/5m+TkNq48hroPjUaE5Xw8Y/ZkS22r5xqvCmzb84R/s4fFfyguKivgV prvw== X-Gm-Message-State: AODbwcB4phSmvdva3zl0F0356oIg/qE527MOCtQl7Z0BFwkzmHTAOfVH XfYzcp5Ys1JyPg== X-Received: by 10.237.53.149 with SMTP id c21mr1831176qte.191.1494560172376; Thu, 11 May 2017 20:36:12 -0700 (PDT) Received: from localhost.localdomain ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id m188sm1443267qkc.5.2017.05.11.20.36.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 May 2017 20:36:11 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell , Aurelien Jarno , Richard Henderson , qemu-arm@nongnu.org Date: Fri, 12 May 2017 00:35:40 -0300 Message-Id: <20170512033543.6789-3-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170512033543.6789-1-f4bug@amsat.org> References: <20170512033543.6789-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH v3 2/5] target/arm: optimize rev16() using extract op X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Patch created mechanically using Coccinelle script via: $ spatch --macro-file scripts/cocci-macro-file.h --in-place \ --sp-file scripts/coccinelle/tcg_gen_extract.cocci --dir target Signed-off-by: Philippe Mathieu-Daudé --- target/arm/translate-a64.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 24de30d92c..7ea130107e 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -4038,14 +4038,12 @@ static void handle_rev16(DisasContext *s, unsigned int sf, tcg_gen_andi_i64(tcg_tmp, tcg_rn, 0xffff); tcg_gen_bswap16_i64(tcg_rd, tcg_tmp); - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 16); - tcg_gen_andi_i64(tcg_tmp, tcg_tmp, 0xffff); + tcg_gen_extract_i64(tcg_tmp, tcg_rn, 16, 0xffff); tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp); tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, 16, 16); if (sf) { - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 32); - tcg_gen_andi_i64(tcg_tmp, tcg_tmp, 0xffff); + tcg_gen_extract_i64(tcg_tmp, tcg_rn, 32, 0xffff); tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp); tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, 32, 16);