From patchwork Wed May 10 20:05:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 760825 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wNS265VDVz9s86 for ; Thu, 11 May 2017 06:07:10 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="CB1nHGB3"; dkim-atps=neutral Received: from localhost ([::1]:44584 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8Xt6-0008KX-2V for incoming@patchwork.ozlabs.org; Wed, 10 May 2017 16:07:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8XsM-0008Iw-58 for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8XsL-0006XO-5E for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:22 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:36738) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8XsL-0006X3-0a; Wed, 10 May 2017 16:06:21 -0400 Received: by mail-qk0-x244.google.com with SMTP id y128so946315qka.3; Wed, 10 May 2017 13:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MRGtuARN+YANv2ESqDGJaDWo89L1CTLQkC9GmaN6Jto=; b=CB1nHGB3JDaT0sspgRswtoVKJwAWqYTeiKMr5HOe1exQstPGveeSnmHnk8xnIZZTaq RpR5BYFZMWLFVBjULlGUJ1OmRVPPDbrFaa9KeRaBt0GQDYMlpLs+9kSVKTsIgIgHQ7ev AFm+wgKaztCVbdLosyjk8LSxmQ2Dr/35dLgNA/+RQokFsAzTxw1WMfC8q6iHJPTsFnMl 9AmZ127rkA29SPMkl5+0QrK1P1J6MBoTZt8pDBlHzGPZFXpGA+Fi+5jL2m6gi17k8Pzo zzDsXv9xKJ9Y4r5S0yQw7PutyACyyOdhV+UoUA5sIu+42qndLCFRkFHPrZDhqjywGDsz uhVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=MRGtuARN+YANv2ESqDGJaDWo89L1CTLQkC9GmaN6Jto=; b=lWeYIFdtIP0qdWQd8+WZLRO5XKSfkwBpOTJFl0wmQIyDwH081z3c2H+zzbRJBQLwp3 RJbc3F+Ez6hHUXqKWp4agnq31J5lVP5ZKE+1Dr8hkBMIWnHyqHhSj2UHtdT2mnby1MGp JtqvLi4apMQOasa1c4X+8j/+sNsy8NnKqgAAfBXUardpc3R+zobK0c61sNTHk/ku5su2 R+7NLl4AxaVLLJxwjRaVpkkohrbBQhx62PypQ0WIp+JA4hTUPm21gYSks09hfJUd7C5z 7mWDYw001dSKr3ar659O2LnmY9ScIf1oD/EJLcFwiETGnHZ2Y5yTaPNcKp0FyREKFo9p 7WDA== X-Gm-Message-State: AODbwcBMEk/V4zXbH6Ixo/UrzJ4UqkuVu//ngqralvCaBltd1d72B/yi v3Ym4phWVT5yNw== X-Received: by 10.55.26.215 with SMTP id l84mr7020982qkh.307.1494446780462; Wed, 10 May 2017 13:06:20 -0700 (PDT) Received: from localhost.localdomain ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id s190sm377398qkh.57.2017.05.10.13.06.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 May 2017 13:06:19 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Aurelien Jarno , Richard Henderson , David Gibson , Alexander Graf , qemu-ppc@nongnu.org Date: Wed, 10 May 2017 17:05:34 -0300 Message-Id: <20170510200535.13268-8-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170510200535.13268-1-f4bug@amsat.org> References: <20170510200535.13268-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH 7/8] target/ppc: optimize various functions using extract op X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Applied using Coccinelle script. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: David Gibson --- target/ppc/translate.c | 9 +++------ target/ppc/translate/vsx-impl.inc.c | 21 +++++++-------------- 2 files changed, 10 insertions(+), 20 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index f40b5a1abf..64ab412bf3 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -868,8 +868,7 @@ static inline void gen_op_arith_add(DisasContext *ctx, TCGv ret, TCGv arg1, } tcg_gen_xor_tl(cpu_ca, t0, t1); /* bits changed w/ carry */ tcg_temp_free(t1); - tcg_gen_shri_tl(cpu_ca, cpu_ca, 32); /* extract bit 32 */ - tcg_gen_andi_tl(cpu_ca, cpu_ca, 1); + tcg_gen_extract_tl(cpu_ca, cpu_ca, 32, 1); if (is_isa300(ctx)) { tcg_gen_mov_tl(cpu_ca32, cpu_ca); } @@ -1399,8 +1398,7 @@ static inline void gen_op_arith_subf(DisasContext *ctx, TCGv ret, TCGv arg1, tcg_temp_free(inv1); tcg_gen_xor_tl(cpu_ca, t0, t1); /* bits changes w/ carry */ tcg_temp_free(t1); - tcg_gen_shri_tl(cpu_ca, cpu_ca, 32); /* extract bit 32 */ - tcg_gen_andi_tl(cpu_ca, cpu_ca, 1); + tcg_gen_extract_tl(cpu_ca, cpu_ca, 32, 1); if (is_isa300(ctx)) { tcg_gen_mov_tl(cpu_ca32, cpu_ca); } @@ -5383,8 +5381,7 @@ static void gen_mfsri(DisasContext *ctx) CHK_SV; t0 = tcg_temp_new(); gen_addr_reg_index(ctx, t0); - tcg_gen_shri_tl(t0, t0, 28); - tcg_gen_andi_tl(t0, t0, 0xF); + tcg_gen_extract_tl(t0, t0, 28, 0xF); gen_helper_load_sr(cpu_gpr[rd], cpu_env, t0); tcg_temp_free(t0); if (ra != 0 && ra != rd) diff --git a/target/ppc/translate/vsx-impl.inc.c b/target/ppc/translate/vsx-impl.inc.c index 7f12908029..354a6b113a 100644 --- a/target/ppc/translate/vsx-impl.inc.c +++ b/target/ppc/translate/vsx-impl.inc.c @@ -1262,8 +1262,7 @@ static void gen_xsxexpqp(DisasContext *ctx) gen_exception(ctx, POWERPC_EXCP_VSXU); return; } - tcg_gen_shri_i64(xth, xbh, 48); - tcg_gen_andi_i64(xth, xth, 0x7FFF); + tcg_gen_extract_i64(xth, xbh, 48, 0x7FFF); tcg_gen_movi_i64(xtl, 0); } @@ -1431,10 +1430,8 @@ static void gen_xvxexpsp(DisasContext *ctx) gen_exception(ctx, POWERPC_EXCP_VSXU); return; } - tcg_gen_shri_i64(xth, xbh, 23); - tcg_gen_andi_i64(xth, xth, 0xFF000000FF); - tcg_gen_shri_i64(xtl, xbl, 23); - tcg_gen_andi_i64(xtl, xtl, 0xFF000000FF); + tcg_gen_extract_i64(xth, xbh, 23, 0xFF000000FF); + tcg_gen_extract_i64(xtl, xbl, 23, 0xFF000000FF); } static void gen_xvxexpdp(DisasContext *ctx) @@ -1448,10 +1445,8 @@ static void gen_xvxexpdp(DisasContext *ctx) gen_exception(ctx, POWERPC_EXCP_VSXU); return; } - tcg_gen_shri_i64(xth, xbh, 52); - tcg_gen_andi_i64(xth, xth, 0x7FF); - tcg_gen_shri_i64(xtl, xbl, 52); - tcg_gen_andi_i64(xtl, xtl, 0x7FF); + tcg_gen_extract_i64(xth, xbh, 52, 0x7FF); + tcg_gen_extract_i64(xtl, xbl, 52, 0x7FF); } GEN_VSX_HELPER_2(xvxsigsp, 0x00, 0x04, 0, PPC2_ISA300) @@ -1474,16 +1469,14 @@ static void gen_xvxsigdp(DisasContext *ctx) zr = tcg_const_i64(0); nan = tcg_const_i64(2047); - tcg_gen_shri_i64(exp, xbh, 52); - tcg_gen_andi_i64(exp, exp, 0x7FF); + tcg_gen_extract_i64(exp, xbh, 52, 0x7FF); tcg_gen_movi_i64(t0, 0x0010000000000000); tcg_gen_movcond_i64(TCG_COND_EQ, t0, exp, zr, zr, t0); tcg_gen_movcond_i64(TCG_COND_EQ, t0, exp, nan, zr, t0); tcg_gen_andi_i64(xth, xbh, 0x000FFFFFFFFFFFFF); tcg_gen_or_i64(xth, xth, t0); - tcg_gen_shri_i64(exp, xbl, 52); - tcg_gen_andi_i64(exp, exp, 0x7FF); + tcg_gen_extract_i64(exp, xbl, 52, 0x7FF); tcg_gen_movi_i64(t0, 0x0010000000000000); tcg_gen_movcond_i64(TCG_COND_EQ, t0, exp, zr, zr, t0); tcg_gen_movcond_i64(TCG_COND_EQ, t0, exp, nan, zr, t0);