From patchwork Thu Apr 20 14:05:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fam Zheng X-Patchwork-Id: 752821 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3w80yc5dt3z9s4s for ; Fri, 21 Apr 2017 00:06:00 +1000 (AEST) Received: from localhost ([::1]:54034 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d1Cia-0003xE-8G for incoming@patchwork.ozlabs.org; Thu, 20 Apr 2017 10:05:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45310) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d1CiF-0003wk-8Y for qemu-devel@nongnu.org; Thu, 20 Apr 2017 10:05:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d1CiB-0006Iz-8z for qemu-devel@nongnu.org; Thu, 20 Apr 2017 10:05:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47334) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d1Ci1-000683-1Z; Thu, 20 Apr 2017 10:05:21 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 580B38E3F1; Thu, 20 Apr 2017 14:05:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 580B38E3F1 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=famz@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 580B38E3F1 Received: from localhost (ovpn-8-22.pek2.redhat.com [10.72.8.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id 011BF189F3; Thu, 20 Apr 2017 14:05:17 +0000 (UTC) Date: Thu, 20 Apr 2017 22:05:14 +0800 From: Fam Zheng To: Peter Lieven Message-ID: <20170420140514.GM24486@lemon.lan> References: <1488288927-4607-1-git-send-email-pl@kamp.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1488288927-4607-1-git-send-email-pl@kamp.de> User-Agent: Mutt/1.8.0 (2017-02-23) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 20 Apr 2017 14:05:19 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] qemu-img: simplify img_convert X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, qemu-block@nongnu.org, ct@flyingcircus.io, stefanha@gmail.com, qemu-devel@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" On Tue, 02/28 14:35, Peter Lieven wrote: > img_convert has been around before there was an ImgConvertState or > a block backend, but it has never been modified to directly use > these structs. Change this by parsing parameters directly into > the ImgConvertState and directly use BlockBackend where possible. > Futhermore variable initalization has been reworked and sorted. > > Signed-off-by: Peter Lieven I see an iotest failure with this patch, in Kevin's block-next tree: 019 1s ... - output mismatch (see 019.out.bad) Failures: 019 Failed 1 of 1 tests --- /stor/work/qemu/tests/qemu-iotests/019.out 2017-04-17 16:19:56.523968474 +0800 +++ 019.out.bad 2017-04-20 22:03:29.868216955 +0800 @@ -1086,8 +1086,8 @@ Checking if backing clusters are allocated when they shouldn't -0/128 sectors allocated at offset 1 MiB -0/128 sectors allocated at offset 4.001 GiB +128/128 sectors allocated at offset 1 MiB +128/128 sectors allocated at offset 4.001 GiB Reading === IO: pattern 42