From patchwork Tue Apr 4 20:24:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eduardo Habkost X-Patchwork-Id: 746947 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vyLJM3md4z9s86 for ; Wed, 5 Apr 2017 06:32:51 +1000 (AEST) Received: from localhost ([::1]:37512 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvV8D-0008Op-1r for incoming@patchwork.ozlabs.org; Tue, 04 Apr 2017 16:32:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvV1F-0002LC-1C for qemu-devel@nongnu.org; Tue, 04 Apr 2017 16:25:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cvV1E-0003D3-13 for qemu-devel@nongnu.org; Tue, 04 Apr 2017 16:25:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34880) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cvV1D-0003Co-BU for qemu-devel@nongnu.org; Tue, 04 Apr 2017 16:25:35 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 693B98E007; Tue, 4 Apr 2017 20:25:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 693B98E007 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 693B98E007 Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id E0645189C2; Tue, 4 Apr 2017 20:25:33 +0000 (UTC) From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Tue, 4 Apr 2017 17:24:21 -0300 Message-Id: <20170404202429.14643-14-ehabkost@redhat.com> In-Reply-To: <20170404202429.14643-1-ehabkost@redhat.com> References: <20170404202429.14643-1-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 04 Apr 2017 20:25:34 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 13/21] unimplemented-device: Remove user_creatable flag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Alexander Graf , Markus Armbruster , Marcel Apfelbaum , Laszlo Ersek Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" unimplemented-device needs to be created and mapped using create_unimplemented_device() (or equivalent code), and won't work with -device. Remove the user_creatable flag from the device class. Cc: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Commit message rewrite only --- hw/misc/unimp.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/misc/unimp.c b/hw/misc/unimp.c index e446c1d652..bcbb585888 100644 --- a/hw/misc/unimp.c +++ b/hw/misc/unimp.c @@ -90,11 +90,6 @@ static void unimp_class_init(ObjectClass *klass, void *data) dc->realize = unimp_realize; dc->props = unimp_properties; - /* - * FIXME: Set only because we are not sure yet if this device - * will be outside the q35 sysbus whitelist. - */ - dc->user_creatable = true; } static const TypeInfo unimp_info = {