From patchwork Thu Mar 23 18:51:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinzenz 'evilissimo' Feenstra X-Patchwork-Id: 743685 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vs8Dp0tKgz9s2Q for ; Mon, 27 Mar 2017 20:41:45 +1100 (AEDT) Received: from localhost ([::1]:45318 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csR9i-0003Wh-3t for incoming@patchwork.ozlabs.org; Mon, 27 Mar 2017 05:41:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csR9O-0003Vq-66 for qemu-devel@nongnu.org; Mon, 27 Mar 2017 05:41:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csR9J-0004mA-7C for qemu-devel@nongnu.org; Mon, 27 Mar 2017 05:41:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47236) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1csR9J-0004lZ-1n for qemu-devel@nongnu.org; Mon, 27 Mar 2017 05:41:17 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 268B461D3B; Mon, 27 Mar 2017 09:41:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 268B461D3B Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vfeenstr@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 268B461D3B Received: from evilvm.brq.redhat.com (dhcp131-51.brq.redhat.com [10.34.131.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id 45EF88F7D6; Mon, 27 Mar 2017 09:41:13 +0000 (UTC) From: Vinzenz 'evilissimo' Feenstra To: qemu-devel@nongnu.org Date: Thu, 23 Mar 2017 19:51:07 +0100 Message-Id: <20170323185107.2261-1-vfeenstr@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 27 Mar 2017 09:41:15 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v1] qga: Add 'guest-get-fqdn' command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.vnet.ibm.com, Vinzenz Feenstra Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Vinzenz Feenstra Retrieving the guest OS fully qualified domain name (FQDN) is a very useful feature for virtual management systems. This information can help to have more user friendly VM access details, instead of an IP there would be the FQDN. Also the FQDN reported can be used to have automated checks for valid SSL certificates. virsh # qemu-agent-command F25 '{ "execute": "guest-get-fqdn" }' {"return":{"fqdn":"F25.lab.evilissimo.net"}} Signed-off-by: Vinzenz Feenstra --- qga/commands.c | 11 +++++++++++ qga/qapi-schema.json | 25 +++++++++++++++++++++++++ 2 files changed, 36 insertions(+) diff --git a/qga/commands.c b/qga/commands.c index 4d92946..61577af 100644 --- a/qga/commands.c +++ b/qga/commands.c @@ -499,3 +499,14 @@ int ga_parse_whence(GuestFileWhence *whence, Error **errp) error_setg(errp, "invalid whence code %"PRId64, whence->u.value); return -1; } + +GuestFQDN *qmp_guest_get_fqdn(Error **err) +{ + GuestFQDN *result = NULL; + gchar const *hostname = g_get_host_name(); + if (hostname != NULL) { + result = g_new0(GuestFQDN, 1); + result->fqdn = g_strdup(hostname); + } + return result; +} diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index a02dbf2..0a2c0a4 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -1042,3 +1042,28 @@ 'data': { 'path': 'str', '*arg': ['str'], '*env': ['str'], '*input-data': 'str', '*capture-output': 'bool' }, 'returns': 'GuestExec' } + + + +## +# @GuestFQDN: +# @fqdn: Fully qualified domain name of the guest OS +# +# Since: 2.10 +## +{ 'struct': 'GuestFQDN', + 'data': { 'fqdn': 'str' } } + + +## +# @guest-get-fqdn: +# +# Request the FQDN (Fully Qualified Domain Name) of the guest operating system +# +# Returns: FQDN on success +# +# Since: 2.10 +## +{ 'command': 'guest-get-fqdn', + 'returns': 'GuestFQDN' } +