| Message ID | 20170323173928.14439-3-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 03/23/2017 01:39 PM, Paolo Bonzini wrote: > This is unused since commit 66a0fae ("blockjob: Don't touch BDS iostatus", > 2016-05-19). > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > blockjob.c | 3 --- > include/block/blockjob_int.h | 3 --- > 2 files changed, 6 deletions(-) > > diff --git a/blockjob.c b/blockjob.c > index a9fb624..24d1e12 100644 > --- a/blockjob.c > +++ b/blockjob.c > @@ -555,9 +555,6 @@ bool block_job_is_cancelled(BlockJob *job) > void block_job_iostatus_reset(BlockJob *job) > { > job->iostatus = BLOCK_DEVICE_IO_STATUS_OK; > - if (job->driver->iostatus_reset) { > - job->driver->iostatus_reset(job); > - } > } > > static int block_job_finish_sync(BlockJob *job, > diff --git a/include/block/blockjob_int.h b/include/block/blockjob_int.h > index 3f86cc5..bfcc5d1 100644 > --- a/include/block/blockjob_int.h > +++ b/include/block/blockjob_int.h > @@ -44,9 +44,6 @@ struct BlockJobDriver { > /** Optional callback for job types that support setting a speed limit */ > void (*set_speed)(BlockJob *job, int64_t speed, Error **errp); > > - /** Optional callback for job types that need to forward I/O status reset */ > - void (*iostatus_reset)(BlockJob *job); > - > /** Mandatory: Entrypoint for the Coroutine. */ > CoroutineEntry *start; > > Good find. Reviewed-by: John Snow <jsnow@redhat.com>
On 04/07/2017 08:12 PM, John Snow wrote: > On 03/23/2017 01:39 PM, Paolo Bonzini wrote: >> This is unused since commit 66a0fae ("blockjob: Don't touch BDS iostatus", >> 2016-05-19). >> >> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> >> --- >> blockjob.c | 3 --- >> include/block/blockjob_int.h | 3 --- >> 2 files changed, 6 deletions(-) >> >> diff --git a/blockjob.c b/blockjob.c >> index a9fb624..24d1e12 100644 >> --- a/blockjob.c >> +++ b/blockjob.c >> @@ -555,9 +555,6 @@ bool block_job_is_cancelled(BlockJob *job) >> void block_job_iostatus_reset(BlockJob *job) >> { >> job->iostatus = BLOCK_DEVICE_IO_STATUS_OK; >> - if (job->driver->iostatus_reset) { >> - job->driver->iostatus_reset(job); >> - } >> } >> >> static int block_job_finish_sync(BlockJob *job, >> diff --git a/include/block/blockjob_int.h b/include/block/blockjob_int.h >> index 3f86cc5..bfcc5d1 100644 >> --- a/include/block/blockjob_int.h >> +++ b/include/block/blockjob_int.h >> @@ -44,9 +44,6 @@ struct BlockJobDriver { >> /** Optional callback for job types that support setting a speed limit */ >> void (*set_speed)(BlockJob *job, int64_t speed, Error **errp); >> >> - /** Optional callback for job types that need to forward I/O status reset */ >> - void (*iostatus_reset)(BlockJob *job); >> - >> /** Mandatory: Entrypoint for the Coroutine. */ >> CoroutineEntry *start; >> >> > > Good find. > > Reviewed-by: John Snow <jsnow@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
On Thu, Mar 23, 2017 at 06:39:20PM +0100, Paolo Bonzini wrote: > This is unused since commit 66a0fae ("blockjob: Don't touch BDS iostatus", > 2016-05-19). > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > blockjob.c | 3 --- > include/block/blockjob_int.h | 3 --- > 2 files changed, 6 deletions(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
diff --git a/blockjob.c b/blockjob.c index a9fb624..24d1e12 100644 --- a/blockjob.c +++ b/blockjob.c @@ -555,9 +555,6 @@ bool block_job_is_cancelled(BlockJob *job) void block_job_iostatus_reset(BlockJob *job) { job->iostatus = BLOCK_DEVICE_IO_STATUS_OK; - if (job->driver->iostatus_reset) { - job->driver->iostatus_reset(job); - } } static int block_job_finish_sync(BlockJob *job, diff --git a/include/block/blockjob_int.h b/include/block/blockjob_int.h index 3f86cc5..bfcc5d1 100644 --- a/include/block/blockjob_int.h +++ b/include/block/blockjob_int.h @@ -44,9 +44,6 @@ struct BlockJobDriver { /** Optional callback for job types that support setting a speed limit */ void (*set_speed)(BlockJob *job, int64_t speed, Error **errp); - /** Optional callback for job types that need to forward I/O status reset */ - void (*iostatus_reset)(BlockJob *job); - /** Mandatory: Entrypoint for the Coroutine. */ CoroutineEntry *start;
This is unused since commit 66a0fae ("blockjob: Don't touch BDS iostatus", 2016-05-19). Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- blockjob.c | 3 --- include/block/blockjob_int.h | 3 --- 2 files changed, 6 deletions(-)