Message ID | 20170315123421.28815-1-berrange@redhat.com |
---|---|
State | New |
Headers | show |
On 03/15/2017 07:34 AM, Daniel P. Berrange wrote: > The build rules for trace files have a dependancy on $(tracetool-y). > This variable populated in the trace/Makefile.objs file and thus its > definition gets pulled into the top level makefile. This happens too > late in the process though, so by the time $(tracetool-y) is defined, > make has already evaluated $(tracetool-y) in the dependancies and > found it to be empty. The result is that when the tracetool source > is changed, the generated files are not rebuilt. The solution is to > define the variable in the top level makefile too > > Signed-off-by: Daniel P. Berrange <berrange@redhat.com> > --- > Makefile | 3 +++ > trace/Makefile.objs | 8 -------- > 2 files changed, 3 insertions(+), 8 deletions(-) Reviewed-by: Eric Blake <eblake@redhat.com> Tested-by: Eric Blake <eblake@redhat.com>
On Wed, Mar 15, 2017 at 12:34:21PM +0000, Daniel P. Berrange wrote: > The build rules for trace files have a dependancy on $(tracetool-y). > This variable populated in the trace/Makefile.objs file and thus its > definition gets pulled into the top level makefile. This happens too > late in the process though, so by the time $(tracetool-y) is defined, > make has already evaluated $(tracetool-y) in the dependancies and > found it to be empty. The result is that when the tracetool source > is changed, the generated files are not rebuilt. The solution is to > define the variable in the top level makefile too > > Signed-off-by: Daniel P. Berrange <berrange@redhat.com> > --- > Makefile | 3 +++ > trace/Makefile.objs | 8 -------- > 2 files changed, 3 insertions(+), 8 deletions(-) Thanks, applied to my tracing tree: https://github.com/stefanha/qemu/commits/tracing Stefan
diff --git a/Makefile b/Makefile index 1c4c04f..dffc74b 100644 --- a/Makefile +++ b/Makefile @@ -85,6 +85,9 @@ GENERATED_SOURCES += $(TRACE_SOURCES) trace-group-name = $(shell dirname $1 | sed -e 's/[^a-zA-Z0-9]/_/g') +tracetool-y = $(SRC_PATH)/scripts/tracetool.py +tracetool-y += $(shell find $(SRC_PATH)/scripts/tracetool -name "*.py") + %/trace.h: %/trace.h-timestamp @cmp $< $@ >/dev/null 2>&1 || cp $< $@ %/trace.h-timestamp: $(SRC_PATH)/%/trace-events $(tracetool-y) diff --git a/trace/Makefile.objs b/trace/Makefile.objs index 7de840a..1b8eb4a 100644 --- a/trace/Makefile.objs +++ b/trace/Makefile.objs @@ -1,13 +1,5 @@ # -*- mode: makefile -*- -###################################################################### -# tracetool source files -# Every rule that invokes tracetool must depend on this so code is regenerated -# if tracetool itself changes. - -tracetool-y = $(SRC_PATH)/scripts/tracetool.py -tracetool-y += $(shell find $(SRC_PATH)/scripts/tracetool -name "*.py") - $(BUILD_DIR)/trace-events-all: $(trace-events-files) $(call quiet-command,cat $^ > $@)
The build rules for trace files have a dependancy on $(tracetool-y). This variable populated in the trace/Makefile.objs file and thus its definition gets pulled into the top level makefile. This happens too late in the process though, so by the time $(tracetool-y) is defined, make has already evaluated $(tracetool-y) in the dependancies and found it to be empty. The result is that when the tracetool source is changed, the generated files are not rebuilt. The solution is to define the variable in the top level makefile too Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- Makefile | 3 +++ trace/Makefile.objs | 8 -------- 2 files changed, 3 insertions(+), 8 deletions(-)