From patchwork Tue Mar 14 12:38:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chao Fan X-Patchwork-Id: 738684 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vjDpW6Yh1z9s1h for ; Tue, 14 Mar 2017 23:40:02 +1100 (AEDT) Received: from localhost ([::1]:58522 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnlk7-0008KS-Ad for incoming@patchwork.ozlabs.org; Tue, 14 Mar 2017 08:39:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnljV-0008Ho-UN for qemu-devel@nongnu.org; Tue, 14 Mar 2017 08:39:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnljS-00082F-Ra for qemu-devel@nongnu.org; Tue, 14 Mar 2017 08:39:22 -0400 Received: from [59.151.112.132] (port=20553 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnljS-00081S-FG for qemu-devel@nongnu.org; Tue, 14 Mar 2017 08:39:18 -0400 X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; d="scan'208";a="16556932" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 14 Mar 2017 20:39:12 +0800 Received: from G08CNEXCHPEKD01.g08.fujitsu.local (unknown [10.167.33.80]) by cn.fujitsu.com (Postfix) with ESMTP id E8DEE48A2967; Tue, 14 Mar 2017 20:39:12 +0800 (CST) Received: from localhost (10.167.226.75) by G08CNEXCHPEKD01.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server id 14.3.319.2; Tue, 14 Mar 2017 20:39:11 +0800 From: Chao Fan To: , , , , Date: Tue, 14 Mar 2017 20:38:41 +0800 Message-ID: <20170314123841.2415-1-fanc.fnst@cn.fujitsu.com> X-Mailer: git-send-email 2.9.3 MIME-Version: 1.0 X-yoursite-MailScanner-ID: E8DEE48A2967.AD0B5 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: fanc.fnst@cn.fujitsu.com X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 59.151.112.132 Subject: [Qemu-devel] [PATCH] Add dirty-bytes-rate to output in 'info migrate' X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: douly.fnst@cn.fujitsu.com, caoj.fnst@cn.fujitsu.com, Chao Fan , maozy.fnst@cn.fujitsu.com, Li Zhijian Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Because 'dirty-bytes-rate' is in 'bytes/s', so it's better for other tools to determine the cpu throttle value in different architecture. Signed-off-by: Chao Fan Signed-off-by: Li Zhijian --- hmp.c | 6 +++++- migration/migration.c | 1 + qapi-schema.json | 5 ++++- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/hmp.c b/hmp.c index 261843f..c50d7aa 100644 --- a/hmp.c +++ b/hmp.c @@ -216,9 +216,13 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict) monitor_printf(mon, "dirty sync count: %" PRIu64 "\n", info->ram->dirty_sync_count); if (info->ram->dirty_pages_rate) { - monitor_printf(mon, "dirty pages rate: %" PRIu64 " pages\n", + monitor_printf(mon, "dirty pages rate: %" PRIu64 " pages/s\n", info->ram->dirty_pages_rate); } + if (info->ram->dirty_bytes_rate) { + monitor_printf(mon, "dirty bytes rate: %" PRIu64 " bytes/s\n", + info->ram->dirty_bytes_rate); + } if (info->ram->postcopy_requests) { monitor_printf(mon, "postcopy request count: %" PRIu64 "\n", info->ram->postcopy_requests); diff --git a/migration/migration.c b/migration/migration.c index 3dab684..27f13c7 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -649,6 +649,7 @@ static void populate_ram_info(MigrationInfo *info, MigrationState *s) if (s->state != MIGRATION_STATUS_COMPLETED) { info->ram->remaining = ram_bytes_remaining(); info->ram->dirty_pages_rate = s->dirty_pages_rate; + info->ram->dirty_bytes_rate = s->dirty_bytes_rate; } } diff --git a/qapi-schema.json b/qapi-schema.json index 32b4a4b..0d5ec8e 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -575,6 +575,9 @@ # @postcopy-requests: The number of page requests received from the destination # (since 2.7) # +# @dirty-bytes-rate: how many bytes dirtied by second by the +# guest (since 2.9) +# # Since: 0.14.0 ## { 'struct': 'MigrationStats', @@ -582,7 +585,7 @@ 'duplicate': 'int', 'skipped': 'int', 'normal': 'int', 'normal-bytes': 'int', 'dirty-pages-rate' : 'int', 'mbps' : 'number', 'dirty-sync-count' : 'int', - 'postcopy-requests' : 'int' } } + 'postcopy-requests' : 'int', 'dirty-bytes-rate' : 'int' } } ## # @XBZRLECacheStats: