| Message ID | 20170124115748.21473-2-berrange@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 24.01.2017 12:57, Daniel P. Berrange wrote: > While the qemu-img dd command does accept --image-opts > this is not sufficient to make it work with the LUKS > image yet. This is because bdrv_create() still always > requires the non-image-opts syntax. > > Thus we must skip 159/170 with luks for now > > Reviewed-by: Eric Blake <eblake@redhat.com> > Signed-off-by: Daniel P. Berrange <berrange@redhat.com> > --- > tests/qemu-iotests/159 | 2 +- > tests/qemu-iotests/170 | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) https://github.com/XanClic/qemu/commit/b4a2caa4bd5ad4e3cd6dd7eb1c0067d9205280cb introduces _unsupported_fmt. Would that be a better fit? (Yes, I'll send a pull request today.) Max
diff --git a/tests/qemu-iotests/159 b/tests/qemu-iotests/159 index 825f05f..7636865 100755 --- a/tests/qemu-iotests/159 +++ b/tests/qemu-iotests/159 @@ -37,7 +37,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 . ./common.filter . ./common.pattern -_supported_fmt generic +_supported_fmt raw qcow qcow2 qed _supported_proto file _supported_os Linux diff --git a/tests/qemu-iotests/170 b/tests/qemu-iotests/170 index 5b335db..6bd1c37 100755 --- a/tests/qemu-iotests/170 +++ b/tests/qemu-iotests/170 @@ -37,7 +37,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 . ./common.filter . ./common.pattern -_supported_fmt generic +_supported_fmt raw qcow qcow2 qed _supported_proto file _supported_os Linux