| Message ID | 20161206160345.22425-1-eblake@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Dec 6, 2016 at 7:04 PM Eric Blake <eblake@redhat.com> wrote: > Commit 2d76e72 failed to add a versioning tag to 'id'. > > I audited all qapi*.json files from v2.7.0 to the current > state of the tree, and didn't find any other additions where > we failed to use a version tag. > > Signed-off-by: Eric Blake <eblake@redhat.com> > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> --- > > Doc-only, so safe for 2.8. But we're also close enough to -rc3 > that I'm fine if it has to go in later via -stable. > > qapi/block.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qapi/block.json b/qapi/block.json > index 937df05..8e9f590 100644 > --- a/qapi/block.json > +++ b/qapi/block.json > @@ -199,7 +199,7 @@ > # reasons, but it can be empty ("") if the image does not > # have a device name associated. > # > -# @id: The name or QOM path of the guest device > +# @id: The name or QOM path of the guest device (since 2.8) > # > # @tray-open: true if the tray has been opened or false if it has been > closed > # > -- > 2.9.3 > > > -- Marc-André Lureau
On Tue, Dec 06, 2016 at 10:03:45AM -0600, Eric Blake wrote: > Commit 2d76e72 failed to add a versioning tag to 'id'. > > I audited all qapi*.json files from v2.7.0 to the current > state of the tree, and didn't find any other additions where > we failed to use a version tag. > > Signed-off-by: Eric Blake <eblake@redhat.com> > --- > > Doc-only, so safe for 2.8. But we're also close enough to -rc3 > that I'm fine if it has to go in later via -stable. > > qapi/block.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my staging tree: https://github.com/stefanha/qemu/commits/staging Stefan
diff --git a/qapi/block.json b/qapi/block.json index 937df05..8e9f590 100644 --- a/qapi/block.json +++ b/qapi/block.json @@ -199,7 +199,7 @@ # reasons, but it can be empty ("") if the image does not # have a device name associated. # -# @id: The name or QOM path of the guest device +# @id: The name or QOM path of the guest device (since 2.8) # # @tray-open: true if the tray has been opened or false if it has been closed #
Commit 2d76e72 failed to add a versioning tag to 'id'. I audited all qapi*.json files from v2.7.0 to the current state of the tree, and didn't find any other additions where we failed to use a version tag. Signed-off-by: Eric Blake <eblake@redhat.com> --- Doc-only, so safe for 2.8. But we're also close enough to -rc3 that I'm fine if it has to go in later via -stable. qapi/block.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)