diff mbox

[v4,01/15] qapi: improve device_add schema

Message ID 20161110152209.18379-2-marcandre.lureau@redhat.com
State New
Headers show

Commit Message

Marc-André Lureau Nov. 10, 2016, 3:21 p.m. UTC
'device_add' is still incomplete for now, but we can fix a few
arguments:
- 'bus' is a common argument, regardless of the device
- 'id' is an optionnal argument

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 qapi-schema.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Markus Armbruster Nov. 17, 2016, 5:30 p.m. UTC | #1
Marc-André Lureau <marcandre.lureau@redhat.com> writes:

> 'device_add' is still incomplete for now, but we can fix a few
> arguments:
> - 'bus' is a common argument, regardless of the device
> - 'id' is an optionnal argument
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>
Markus Armbruster Nov. 17, 2016, 5:36 p.m. UTC | #2
Markus Armbruster <armbru@redhat.com> writes:

> Marc-André Lureau <marcandre.lureau@redhat.com> writes:
>
>> 'device_add' is still incomplete for now, but we can fix a few
>> arguments:
>> - 'bus' is a common argument, regardless of the device
>> - 'id' is an optionnal argument
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>

Wrong thread, please ignore.
diff mbox

Patch

diff --git a/qapi-schema.json b/qapi-schema.json
index b0b4bf6..9201330 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -2287,7 +2287,7 @@ 
 #
 # @bus: #optional the device's parent bus (device tree path)
 #
-# @id: the device's ID, must be unique
+# @id: #optional the device's ID, must be unique
 #
 # Additional arguments depend on the type.
 #
@@ -2317,7 +2317,7 @@ 
 # Since: 0.13
 ##
 { 'command': 'device_add',
-  'data': {'driver': 'str', 'id': 'str'},
+  'data': {'driver': 'str', '*bus': 'str', '*id': 'str'},
   'gen': false } # so we can get the additional arguments
 
 ##