From patchwork Wed Nov 9 09:28:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 692649 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tDLVK1y8Zz9tkH for ; Wed, 9 Nov 2016 20:29:29 +1100 (AEDT) Received: from localhost ([::1]:38256 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4PC8-0003vq-54 for incoming@patchwork.ozlabs.org; Wed, 09 Nov 2016 04:29:24 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4PBR-0003dC-8w for qemu-devel@nongnu.org; Wed, 09 Nov 2016 04:28:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4PBO-0000aX-1b for qemu-devel@nongnu.org; Wed, 09 Nov 2016 04:28:41 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:32839) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c4PBN-0000Zt-Pn for qemu-devel@nongnu.org; Wed, 09 Nov 2016 04:28:37 -0500 X-IronPort-AV: E=Sophos;i="5.31,465,1473112800"; d="scan'208";a="244208234" Received: from unknown (HELO var.youpi.perso.aquilenet.fr) ([193.50.110.129]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES256-GCM-SHA384; 09 Nov 2016 10:28:35 +0100 Received: from samy by var.youpi.perso.aquilenet.fr with local (Exim 4.87) (envelope-from ) id 1c4PBL-00020U-Jm; Wed, 09 Nov 2016 10:28:35 +0100 Date: Wed, 9 Nov 2016 10:28:35 +0100 From: Samuel Thibault To: Cornelia Huck Message-ID: <20161109092835.GA2499@var.bordeaux.inria.fr> References: <20161107220741.GL2367@var.home> <20161108123449.0e031320.cornelia.huck@de.ibm.com> <20161108201019.GM2378@var.home> <20161109095859.0be2b487.cornelia.huck@de.ibm.com> <20161109090402.GF2378@var.home> <20161109101236.0c660095.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20161109101236.0c660095.cornelia.huck@de.ibm.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.134.164.83 Subject: Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Michal Suchanek , QEMU Developers Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Hello, Cornelia Huck, on Wed 09 Nov 2016 10:12:36 +0100, wrote: > On Wed, 9 Nov 2016 10:04:02 +0100 > Samuel Thibault wrote: > > Please post config.log so we can have a clue about what is going > > wrong. All these error messages are meant to be reported verbatim, not > > reinterpreted :) > > Well, no error here - just curses=no. The errors are in config.log, that's what one is supposed to look at when there are configure issues. > config.log attached. The difference seems to be that the statement you > added in the sample program causes a real error instead of a warning. Yes, that was on purpose, to avoid the -Werror issue. It's expected to happen because /usr/include/curses.h doesn't seem to have the wide support. But -I/usr/include/ncursesw/curses.h is supposed to have. But: > cc -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-all -I/usr/include/libpng16 -I/usr/include/ncursesw -o config-temp/qemu-conf.exe config-temp/qemu-conf.c -m64 -g :-lncursesw:-lcursesw > cc: error: :-lncursesw:-lcursesw: No such file or directory That's what the real issue is in your case. I now see why, could you try the attached patch instead? Samuel commit ea32127ca780b0945827776bf27f99383529621c Author: Samuel Thibault Date: Tue Nov 8 20:57:27 2016 +0100 Fix cursesw detection On systems which do not provide ncursesw.pc and whose /usr/include/curses.h does not include wide support, we should not only try with no -I, i.e. /usr/include, but also with -I/usr/include/ncursesw. To properly detect for wide support with and without -Werror, we need to check for the presence of e.g. the WACS_DEGREE macro. We also want to stop at the first curses_inc_list configuration which works, and make sure to set IFS to : at each new loop. Signed-off-by: Samuel Thibault diff --git a/configure b/configure index fd6f898..bac7bcc 100755 --- a/configure +++ b/configure @@ -2926,7 +2926,7 @@ if test "$curses" != "no" ; then curses_inc_list="$($pkg_config --cflags ncurses 2>/dev/null):" curses_lib_list="$($pkg_config --libs ncurses 2>/dev/null):-lpdcurses" else - curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):" + curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):-I/usr/include/ncursesw:" curses_lib_list="$($pkg_config --libs ncursesw 2>/dev/null):-lncursesw:-lcursesw" fi curses_found=no @@ -2941,6 +2941,7 @@ int main(void) { resize_term(0, 0); addwstr(L"wide chars\n"); addnwstr(&wch, 1); + add_wch(WACS_DEGREE); return s != 0; } EOF @@ -2954,7 +2955,11 @@ EOF libs_softmmu="$curses_lib $libs_softmmu" break fi + IFS=: done + if test "$curses_found" = yes ; then + break + fi done unset IFS if test "$curses_found" = "yes" ; then