| Message ID | 20161003094704.18087-2-marcandre.lureau@redhat.com |
|---|---|
| State | New |
| Headers | show |
diff --git a/qemu-char.c b/qemu-char.c index fb456ce..f7a07e6 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -468,7 +468,7 @@ void qemu_chr_add_handlers_full(CharDriverState *s, s->chr_read = fd_read; s->chr_event = fd_event; s->handler_opaque = opaque; - if (fe_open && s->chr_update_read_handler) { + if (s->chr_update_read_handler) { s->chr_update_read_handler(s, context); }
In commit ac1b84dd1 (rhbz#1027181), a check was added to only update the "read handler" when the front-end is opened, because the read callbacks were not restored when a device is plugged. However, this seems not correct, the handler is correctly set back on hotplug (in virtconsole_realize) and the bug can no longer be reproduced. Calling chr_update_read_handler() allows to fix the mux driver to stop calling the child handlers (which may be going to be destroyed). Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> --- qemu-char.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)