diff mbox

[21/37] tests: fix qom-test leaks

Message ID 20160719085432.4572-22-marcandre.lureau@redhat.com
State New
Headers show

Commit Message

Marc-André Lureau July 19, 2016, 8:54 a.m. UTC 
From: Marc-André Lureau <marcandre.lureau@redhat.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 tests/qom-test.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Eric Blake July 19, 2016, 11:50 p.m. UTC | #1 
On 07/19/2016 02:54 AM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  tests/qom-test.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/tests/qom-test.c b/tests/qom-test.c
> index 23493a2..d48f890 100644
> --- a/tests/qom-test.c
> +++ b/tests/qom-test.c
> @@ -115,7 +115,7 @@ static void add_machine_test_cases(void)
>      const QListEntry *p;
>      QObject *qobj;
>      QString *qstr;
> -    const char *mname, *path;
> +    const char *mname;
>  
>      qtest_start("-machine none");
>      response = qmp("{ 'execute': 'query-machines' }");
> @@ -132,8 +132,9 @@ static void add_machine_test_cases(void)
>          g_assert(qstr);
>          mname = qstring_get_str(qstr);
>          if (!is_blacklisted(arch, mname)) {
> -            path = g_strdup_printf("qom/%s", mname);
> +            char *path = g_strdup_printf("qom/%s", mname);
>              qtest_add_data_func(path, g_strdup(mname), test_machine);
> +            g_free(path);
>          }
>      }
>  
>
diff mbox

Patch

diff --git a/tests/qom-test.c b/tests/qom-test.c
index 23493a2..d48f890 100644
--- a/tests/qom-test.c
+++ b/tests/qom-test.c
@@ -115,7 +115,7 @@  static void add_machine_test_cases(void)
     const QListEntry *p;
     QObject *qobj;
     QString *qstr;
-    const char *mname, *path;
+    const char *mname;
 
     qtest_start("-machine none");
     response = qmp("{ 'execute': 'query-machines' }");
@@ -132,8 +132,9 @@  static void add_machine_test_cases(void)
         g_assert(qstr);
         mname = qstring_get_str(qstr);
         if (!is_blacklisted(arch, mname)) {
-            path = g_strdup_printf("qom/%s", mname);
+            char *path = g_strdup_printf("qom/%s", mname);
             qtest_add_data_func(path, g_strdup(mname), test_machine);
+            g_free(path);
         }
     }