mbox

[PULL,00/10] VFIO updates for 2015-10-05

Message ID 20151005203357.310.44414.stgit@gimli.home
State New
Headers show

Pull-request

git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20151005.0

Message

Alex Williamson Oct. 5, 2015, 8:36 p.m. UTC 
The following changes since commit c0b520dfb8890294a9f8879f4759172900585995:

  Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2015-10-02 16:59:21 +0100)

are available in the git repository at:


  git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20151005.0

for you to fetch changes up to 727299697dd31f0e1ccecc7eab1bf658e8ed3079:

  vfio: Expose a VFIO PCI device's group for EEH (2015-10-05 12:40:13 -0600)

----------------------------------------------------------------
VFIO updates 2015-10-05

 - Change platform device IRQ setup sequence for compatibility
   with upcoming IRQ forwarding (Eric Auger)
 - Extensions to support vfio-pci devices on spapr-pci-host-bridge
   (David Gibson)

----------------------------------------------------------------
David Gibson (7):
      vfio: Remove unneeded union from VFIOContainer
      vfio: Generalize vfio_listener_region_add failure path
      vfio: Check guest IOVA ranges against host IOMMU capabilities
      vfio: Record host IOMMU's available IO page sizes
      memory: Allow replay of IOMMU mapping notifications
      vfio: Allow hotplug of containers onto existing guest IOMMU mappings
      vfio: Expose a VFIO PCI device's group for EEH

Eric Auger (3):
      hw/vfio/platform: irqfd setup sequence update
      hw/vfio/platform: change interrupt/unmask fields into pointer
      hw/vfio/platform: do not set resamplefd for edge-sensitive IRQS

 hw/vfio/common.c                | 140 ++++++++++++++++++++++++----------------
 hw/vfio/pci.c                   |  14 ++++
 hw/vfio/platform.c              | 116 ++++++++++++++++++++-------------
 include/exec/memory.h           |  13 ++++
 include/hw/vfio/vfio-common.h   |  23 +++----
 include/hw/vfio/vfio-pci.h      |  11 ++++
 include/hw/vfio/vfio-platform.h |   4 +-
 memory.c                        |  20 ++++++
 trace-events                    |   4 +-
 9 files changed, 229 insertions(+), 116 deletions(-)
 create mode 100644 include/hw/vfio/vfio-pci.h

Comments

Peter Maydell Oct. 6, 2015, 2:50 p.m. UTC | #1 
On 5 October 2015 at 21:36, Alex Williamson <alex.williamson@redhat.com> wrote:
> The following changes since commit c0b520dfb8890294a9f8879f4759172900585995:
>
>   Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2015-10-02 16:59:21 +0100)
>
> are available in the git repository at:
>
>
>   git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20151005.0
>
> for you to fetch changes up to 727299697dd31f0e1ccecc7eab1bf658e8ed3079:
>
>   vfio: Expose a VFIO PCI device's group for EEH (2015-10-05 12:40:13 -0600)
>
> ----------------------------------------------------------------
> VFIO updates 2015-10-05
>
>  - Change platform device IRQ setup sequence for compatibility
>    with upcoming IRQ forwarding (Eric Auger)
>  - Extensions to support vfio-pci devices on spapr-pci-host-bridge
>    (David Gibson)
>
> ----------------------------------------------------------------

Hi. I'm afraid this fails to build with clang:

In file included from /home/petmay01/linaro/qemu-for-merges/hw/vfio/pci.c:38:
/home/petmay01/linaro/qemu-for-merges/include/hw/vfio/vfio-pci.h:7:26:
error: redefinition of typedef 'VFIOGroup' is a C11 feature
[-Werror,-Wtypedef-redefinition]
typedef struct VFIOGroup VFIOGroup;
                         ^
/home/petmay01/linaro/qemu-for-merges/include/hw/vfio/vfio-common.h:117:3:
note: previous definition is here
} VFIOGroup;
  ^
1 error generated.

thanks
-- PMM
Alex Williamson Oct. 6, 2015, 3:35 p.m. UTC | #2 
On Tue, 2015-10-06 at 15:50 +0100, Peter Maydell wrote:
> On 5 October 2015 at 21:36, Alex Williamson <alex.williamson@redhat.com> wrote:
> > The following changes since commit c0b520dfb8890294a9f8879f4759172900585995:
> >
> >   Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2015-10-02 16:59:21 +0100)
> >
> > are available in the git repository at:
> >
> >
> >   git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20151005.0
> >
> > for you to fetch changes up to 727299697dd31f0e1ccecc7eab1bf658e8ed3079:
> >
> >   vfio: Expose a VFIO PCI device's group for EEH (2015-10-05 12:40:13 -0600)
> >
> > ----------------------------------------------------------------
> > VFIO updates 2015-10-05
> >
> >  - Change platform device IRQ setup sequence for compatibility
> >    with upcoming IRQ forwarding (Eric Auger)
> >  - Extensions to support vfio-pci devices on spapr-pci-host-bridge
> >    (David Gibson)
> >
> > ----------------------------------------------------------------
> 
> Hi. I'm afraid this fails to build with clang:
> 
> In file included from /home/petmay01/linaro/qemu-for-merges/hw/vfio/pci.c:38:
> /home/petmay01/linaro/qemu-for-merges/include/hw/vfio/vfio-pci.h:7:26:
> error: redefinition of typedef 'VFIOGroup' is a C11 feature
> [-Werror,-Wtypedef-redefinition]
> typedef struct VFIOGroup VFIOGroup;
>                          ^
> /home/petmay01/linaro/qemu-for-merges/include/hw/vfio/vfio-common.h:117:3:
> note: previous definition is here
> } VFIOGroup;
>   ^
> 1 error generated.

Thanks Peter.  David, can you send a replacement for that last patch?
Thanks,

Alex
David Gibson Oct. 6, 2015, 11:31 p.m. UTC | #3 
On Tue, Oct 06, 2015 at 09:35:17AM -0600, Alex Williamson wrote:
> On Tue, 2015-10-06 at 15:50 +0100, Peter Maydell wrote:
> > On 5 October 2015 at 21:36, Alex Williamson <alex.williamson@redhat.com> wrote:
> > > The following changes since commit c0b520dfb8890294a9f8879f4759172900585995:
> > >
> > >   Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2015-10-02 16:59:21 +0100)
> > >
> > > are available in the git repository at:
> > >
> > >
> > >   git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20151005.0
> > >
> > > for you to fetch changes up to 727299697dd31f0e1ccecc7eab1bf658e8ed3079:
> > >
> > >   vfio: Expose a VFIO PCI device's group for EEH (2015-10-05 12:40:13 -0600)
> > >
> > > ----------------------------------------------------------------
> > > VFIO updates 2015-10-05
> > >
> > >  - Change platform device IRQ setup sequence for compatibility
> > >    with upcoming IRQ forwarding (Eric Auger)
> > >  - Extensions to support vfio-pci devices on spapr-pci-host-bridge
> > >    (David Gibson)
> > >
> > > ----------------------------------------------------------------
> > 
> > Hi. I'm afraid this fails to build with clang:
> > 
> > In file included from /home/petmay01/linaro/qemu-for-merges/hw/vfio/pci.c:38:
> > /home/petmay01/linaro/qemu-for-merges/include/hw/vfio/vfio-pci.h:7:26:
> > error: redefinition of typedef 'VFIOGroup' is a C11 feature
> > [-Werror,-Wtypedef-redefinition]
> > typedef struct VFIOGroup VFIOGroup;
> >                          ^
> > /home/petmay01/linaro/qemu-for-merges/include/hw/vfio/vfio-common.h:117:3:
> > note: previous definition is here
> > } VFIOGroup;
> >   ^
> > 1 error generated.
> 
> Thanks Peter.  David, can you send a replacement for that last patch?
> Thanks,

Actually, can you just drop the last patch for now.

The use case I thought I had for it turns out not to be.