| Message ID | 20150922152313.GK3999@noname.str.redhat.com |
|---|---|
| State | New |
| Headers | show |
On 09/22/2015 09:23 AM, Kevin Wolf wrote: > Am 18.09.2015 um 15:22 hat Markus Armbruster geschrieben: >> From: Eric Blake <eblake@redhat.com> >> >> Commits 7216ae3d and d2828429 disabled some error message hints, >> all because a change to use modern error reporting meant that the >> hint would be output prior to the actual error. Fix this by making >> hints a first-class member of Error. >> >> For example, we are now back to the pleasant: >> >> $ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=, >> qemu-system-x86_64: --chardev null,id=,: Parameter 'id' expects an identifier >> Identifiers consist of letters, digits, '-', '.', '_', starting with a letter. >> >> Signed-off-by: Eric Blake <eblake@redhat.com> >> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> >> Message-Id: <1441901956-21991-1-git-send-email-eblake@redhat.com> >> Signed-off-by: Markus Armbruster <armbru@redhat.com> > > This broke qemu-iotests 049. Can you please send a patch to update the > reference output? Will do (and I guess I should run qemu-iotests more frequently. Does 'make check' suffice, or is there other magic involved?)
On 09/22/2015 01:02 PM, Eric Blake wrote: > On 09/22/2015 09:23 AM, Kevin Wolf wrote: >> Am 18.09.2015 um 15:22 hat Markus Armbruster geschrieben: >>> From: Eric Blake <eblake@redhat.com> >>> >>> Commits 7216ae3d and d2828429 disabled some error message hints, >>> all because a change to use modern error reporting meant that the >>> hint would be output prior to the actual error. Fix this by making >>> hints a first-class member of Error. >>> >>> For example, we are now back to the pleasant: >>> >>> $ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=, >>> qemu-system-x86_64: --chardev null,id=,: Parameter 'id' expects an identifier >>> Identifiers consist of letters, digits, '-', '.', '_', starting with a letter. >>> >>> Signed-off-by: Eric Blake <eblake@redhat.com> >>> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> >>> Message-Id: <1441901956-21991-1-git-send-email-eblake@redhat.com> >>> Signed-off-by: Markus Armbruster <armbru@redhat.com> >> >> This broke qemu-iotests 049. Can you please send a patch to update the >> reference output? > > Will do (and I guess I should run qemu-iotests more frequently. Does > 'make check' suffice, or is there other magic involved?) > From the build directory: pushd tests/qemu-iotests; ./check -v -qcow2; ./check -v -raw; popd If there is a smarter way of doing it, it is unknown to me. --js
--- /home/kwolf/source/qemu/tests/qemu-iotests/049.out 2015-09-14 13:44:45.347890767 +0200 +++ 049.out.bad 2015-09-22 17:20:50.131625409 +0200 @@ -118,6 +118,7 @@ qemu-img create -f qcow2 -o size=foobar TEST_DIR/t.qcow2 qemu-img: Parameter 'size' expects a size +You may use k, M, G or T suffixes for kilobytes, megabytes, gigabytes and terabytes. qemu-img: TEST_DIR/t.qcow2: Invalid options for file format 'qcow2' == Check correct interpretation of suffixes for cluster size ==