From patchwork Thu May 21 11:53:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= X-Patchwork-Id: 474975 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 34F6B140077 for ; Thu, 21 May 2015 21:54:24 +1000 (AEST) Received: from localhost ([::1]:56786 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvP3J-00026y-Ez for incoming@patchwork.ozlabs.org; Thu, 21 May 2015 07:54:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvP2x-0001pH-Ro for qemu-devel@nongnu.org; Thu, 21 May 2015 07:53:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvP2u-000641-IZ for qemu-devel@nongnu.org; Thu, 21 May 2015 07:53:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvP2u-00063x-AW for qemu-devel@nongnu.org; Thu, 21 May 2015 07:53:52 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 9F96C29331D; Thu, 21 May 2015 11:53:51 +0000 (UTC) Received: from redhat.com (vpn1-6-230.ams2.redhat.com [10.36.6.230]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4LBrlIE031364 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 21 May 2015 07:53:49 -0400 Date: Thu, 21 May 2015 12:53:46 +0100 From: "Daniel P. Berrange" To: Peter Maydell Message-ID: <20150521115346.GJ23116@redhat.com> References: <1432137106-8295-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Paolo Bonzini , Andreas =?utf-8?Q?F=C3=A4rber?= , Eduardo Habkost , QEMU Developers Subject: Re: [Qemu-devel] [PULL 00/12] QOM devices patch queue 2015-05-20 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Thu, May 21, 2015 at 12:18:30PM +0100, Peter Maydell wrote: > On 20 May 2015 at 16:51, Andreas Färber wrote: > > Hello Peter, > > > > This is my QOM (devices) patch queue. Please pull. > > > > Regards, > > Andreas > > > > Cc: Peter Maydell > > Cc: Eduardo Habkost > > Cc: Paolo Bonzini > > Cc: Daniel P. Berrange > > > > The following changes since commit faa261a7fb254866bdd5b6a25ad94677945f21b4: > > > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-cocoa-20150519' into staging (2015-05-19 10:25:59 +0100) > > > > are available in the git repository at: > > > > git://github.com/afaerber/qemu-cpu.git tags/qom-devices-for-peter > > > > for you to fetch changes up to 28b86c32afbc53f9f06a5655da65f9d06fac1a3e: > > > > qom: Add object_property_add_const_link() (2015-05-20 17:40:47 +0200) > > Fails to build on my 32-bit ARM box, I'm afraid: > > tests/check-qom-proplist.c: In function 'test_dummy_badenum': > tests/check-qom-proplist.c:225:6: error: value computed is not used > [-Werror=unused-value] > > My guess is this is a gcc-version-dependent thing rather > than particularly 32-bit or ARM related. It's using > gcc (Ubuntu/Linaro 4.7.2-2ubuntu1) 4.7.2 Agreed, looks gcc version related not ARM/32-bit. I'm thinking the following change applied to the patch "qom: add a object_property_add_enum helper method" will probably fix it Regards, Daniel diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c index 8b764a1..7400b1f 100644 --- a/tests/check-qom-proplist.c +++ b/tests/check-qom-proplist.c @@ -222,7 +222,7 @@ static void test_dummy_badenum(void) { Error *err = NULL; Object *parent = object_get_objects_root(); - DUMMY_OBJECT( + Object *dobj = object_new_with_props(TYPE_DUMMY, parent, "dummy0", @@ -230,8 +230,9 @@ static void test_dummy_badenum(void) "bv", "yes", "sv", "Hiss hiss hiss", "av", "yeti", - NULL)); + NULL); + g_assert(dobj == NULL); g_assert(err != NULL); g_assert_cmpstr(error_get_pretty(err), ==, "Invalid parameter 'yeti'");