From patchwork Mon Jul 21 14:51:19 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 372109 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id EFD3B1400D5 for ; Tue, 22 Jul 2014 00:51:53 +1000 (EST) Received: from localhost ([::1]:34575 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9EwS-0001NB-08 for incoming@patchwork.ozlabs.org; Mon, 21 Jul 2014 10:51:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9Ew2-00014g-Gh for qemu-devel@nongnu.org; Mon, 21 Jul 2014 10:51:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X9Evw-0004JL-Rn for qemu-devel@nongnu.org; Mon, 21 Jul 2014 10:51:26 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:2285) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9Evw-0004Ix-Id for qemu-devel@nongnu.org; Mon, 21 Jul 2014 10:51:20 -0400 X-IronPort-AV: E=Sophos;i="5.01,701,1400018400"; d="scan'208";a="86315291" Received: from unknown (HELO type.ipv6) ([193.50.110.149]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES128-SHA; 21 Jul 2014 16:51:19 +0200 Received: from samy by type.ipv6 with local (Exim 4.82_1-5b7a7c0-XX) (envelope-from ) id 1X9Evv-0005u2-6x; Mon, 21 Jul 2014 16:51:19 +0200 Date: Mon, 21 Jul 2014 16:51:19 +0200 From: Samuel Thibault To: Vasiliy Tolstov Message-ID: <20140721145119.GB5390@type.bordeaux.inria.fr> References: <20140721114146.GT5390@type.bordeaux.inria.fr> <20140721114911.GU5390@type.bordeaux.inria.fr> <20140721120643.GV5390@type.bordeaux.inria.fr> <20140721142934.GZ5390@type.bordeaux.inria.fr> <20140721144709.GA5390@type.bordeaux.inria.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140721144709.GA5390@type.bordeaux.inria.fr> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.134.164.83 Cc: libvir-list@redhat.com, QEMU Subject: Re: [Qemu-devel] ipv6 slirp network X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Samuel Thibault, le Mon 21 Jul 2014 16:47:09 +0200, a écrit : > Samuel Thibault, le Mon 21 Jul 2014 16:29:34 +0200, a écrit : > > Vasiliy Tolstov, le Mon 21 Jul 2014 18:19:17 +0400, a écrit : > > > 2014-07-21 16:06 GMT+04:00 Samuel Thibault : > > > > I have pushed it to http://dept-info.labri.fr/~thibault/qemu-ipv6 , in > > > > the tosubmit branch. > > > > > > > > > Inside packer (i'm try to build some centos 7 boxes) i have errors > > > Qemu stderr: qemu-system-x86_64: slirp/tcp_input.c:1543: tcp_mss: > > > Assertion `0' failed. > > > > Uh?! Does the switch statement properly have both AF_INET and AF_INET6 > > cases? > > > > A gdb backtrace would also be useful. > > Mmm, I guess this is coming through tcp_connect(). Could you try the > attached patch? Sorry, I should have tested the build before sending, here it is. Samuel diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c index a1f060b..7fa6173 100644 --- a/slirp/tcp_subr.c +++ b/slirp/tcp_subr.c @@ -439,6 +439,7 @@ void tcp_connect(struct socket *inso) return; } so->lhost = inso->lhost; + so->so_ffamily = inso->so_ffamily; } tcp_mss(sototcpcb(so), 0);