diff mbox

slirp: goto bad in udp_input if sosendto fails

Message ID 20140711101824.GM4837@type
State New
Headers show

Commit Message

Samuel Thibault July 11, 2014, 10:18 a.m. UTC
Before this patch, if sosendto fails, udp_input is executed as if the
packet was sent, recording the packet for icmp errors, which does not
makes sense since the packet was not actually sent, errors would be
related to a previous packet.

This patch adds a goto bad to cut the execution of this function.

Signed-off-by: Guillaume Subiron <maethor@subiron.org>
 slirp/udp.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox


diff --git a/slirp/udp.c b/slirp/udp.c
index 8cc6cb6..fd2446a 100644
--- a/slirp/udp.c
+++ b/slirp/udp.c
@@ -218,6 +218,7 @@  udp_input(register struct mbuf *m, int iphlen)
 	  DEBUG_MISC((dfd,"udp tx errno = %d-%s\n",errno,strerror(errno)));
 	  icmp_error(m, ICMP_UNREACH,ICMP_UNREACH_NET, 0,strerror(errno));
+	  goto bad;
 	m_free(so->so_m);   /* used for ICMP if error on sorecvfrom */