From patchwork Tue Dec 4 15:39:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gabriel L. Somlo" X-Patchwork-Id: 203683 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 1284D2C0084 for ; Wed, 5 Dec 2012 02:40:35 +1100 (EST) Received: from localhost ([::1]:58102 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tfubp-00088I-80 for incoming@patchwork.ozlabs.org; Tue, 04 Dec 2012 10:40:33 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfubZ-00087Z-9S for qemu-devel@nongnu.org; Tue, 04 Dec 2012 10:40:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TfubP-0002wL-2B for qemu-devel@nongnu.org; Tue, 04 Dec 2012 10:40:16 -0500 Received: from mail-qa0-f45.google.com ([209.85.216.45]:55245) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfubN-0002oJ-RM for qemu-devel@nongnu.org; Tue, 04 Dec 2012 10:40:06 -0500 Received: by mail-qa0-f45.google.com with SMTP id j15so948500qaq.4 for ; Tue, 04 Dec 2012 07:40:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=AkjwgGr61dzj6Cd0ucSwhluxr8/wMlWfyxWWsqTvA9s=; b=PTWk3BewDzhX6oe+6lzrQGmFecYeRI9ypl2+auKzCPM03fg5qw2lN0NuUOIPyH6Wzq xQL3to9MnlqKZ1QVurVo3MhmtVcIHsP+3O73aKeWjJKexEBAUXaRprFsIw2UuUBqHR1T 7AnYqtyS8DxgTZA6XYhWCoaeVUIWRKIG4I+blvWtu90mS2l3+CtcaZsiUbR3+9GOrlSG 0ggtgYhJL3CQM/FyUwj4M2f7dHhhwG8RJtl+cG5zGOpR867HuGBa9eJc/cA5iu1YU3l2 smgMkjYZScv07zxdUfSdQyvBW6OnZFyebBljZQq45QScaI7O+IND1Kv3FWyBGNDSiNM4 nS4A== Received: by 10.49.106.70 with SMTP id gs6mr25555788qeb.36.1354635601808; Tue, 04 Dec 2012 07:40:01 -0800 (PST) Received: from hedwig.ini.cmu.edu (HEDWIG.INI.CMU.EDU. [128.2.16.5]) by mx.google.com with ESMTPS id pb2sm805830qeb.0.2012.12.04.07.40.00 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 04 Dec 2012 07:40:01 -0800 (PST) Date: Tue, 4 Dec 2012 10:39:58 -0500 From: "Gabriel L. Somlo" To: jbaron@redhat.com Message-ID: <20121204153957.GC13356@hedwig.ini.cmu.edu> References: <50BDA8EB.5090402@redhat.com> <20121204144243.GB13356@hedwig.ini.cmu.edu> <20121204151136.GA11468@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20121204151136.GA11468@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.216.45 Cc: rene@exactcode.com, jan.kiszka@siemens.com, agraf@suse.de, qemu-devel@nongnu.org, kraxel@redhat.com, anthony@codemonkey.ws Subject: Re: [Qemu-devel] [PULL for-1.3 0/3] seabios: q35 update X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Tue, Dec 04, 2012 at 10:11:38AM -0500, jbaron@redhat.com wrote: > > I don't have an XP install image anymore, but does replacing 2,8 with > > 0,8 help ? > > > > no. > > > On a few of my machines, this is actually coded as > > > > IRQNoFlags () > > {0} /* or 2 */ > > IRQNoFlags () > > {8} > > > > Based on my reading of the ACPI manual, this should be syntactically > > equivalent to the the comma-separated single-line format we're currently > > using, but could it be that WinXP is picky about the specifics ? > > > > Didn't seem to help either. I also tried having just a single irq from > 0,2,8, and that didn't work either. The only thing that seems to make XP > happy is completely removing that line. So I'm not sure what is wrong. I got one more thing to try: The complete definition for the HPET on my MacPro5,1 is below; along with the 0xFED00000 value gleaned from the previous SeaBIOS version of _CRS, I came up with the above. Hopefully it works for WinXP too... Thanks, --Gabriel Device (HPET) { Name (_HID, EisaId ("PNP0103")) Name (BUF0, ResourceTemplate () { IRQNoFlags () {0} IRQNoFlags () {8} Memory32Fixed (ReadOnly, 0xFED00000, // Address Base 0x00100000, // Address Length _Y09) }) Method (_STA, 0, NotSerialized) { If (LGreaterEqual (OSYS, 0x07D1)) { If (HPAE) { Return (0x0F) } } Else { If (HPAE) { Return (0x0B) } } Return (0x00) } Method (_CRS, 0, Serialized) { If (HPAE) { CreateDWordField (BUF0, \_SB.PCI0.LPCB.HPET._Y09._BAS, HPT0) If (LEqual (HPAS, 0x01)) { Store (0xFED10000, HPT0) } If (LEqual (HPAS, 0x02)) { Store (0xFED20000, HPT0) } If (LEqual (HPAS, 0x03)) { Store (0xFED30000, HPT0) } } Return (BUF0) } } diff --git a/src/acpi-dsdt-hpet.dsl b/src/acpi-dsdt-hpet.dsl index d5aa3f1..8385ce4 100644 --- a/src/acpi-dsdt-hpet.dsl +++ b/src/acpi-dsdt-hpet.dsl @@ -23,12 +23,17 @@ Scope(\_SB) { } Return (0x0F) } - Name(_CRS, ResourceTemplate() { + Name(BUF0, ResourceTemplate() { IRQNoFlags() {2, 8} Memory32Fixed(ReadOnly, 0xFED00000, // Address Base 0x00000400, // Address Length - ) + _Y09) }) + Method(_CRS, 0, Serialized) { + CreateDWordField (BUF0, \_SB.HPET._Y09._BAS, HPT0) + Store(0xFED00000, HPT0) + Return (BUF0) + } } }