From patchwork Wed Oct 24 09:58:51 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oliver Francke X-Patchwork-Id: 193722 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id AC0A32C0156 for ; Wed, 24 Oct 2012 21:06:01 +1100 (EST) Received: from localhost ([::1]:41549 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQxqZ-0007Aj-Mu for incoming@patchwork.ozlabs.org; Wed, 24 Oct 2012 06:05:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQxqL-0007AR-Dc for qemu-devel@nongnu.org; Wed, 24 Oct 2012 06:05:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQxqD-0002Mf-GC for qemu-devel@nongnu.org; Wed, 24 Oct 2012 06:05:45 -0400 Received: from indium.canonical.com ([91.189.90.7]:48233) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQxqD-0002MZ-AQ for qemu-devel@nongnu.org; Wed, 24 Oct 2012 06:05:37 -0400 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.71 #1 (Debian)) id 1TQxqC-0000YP-PR for ; Wed, 24 Oct 2012 10:05:36 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id B6B342E8070 for ; Wed, 24 Oct 2012 10:05:36 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 24 Oct 2012 09:58:51 -0000 From: Oliver Francke To: qemu-devel@nongnu.org X-Launchpad-Bug: product=qemu; status=New; importance=Undecided; assignee=None; X-Launchpad-Bug-Information-Type: Public X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: oliver-francke X-Launchpad-Bug-Reporter: Oliver Francke (oliver-francke) X-Launchpad-Bug-Modifier: Oliver Francke (oliver-francke) References: <20121024095851.10767.86404.malonedeb@gac.canonical.com> Message-Id: <20121024095851.10767.86404.malonedeb@gac.canonical.com> X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="16179"; Instance="launchpad-lazr.conf" X-Launchpad-Hash: 3167dab099483973f706013a88c938c6753c8038 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 91.189.90.7 Subject: [Qemu-devel] [Bug 1070762] [NEW] savevm fails with inserted CD, "Device '%s' is writable but does not support snapshots." X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Reply-To: Bug 1070762 <1070762@bugs.launchpad.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Public bug reported: Hi, yesterday unfortunately a customer reported a failed snapshot of his VM. Going through the logfile I discovered: "Device 'ide1-cd0' is writable but does not support snapshots" this is with qemu-1.2.0 and 1.0.1 at least... Why writeable? Even if I specify "-drive ...,readonly=on,snapshot=off" to qemu the monitor-command sees the CD-ROM-device as being writeable?! Somewhere I saw a "hint" for blockdev.c: === snap === after installing with this small patch applied it works, so insert CD, savevm succeeds. This should be fixed at all correct places, and the tags "readonly=on,snapshot=off" should do it, too. Or even just work after specifying a drive being a CD-rom should do the trick ;-) Another "bad habit" is, that the ISO/DVD-file has to be writeable to be changed? Thnx for attention and regards, Oliver. ** Affects: qemu Importance: Undecided Status: New === snip === --- /tmp/blockdev.c 2012-10-24 11:37:10.000000000 +0200 +++ blockdev.c 2012-10-24 11:37:17.000000000 +0200 @@ -551,6 +551,7 @@ case IF_XEN: case IF_NONE: dinfo->media_cd = media == MEDIA_CDROM; + dinfo->bdrv->read_only = 1; break; case IF_SD: case IF_FLOPPY: