From patchwork Tue Aug 28 16:01:16 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Michael S. Tsirkin" X-Patchwork-Id: 180516 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id CB6382C010F for ; Wed, 29 Aug 2012 02:21:05 +1000 (EST) Received: from localhost ([::1]:55586 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6ODu-0006nc-2B for incoming@patchwork.ozlabs.org; Tue, 28 Aug 2012 12:01:02 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6ODf-0006Tb-KR for qemu-devel@nongnu.org; Tue, 28 Aug 2012 12:00:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T6ODY-0005NN-Su for qemu-devel@nongnu.org; Tue, 28 Aug 2012 12:00:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54067) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6ODY-0005N8-KR for qemu-devel@nongnu.org; Tue, 28 Aug 2012 12:00:40 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7SFxs7E022370 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 28 Aug 2012 12:00:03 -0400 Received: from redhat.com (unused-13-89.tlv.redhat.com [10.35.13.89] (may be forged)) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with SMTP id q7SFxuIt013472; Tue, 28 Aug 2012 11:59:56 -0400 Date: Tue, 28 Aug 2012 19:01:16 +0300 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Message-ID: <20120828160116.GA3047@redhat.com> MIME-Version: 1.0 Content-Disposition: inline X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: Blue Swirl , Peter Maydell , Anthony Liguori , Stefan Hajnoczi , "Michael S. Tsirkin" Subject: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org We copied HACKING from libvirt but it has some bogus stuff: neither underscore capital, double underscore, or underscore 't' suffixes are reserved in Posix/C: this appears to be based on misreading of the C standard. Using sane prefixes is enough to avoid conflicts. These rules are also widely violated in our codebase, and it does not make sense to rework it all, apparently for no benefit. Signed-off-by: Michael S. Tsirkin --- HACKING | 4 ---- 1 file changed, 4 deletions(-) diff --git a/HACKING b/HACKING index 471cf1d..0a941fc 100644 --- a/HACKING +++ b/HACKING @@ -69,10 +69,6 @@ it points to, or it is aliased to another pointer that is. 2.3. Typedefs Typedefs are used to eliminate the redundant 'struct' keyword. -2.4. Reserved namespaces in C and POSIX -Underscore capital, double underscore, and underscore 't' suffixes should be -avoided. - 3. Low level memory management Use of the malloc/free/realloc/calloc/valloc/memalign/posix_memalign