| Message ID | 20111129005348.GB7938@rox.home.comstyle.com |
|---|---|
| State | New |
| Headers | show |
On 11/28/2011 06:53 PM, Brad wrote: > Enable build by default PIE / read-only relocation sections for the QEMU > binaries on OpenBSD amd64/i386. > > Signed-off-by: Brad Smith<brad@comstyle.com> Can you mention what targets you tested and what toolchain you used on OpenBSD? Regards, Anthony Liguori > > --- > configure | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/configure b/configure > index ac4840d..b113f60 100755 > --- a/configure > +++ b/configure > @@ -1116,7 +1116,7 @@ fi > > if test "$pie" = ""; then > case "$cpu-$targetos" in > - i386-Linux|x86_64-Linux) > + i386-Linux|x86_64-Linux|i386-OpenBSD|x86_64-OpenBSD) > ;; > *) > pie="no"
On 28/11/11 9:28 PM, Anthony Liguori wrote: > On 11/28/2011 06:53 PM, Brad wrote: >> Enable build by default PIE / read-only relocation sections for the QEMU >> binaries on OpenBSD amd64/i386. >> >> Signed-off-by: Brad Smith<brad@comstyle.com> > > Can you mention what targets you tested and what toolchain you used on > OpenBSD? Using a combination of the Linux test images on the QEMU Wiki and OS's I have (OpenBSD (amd64/i386/macppc/sparc/sparc64) / Windows (XP/7)) I tested arm/cris/i386/m68k/microblaze/mips/mipsel/ppc/sparc/sparc64/sh4/xtensa. The standard system toolchain which is a customized copy of binutils 2.15 and which OpenBSD has had PIE support for 3 years / 5 releases now.
On 28/11/11 11:15 PM, Brad wrote: > On 28/11/11 9:28 PM, Anthony Liguori wrote: >> On 11/28/2011 06:53 PM, Brad wrote: >>> Enable build by default PIE / read-only relocation sections for the QEMU >>> binaries on OpenBSD amd64/i386. >>> >>> Signed-off-by: Brad Smith<brad@comstyle.com> >> >> Can you mention what targets you tested and what toolchain you used on >> OpenBSD? > > Using a combination of the Linux test images on the QEMU Wiki and OS's I > have > (OpenBSD (amd64/i386/macppc/sparc/sparc64) / Windows (XP/7)) I tested > arm/cris/i386/m68k/microblaze/mips/mipsel/ppc/sparc/sparc64/sh4/xtensa. The > standard system toolchain which is a customized copy of binutils 2.15 and > which OpenBSD has had PIE support for 3 years / 5 releases now. No further comment? Can this please be commited?
Thanks, applied. On Tue, Nov 29, 2011 at 00:53, Brad <brad@comstyle.com> wrote: > Enable build by default PIE / read-only relocation sections for the QEMU > binaries on OpenBSD amd64/i386. > > Signed-off-by: Brad Smith <brad@comstyle.com> > > --- > configure | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/configure b/configure > index ac4840d..b113f60 100755 > --- a/configure > +++ b/configure > @@ -1116,7 +1116,7 @@ fi > > if test "$pie" = ""; then > case "$cpu-$targetos" in > - i386-Linux|x86_64-Linux) > + i386-Linux|x86_64-Linux|i386-OpenBSD|x86_64-OpenBSD) > ;; > *) > pie="no" > -- > 1.7.6 > > > -- > This message has been scanned for viruses and > dangerous content by MailScanner, and is > believed to be clean. > >
diff --git a/configure b/configure index ac4840d..b113f60 100755 --- a/configure +++ b/configure @@ -1116,7 +1116,7 @@ fi if test "$pie" = ""; then case "$cpu-$targetos" in - i386-Linux|x86_64-Linux) + i386-Linux|x86_64-Linux|i386-OpenBSD|x86_64-OpenBSD) ;; *) pie="no"
Enable build by default PIE / read-only relocation sections for the QEMU binaries on OpenBSD amd64/i386. Signed-off-by: Brad Smith <brad@comstyle.com> --- configure | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)