From patchwork Fri Jul 9 18:18:51 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Tosatti X-Patchwork-Id: 58421 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 39B54B6F04 for ; Sat, 10 Jul 2010 04:26:00 +1000 (EST) Received: from localhost ([127.0.0.1]:59338 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OXIGr-00058M-7Z for incoming@patchwork.ozlabs.org; Fri, 09 Jul 2010 14:25:57 -0400 Received: from [140.186.70.92] (port=42218 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OXIG9-00057d-OZ for qemu-devel@nongnu.org; Fri, 09 Jul 2010 14:25:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OXIG7-0008Nm-Rn for qemu-devel@nongnu.org; Fri, 09 Jul 2010 14:25:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1285) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OXIG7-0008N8-IG for qemu-devel@nongnu.org; Fri, 09 Jul 2010 14:25:11 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o69IP7Kj002423 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 9 Jul 2010 14:25:07 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o69IP6Cq025603; Fri, 9 Jul 2010 14:25:07 -0400 Received: from amt.cnet (vpn-8-199.rdu.redhat.com [10.11.8.199]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o69IP5B0012083; Fri, 9 Jul 2010 14:25:06 -0400 Received: from amt.cnet (amt.cnet [127.0.0.1]) by amt.cnet (Postfix) with ESMTP id 17A2E65600F; Fri, 9 Jul 2010 15:18:54 -0300 (BRT) Received: (from marcelo@localhost) by amt.cnet (8.14.3/8.14.3/Submit) id o69IIp4M007700; Fri, 9 Jul 2010 15:18:51 -0300 Date: Fri, 9 Jul 2010 15:18:51 -0300 From: Marcelo Tosatti To: Anthony Liguori , Juan Quintela , Luiz Capitulino Message-ID: <20100709181851.GB7444@amt.cnet> References: <20100707180411.GA17569@amt.cnet> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20100707180411.GA17569@amt.cnet> User-Agent: Mutt/1.5.20 (2009-08-17) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.18 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH] set proper migration status on ->write error (v3) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org If ->write fails, declare migration status as MIG_STATE_ERROR. Also, in buffered_file.c, ->close the object in case of an error. Fixes "migrate -d "exec:dd of=file", where dd fails to open file. Signed-off-by: Marcelo Tosatti diff --git a/buffered_file.c b/buffered_file.c index 54dc6c2..be147d6 100644 --- a/buffered_file.c +++ b/buffered_file.c @@ -222,8 +222,10 @@ static void buffered_rate_tick(void *opaque) { QEMUFileBuffered *s = opaque; - if (s->has_error) + if (s->has_error) { + buffered_close(s); return; + } qemu_mod_timer(s->timer, qemu_get_clock(rt_clock) + 100); diff --git a/migration.c b/migration.c index b49964c..862dc4f 100644 --- a/migration.c +++ b/migration.c @@ -316,8 +316,12 @@ ssize_t migrate_fd_put_buffer(void *opaque, const void *data, size_t size) if (ret == -1) ret = -(s->get_error(s)); - if (ret == -EAGAIN) + if (ret == -EAGAIN) { qemu_set_fd_handler2(s->fd, NULL, NULL, migrate_fd_put_notify, s); + } else if (ret < 0) { + monitor_resume(s); + s->state = MIG_STATE_ERROR; + } return ret; }