From patchwork Thu May 27 05:35:58 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Isaku Yamahata X-Patchwork-Id: 53688 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 394A6B7D27 for ; Thu, 27 May 2010 16:10:33 +1000 (EST) Received: from localhost ([127.0.0.1]:39368 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OHWIY-00049L-D0 for incoming@patchwork.ozlabs.org; Thu, 27 May 2010 02:10:30 -0400 Received: from [140.186.70.92] (port=38408 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OHW3j-0003LI-Mc for qemu-devel@nongnu.org; Thu, 27 May 2010 01:55:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OHVoU-0003VW-1P for qemu-devel@nongnu.org; Thu, 27 May 2010 01:39:28 -0400 Received: from mail.valinux.co.jp ([210.128.90.3]:36959) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHVoT-0003V8-OT for qemu-devel@nongnu.org; Thu, 27 May 2010 01:39:25 -0400 Received: from ps.local.valinux.co.jp (vagw.valinux.co.jp [210.128.90.14]) by mail.valinux.co.jp (Postfix) with SMTP id BE3AE1867D; Thu, 27 May 2010 14:39:19 +0900 (JST) Received: (nullmailer pid 13224 invoked by uid 1000); Thu, 27 May 2010 05:35:58 -0000 Date: Thu, 27 May 2010 14:35:58 +0900 From: Isaku Yamahata To: qemu-devel@nongnu.org Message-ID: <20100527053558.GA31807@valinux.co.jp> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.19 (2009-01-05) X-Virus-Scanned: clamav-milter 0.95.2 at va-mail.local.valinux.co.jp X-Virus-Status: Clean X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: [Qemu-devel] [PATCH] qbus: fix memory leak in qbus_free() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org BusState::name is allocated in qbus_create_inplace(). So it should be freed by qbus_free(). Signed-off-by: Isaku Yamahata --- hw/qdev.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index af17486..2845af5 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -700,6 +700,7 @@ void qbus_free(BusState *bus) QLIST_REMOVE(bus, sibling); bus->parent->num_child_bus--; } + qemu_free((void*)bus->name); if (bus->qdev_allocated) { qemu_free(bus); }