From patchwork Sun Feb 21 14:23:20 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gleb Natapov X-Patchwork-Id: 45948 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 8BE3EB7C59 for ; Mon, 22 Feb 2010 01:39:26 +1100 (EST) Received: from localhost ([127.0.0.1]:38928 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NjCjj-0006Fx-TJ for incoming@patchwork.ozlabs.org; Sun, 21 Feb 2010 09:24:43 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NjCiW-0006Fs-Hc for qemu-devel@nongnu.org; Sun, 21 Feb 2010 09:23:28 -0500 Received: from [199.232.76.173] (port=55812 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NjCiV-0006Fk-8I for qemu-devel@nongnu.org; Sun, 21 Feb 2010 09:23:27 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NjCiS-0008D9-TW for qemu-devel@nongnu.org; Sun, 21 Feb 2010 09:23:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40901) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NjCiS-0008CZ-FH for qemu-devel@nongnu.org; Sun, 21 Feb 2010 09:23:24 -0500 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1LENMxV031651 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 21 Feb 2010 09:23:23 -0500 Received: from dhcp-1-237.tlv.redhat.com (dhcp-1-237.tlv.redhat.com [10.35.1.237]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1LENLmL015319; Sun, 21 Feb 2010 09:23:22 -0500 Received: by dhcp-1-237.tlv.redhat.com (Postfix, from userid 13519) id 33FED18D450; Sun, 21 Feb 2010 16:23:21 +0200 (IST) Date: Sun, 21 Feb 2010 16:23:20 +0200 From: Gleb Natapov To: qemu-devel@nongnu.org Message-ID: <20100221142320.GP14767@redhat.com> MIME-Version: 1.0 Content-Disposition: inline X-Scanned-By: MIMEDefang 2.67 on 10.5.11.18 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: armbru@redhat.com Subject: [Qemu-devel] [PATCH] fix 'i' format handling in memory dump X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org It was broken by 09b9418c6d0. (!env && !is_physical) != (!is_physical) when env is true. Signed-off-by: Gleb Natapov --- Gleb. diff --git a/monitor.c b/monitor.c index b1a6edc..19470d1 100644 --- a/monitor.c +++ b/monitor.c @@ -1297,8 +1297,6 @@ static void memory_dump(Monitor *mon, int count, int format, int wsize, int flags; flags = 0; env = mon_get_cpu(); - if (!is_physical) - return; #ifdef TARGET_I386 if (wsize == 2) { flags = 1;