From patchwork Mon Feb 22 02:06:58 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Miller X-Patchwork-Id: 45966 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id F28BAB7CE6 for ; Tue, 23 Feb 2010 02:36:16 +1100 (EST) Received: from localhost ([127.0.0.1]:34711 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NjaKU-0002kF-1V for incoming@patchwork.ozlabs.org; Mon, 22 Feb 2010 10:36:14 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NjNh6-0006gC-Lj for qemu-devel@nongnu.org; Sun, 21 Feb 2010 21:06:44 -0500 Received: from [199.232.76.173] (port=56745 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NjNh5-0006g4-88 for qemu-devel@nongnu.org; Sun, 21 Feb 2010 21:06:43 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NjNh3-0006jZ-UH for qemu-devel@nongnu.org; Sun, 21 Feb 2010 21:06:43 -0500 Received: from 74-93-104-97-washington.hfc.comcastbusiness.net ([74.93.104.97]:55192 helo=sunset.davemloft.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NjNh3-0006jV-Ji for qemu-devel@nongnu.org; Sun, 21 Feb 2010 21:06:41 -0500 Received: from localhost (localhost [127.0.0.1]) by sunset.davemloft.net (Postfix) with ESMTP id 8710E24C097; Sun, 21 Feb 2010 18:06:58 -0800 (PST) Date: Sun, 21 Feb 2010 18:06:58 -0800 (PST) Message-Id: <20100221.180658.226784107.davem@davemloft.net> To: rob@landley.net From: David Miller In-Reply-To: <201002211025.11588.rob@landley.net> References: <201002201712.23628.rob@landley.net> <201002211025.11588.rob@landley.net> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-Mailman-Approved-At: Mon, 22 Feb 2010 10:27:46 -0500 Cc: qemu-devel@nongnu.org, linux-kernel@vger.kernel.org, blauwirbel@gmail.com, pbonzini@redhat.com, sam@ravnborg.org, atar4qemu@googlemail.com Subject: [Qemu-devel] Re: Commit 085219f79cad broke Sparc-32 back in 2.6.28. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Here's the fix I'll use, thanks for the report Rob: sparc32: Fix struct stat uid/gid types. Commit 085219f79cad89291699bd2bfb21c9fdabafe65f ("sparc32: use proper types in struct stat") Accidently changed the struct stat uid/gid members to uid_t and gid_t, but those get set to __kernel_uid32_t and __kernel_gid32_t respectively. Those are of type 'int' but the structure is meant to have 'short'. So use uid16_t and gid16_t to correct this. Reported-by: Rob Landley Signed-off-by: David S. Miller --- arch/sparc/include/asm/stat.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/sparc/include/asm/stat.h b/arch/sparc/include/asm/stat.h index 55db5ec..39327d6 100644 --- a/arch/sparc/include/asm/stat.h +++ b/arch/sparc/include/asm/stat.h @@ -53,8 +53,8 @@ struct stat { ino_t st_ino; mode_t st_mode; short st_nlink; - uid_t st_uid; - gid_t st_gid; + uid16_t st_uid; + gid16_t st_gid; unsigned short st_rdev; off_t st_size; time_t st_atime;