From patchwork Fri Feb 12 02:36:20 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Isaku Yamahata X-Patchwork-Id: 45175 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 09250B7CE2 for ; Fri, 12 Feb 2010 13:36:23 +1100 (EST) Received: from localhost ([127.0.0.1]:46805 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NflOG-0002dt-1J for incoming@patchwork.ozlabs.org; Thu, 11 Feb 2010 21:36:20 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NflNg-0002di-FV for qemu-devel@nongnu.org; Thu, 11 Feb 2010 21:35:44 -0500 Received: from [199.232.76.173] (port=55499 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NflNg-0002da-6S for qemu-devel@nongnu.org; Thu, 11 Feb 2010 21:35:44 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NflNf-0004NS-CZ for qemu-devel@nongnu.org; Thu, 11 Feb 2010 21:35:44 -0500 Received: from mail.valinux.co.jp ([210.128.90.3]:57214) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NflNf-0004NO-0Y for qemu-devel@nongnu.org; Thu, 11 Feb 2010 21:35:43 -0500 Received: from ps.local.valinux.co.jp (vagw.valinux.co.jp [210.128.90.14]) by mail.valinux.co.jp (Postfix) with SMTP id C85D948A72; Fri, 12 Feb 2010 11:35:41 +0900 (JST) Received: (nullmailer pid 32725 invoked by uid 1000); Fri, 12 Feb 2010 02:36:20 -0000 Date: Fri, 12 Feb 2010 11:36:20 +0900 From: Isaku Yamahata To: seabios@seabios.org Message-ID: <20100212023620.GD11930@valinux.co.jp> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.19 (2009-01-05) X-Virus-Scanned: clamav-milter 0.95.2 at va-mail.local.valinux.co.jp X-Virus-Status: Clean X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH] seabios: acpi: fix memory leak in build_srat(). X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org numadata() is allocated for temporal use, but not freed. free it. Signed-off-by: Isaku Yamahata --- src/acpi.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/acpi.c b/src/acpi.c index dbdca79..e2a1153 100644 --- a/src/acpi.c +++ b/src/acpi.c @@ -490,6 +490,7 @@ build_srat(void) srat = malloc_high(srat_size); if (!srat) { dprintf(1, "Not enough memory for srat table!\n"); + free(numadata); return NULL; } @@ -556,6 +557,7 @@ build_srat(void) build_header((void*)srat, SRAT_SIGNATURE, srat_size, 1); + free(numadata); return srat; }