From patchwork Wed Jan 20 14:06:21 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Lo=C3=AFc_Minier?= X-Patchwork-Id: 43294 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B8DE6B7C33 for ; Thu, 21 Jan 2010 01:35:07 +1100 (EST) Received: from localhost ([127.0.0.1]:46465 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NXbcE-00033X-Ta for incoming@patchwork.ozlabs.org; Wed, 20 Jan 2010 09:33:02 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NXbCW-0001Es-Cn for qemu-devel@nongnu.org; Wed, 20 Jan 2010 09:06:28 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NXbCR-00017n-R8 for qemu-devel@nongnu.org; Wed, 20 Jan 2010 09:06:27 -0500 Received: from [199.232.76.173] (port=33143 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NXbCR-00017V-Bf for qemu-devel@nongnu.org; Wed, 20 Jan 2010 09:06:23 -0500 Received: from pig.zood.org ([194.242.112.24]:35205) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NXbCQ-0003XU-QH for qemu-devel@nongnu.org; Wed, 20 Jan 2010 09:06:23 -0500 Received: by pig.zood.org (Postfix, from userid 1000) id E49C34C0B8; Wed, 20 Jan 2010 15:06:21 +0100 (CET) Date: Wed, 20 Jan 2010 15:06:21 +0100 From: =?iso-8859-1?Q?Lo=EFc?= Minier To: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] Re: Stop using "which" in ./configure Message-ID: <20100120140621.GA973@pig.zood.org> References: <20100117124528.GA24106@bee.dooz.org> <4B531406.2070904@mail.berlios.de> <20100119101119.GA11358@bee.dooz.org> <20100119114750.GB11613@bee.dooz.org> <20100120113741.GA31679@pig.zood.org> Mime-Version: 1.0 Content-Disposition: inline In-Reply-To: <20100120113741.GA31679@pig.zood.org> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Wed, Jan 20, 2010, Loïc Minier wrote: > I'm attaching a new patch which changes the tests a bit; I would prefer > if someone with access to a Solaris build environment would do this > though. Sorry, there was a typo in the new patch, a test was reversed; updated patch attached. diff --git a/configure b/configure index 90b3c18..4d48341 100755 --- a/configure +++ b/configure @@ -799,21 +799,19 @@ fi # Solaris specific configure tool chain decisions # if test "$solaris" = "yes" ; then - solinst=`path_of $install` - if test -z "$solinst" ; then + if ! has $install; then echo "Solaris install program not found. Use --install=/usr/ucb/install or" echo "install fileutils from www.blastwave.org using pkg-get -i fileutils" echo "to get ginstall which is used by default (which lives in /opt/csw/bin)" exit 1 fi - if test "$solinst" = "/usr/sbin/install" ; then + if "`path_of $install`" = "/usr/sbin/install" ; then echo "Error: Solaris /usr/sbin/install is not an appropriate install program." echo "try ginstall from the GNU fileutils available from www.blastwave.org" echo "using pkg-get -i fileutils, or use --install=/usr/ucb/install" exit 1 fi - sol_ar=`path_of ar` - if test -z "$sol_ar" ; then + if ! has ar; then echo "Error: No path includes ar" if test -f /usr/ccs/bin/ar ; then echo "Add /usr/ccs/bin to your path and rerun configure"