From patchwork Tue Dec 29 05:01:22 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vince Weaver X-Patchwork-Id: 41878 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E09E7B6EEA for ; Tue, 29 Dec 2009 16:02:14 +1100 (EST) Received: from localhost ([127.0.0.1]:42538 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NPUDi-0005kj-TZ for incoming@patchwork.ozlabs.org; Tue, 29 Dec 2009 00:02:10 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NPUDE-0005kP-Bd for qemu-devel@nongnu.org; Tue, 29 Dec 2009 00:01:40 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NPUD8-0005hc-Ue for qemu-devel@nongnu.org; Tue, 29 Dec 2009 00:01:39 -0500 Received: from [199.232.76.173] (port=37594 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NPUD8-0005hZ-Om for qemu-devel@nongnu.org; Tue, 29 Dec 2009 00:01:34 -0500 Received: from csl.cornell.edu ([128.84.224.10]:4790 helo=vlsi.csl.cornell.edu) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NPUD8-0003ny-O8 for qemu-devel@nongnu.org; Tue, 29 Dec 2009 00:01:34 -0500 Received: from stanley.csl.cornell.edu (stanley.csl.cornell.edu [128.84.224.15]) by vlsi.csl.cornell.edu (8.13.4/8.13.4) with ESMTP id nBT51Mk9040699 for ; Tue, 29 Dec 2009 00:01:28 -0500 (EST) Date: Tue, 29 Dec 2009 00:01:22 -0500 (EST) From: Vince Weaver To: qemu-devel@nongnu.org Message-ID: <20091228235833.H44497@stanley.csl.cornell.edu> MIME-Version: 1.0 X-detected-operating-system: by monty-python.gnu.org: FreeBSD 2.0-4.2 Subject: [Qemu-devel] [patch] alpha-linux-user stat64 issue X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Hello The stat64/fstat64 syscalls are broken for alpha linux-user. This is because Alpha, even though it is native 64-bits, has a stat64 syscall that is different than regular stat. This means that the "TARGET_LONG_BITS==64" check in syscall.c isn't enough. Below is a patch that fixes things for me, although it might not be the cleanest fix. This issue keeps sixtrack and fma3d spec2k benchmarks from running. Vince Signed-off-by: Vince Weaver Acked-by: Richard Henderson diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 1acf1f5..f2dd39e 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -4004,7 +4004,7 @@ static inline abi_long host_to_target_stat64(void *cpu_env, } else #endif { -#if TARGET_LONG_BITS == 64 +#if (TARGET_LONG_BITS == 64) && (!defined(TARGET_ALPHA)) struct target_stat *target_st; #else struct target_stat64 *target_st;