From patchwork Mon Dec 14 20:54:43 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Lock X-Patchwork-Id: 41156 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 782BAB6F1C for ; Tue, 15 Dec 2009 09:12:50 +1100 (EST) Received: from localhost ([127.0.0.1]:40258 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NKJ9q-0000Eo-Ex for incoming@patchwork.ozlabs.org; Mon, 14 Dec 2009 17:12:46 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NKJ9M-0000EH-Td for qemu-devel@nongnu.org; Mon, 14 Dec 2009 17:12:16 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NKJ9L-0000Dw-NV for qemu-devel@nongnu.org; Mon, 14 Dec 2009 17:12:15 -0500 Received: from [199.232.76.173] (port=48576 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NKJ9L-0000Dl-Et for qemu-devel@nongnu.org; Mon, 14 Dec 2009 17:12:15 -0500 Received: from gelbbaer.kn-bremen.de ([78.46.108.116]:54248 helo=smtp.kn-bremen.de) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NKJ9K-0001ri-Hj for qemu-devel@nongnu.org; Mon, 14 Dec 2009 17:12:15 -0500 Received: by smtp.kn-bremen.de (Postfix, from userid 10) id 1DC811E0074E; Mon, 14 Dec 2009 23:12:12 +0100 (CET) Received: from triton8.kn-bremen.de (noident@localhost [127.0.0.1]) by triton8.kn-bremen.de (8.14.3/8.14.3) with ESMTP id nBEKsiE5076529 for ; Mon, 14 Dec 2009 21:54:44 +0100 (CET) (envelope-from nox@triton8.kn-bremen.de) Received: (from nox@localhost) by triton8.kn-bremen.de (8.14.3/8.14.3/Submit) id nBEKshX8076528 for qemu-devel@nongnu.org; Mon, 14 Dec 2009 21:54:43 +0100 (CET) (envelope-from nox) From: Juergen Lock Date: Mon, 14 Dec 2009 21:54:43 +0100 To: qemu-devel@nongnu.org Message-ID: <20091214205443.GA24776@triton8.kn-bremen.de> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: [Qemu-devel] [PATCH:] Fix a make -j race X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Make libuser.a depend on $(GENERATED_HEADERS) too so make -j won't start building it before the headers exist. (There may be more bugs like this but at least this makes (g)make -j4 started from scratch on a quadcore now always complete here again.) Signed-off-by: Juergen Lock --- a/Makefile +++ b/Makefile @@ -79,7 +79,7 @@ $(filter %-softmmu,$(SUBDIR_RULES)): lib $(filter %-user,$(SUBDIR_RULES)): libuser.a -libuser.a: +libuser.a: $(GENERATED_HEADERS) $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C libuser V="$(V)" TARGET_DIR="libuser/" all,) ROMSUBDIR_RULES=$(patsubst %,romsubdir-%, $(ROMS))