From patchwork Tue Oct 13 13:14:21 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Michael S. Tsirkin" X-Patchwork-Id: 35853 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 878BEB7B8C for ; Wed, 14 Oct 2009 00:17:24 +1100 (EST) Received: from localhost ([127.0.0.1]:40827 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MxhFg-00027x-Mi for incoming@patchwork.ozlabs.org; Tue, 13 Oct 2009 09:17:20 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MxhFD-00027e-Bd for qemu-devel@nongnu.org; Tue, 13 Oct 2009 09:16:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MxhFA-00026o-3j for qemu-devel@nongnu.org; Tue, 13 Oct 2009 09:16:51 -0400 Received: from [199.232.76.173] (port=38514 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MxhF9-00026l-Q3 for qemu-devel@nongnu.org; Tue, 13 Oct 2009 09:16:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5251) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MxhF9-0006sV-Af for qemu-devel@nongnu.org; Tue, 13 Oct 2009 09:16:47 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9DDGal9010422; Tue, 13 Oct 2009 09:16:36 -0400 Received: from redhat.com (vpn-6-79.tlv.redhat.com [10.35.6.79]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with SMTP id n9DDGSve032416; Tue, 13 Oct 2009 09:16:32 -0400 Date: Tue, 13 Oct 2009 15:14:21 +0200 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org, av1474@comtv.ru Message-ID: <20091013131420.GA17474@redhat.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.19 (2009-01-05) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.17 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Subject: [Qemu-devel] [PATCH] qemu: allow pulseaudio backend to be the default X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Mark McLoughlin Date: Fri, 4 Sep 2009 10:24:03 +0000 (+0100) Subject: qemu: allow pulseaudio backend to be the default X-Git-Url: http://repo.or.cz/w/qemu-kvm/fedora.git?a=commitdiff_plain;h=8ab0d97572 We're seeing various issues with the SDL audio backend and want to switch to the pulseaudio backend. See e.g. https://bugzilla.redhat.com/495964 https://bugzilla.redhat.com/519540 https://bugzilla.redhat.com/496627 The pulseaudio backend seems to work well, so we should allow it to be selected as the default. Signed-off-by: Mark McLoughlin Signed-off-by: Michael S. Tsirkin --- The patch above is in qemu in Fedora 11. Pulseaudio seems to be the only way to get decent sound quality on default installation in that distro, and there does not seem to be a reason not to allow pulseaudio be the default, if the user chooses to make it so at configure time. Please comment or commit. diff --git a/audio/paaudio.c b/audio/paaudio.c index a50fccc..547e252 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -507,7 +507,7 @@ struct audio_driver pa_audio_driver = { INIT_FIELD (init = ) qpa_audio_init, INIT_FIELD (fini = ) qpa_audio_fini, INIT_FIELD (pcm_ops = ) &qpa_pcm_ops, - INIT_FIELD (can_be_default = ) 0, + INIT_FIELD (can_be_default = ) 1, INIT_FIELD (max_voices_out = ) INT_MAX, INIT_FIELD (max_voices_in = ) INT_MAX, INIT_FIELD (voice_size_out = ) sizeof (PAVoiceOut),