From patchwork Mon Sep 11 19:52:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 812569 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="L4vAgsV4"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xrdxT3dT1z9s0Z for ; Tue, 12 Sep 2017 05:57:17 +1000 (AEST) Received: from localhost ([::1]:60215 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drUpX-00062Z-HS for incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 15:57:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drUot-000610-EG for qemu-devel@nongnu.org; Mon, 11 Sep 2017 15:56:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drUop-00022D-Fu for qemu-devel@nongnu.org; Mon, 11 Sep 2017 15:56:35 -0400 Received: from mail-bn3nam01on0075.outbound.protection.outlook.com ([104.47.33.75]:52954 helo=NAM01-BN3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1drUop-00021S-9d for qemu-devel@nongnu.org; Mon, 11 Sep 2017 15:56:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=cUMF29XgxtBE+UNQPEUNS/5XsYAoSZiL+ZRZ03Pf9kI=; b=L4vAgsV4PNijAq9djQTahVzpBGf/6ElBvFrTirdEm7vf3z1waq5/rVuNDrz0fmXHm0r4EjUVSROY5pKV4E5zNyVtNcm1vGz2w9t/oWaZENC9o+U/jlyvGpAdZgG6gLANR/BZmkgwNK1Du6RL9HwfhuTVDctlb4mKgrJSH/c+bwI= Received: from CY1PR0201CA0020.namprd02.prod.outlook.com (2a01:111:e400:58b9::30) by BY1PR02MB1129.namprd02.prod.outlook.com (2a01:111:e400:52a7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12; Mon, 11 Sep 2017 19:56:28 +0000 Received: from BL2NAM02FT023.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::201) by CY1PR0201CA0020.outlook.office365.com (2a01:111:e400:58b9::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.35.12 via Frontend Transport; Mon, 11 Sep 2017 19:56:28 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by BL2NAM02FT023.mail.protection.outlook.com (10.152.77.72) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.13.11 via Frontend Transport; Mon, 11 Sep 2017 19:56:27 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:45235 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1drUok-0001Ph-OO; Mon, 11 Sep 2017 12:56:26 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1drUok-0008Vd-LD; Mon, 11 Sep 2017 12:56:26 -0700 Received: from xsj-pvapsmtp01 (xsj-smtp1.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id v8BJuIiP017505; Mon, 11 Sep 2017 12:56:18 -0700 Received: from [172.19.2.220] (helo=localhost.localdomain) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1drUoc-0008Um-8B; Mon, 11 Sep 2017 12:56:18 -0700 From: Alistair Francis To: Date: Mon, 11 Sep 2017 12:52:43 -0700 Message-ID: <1d6ef2ccd9667878ed5820fcf17eef35957ea5d8.1505158760.git.alistair.francis@xilinx.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23322.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(2980300002)(438002)(199003)(189002)(2906002)(33646002)(63266004)(2351001)(77096006)(106466001)(8676002)(118296001)(189998001)(50986999)(50466002)(5003940100001)(76176999)(48376002)(50226002)(81166006)(81156014)(47776003)(8936002)(36756003)(36386004)(15650500001)(9786002)(478600001)(6916009)(2950100002)(54906002)(356003)(6666003)(5660300001)(305945005)(110136004)(4326008)(39060400002)(107986001)(5001870100001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR02MB1129; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2NAM02FT023; 1:tEDh2erv/TNmpavH49vPkz+2+H6/hBKnsej4WZIqXmctk2gdAU/7Plb1KYUNchyG/Y/x9q/DqOWUsLJPkhj27z/dhal3iZOdP869BNcQZK1+Vko9jyFtBlaIOiNZiNxx MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3a541ea0-82ef-4388-6872-08d4f94f3065 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BY1PR02MB1129; X-Microsoft-Exchange-Diagnostics: 1; BY1PR02MB1129; 3:9CGtM3uyNXVMbXK6BeRf7tvtb7gcEGAySxo6qOb1tRYVyMty7pAJSzat1rezvIGbqe90Uslw6fdu2GNOS9W5LO1wz2gWCb21yi8jqWTeuuTQcaxOTVXuZPhaCi+RtUsp3h9pWMge7IdP03L8eI1MS3TnJ64m9FfDNgwr9h6Aq8x9Z6TXVuoqOVN3PPgWrtLQClqmCeD6WzxEHPhBSSLkD1J9MYDETkTZYcdD1tFQ6BsuWgWRdwGsRSMUhYxypY77jh+tlfcgQYkJV/+nKJpfiE2IdTVRKs09ZeYb+NS/fpuu57dtSY7JnvtfY7Cg1633qF5sLc1MjMEW78gzWFUlPENlxXooobhDY62T6KEzGqk=; 25:5U/jWr8uIVnCKbuK3DepalX/4acwp5GexaMhFk2fseF3pKlZIsyUyxbekv5kU+Ld8ICms5O7HT7a93IPkXI/zRaIktoSt6+0SLCxxpg6EbO7po8RHzt4vZmGri3ESVe9tGwxQVNGcfXgpaBP9IwJnEQvIj5sgXjRVPzq2Cr8a4VeaJlhrzH+KhHlDlIX6AyDk3WO2Kl6ltu6F+kM0xRwWZ2kQzvA7qhjESCGW2BBZbSS1J7m+h6rGusycBpGjoeXsJafSPSN1MuG9YKerXAOn8qJBg106JJslLq+1hySK+dHF9vPhyKzcaSxVi4vHJnVKOl6KbUfrohJS81dyjI4dg== X-MS-TrafficTypeDiagnostic: BY1PR02MB1129: X-Microsoft-Exchange-Diagnostics: 1; BY1PR02MB1129; 31:PmYOpsmF6qV6c+QVpJeCVPGCLQjnkJYawnH5CLJP4Npme6ENjyBW83qLE6F03iebvQrU+/qEnB+WgnD40R1LVn9WXISDOVvC7b3FKoaCmEAv3m1UyjGb4Gvwp1jhJ7pX91DdpMc8Xj8PF4k+7RbD2mjXezzLoHB2A52ftaRARAZdlO1i43S8akZS0CtdjT8h3gze+medVvRZxOIpQ2v8MXCDJ7Lly9wqdKGt6Xrwn4c=; 20:AQUHgGBbingoc8fskm76PgDivQzXFJbkllAfledVnUBPAE1vzoK/BmYgZyRc8XVntguEkD8BU+btzz2c2XVfMaveObbvOtkRPBxfe79YxTXhLL71+cgBwlsx5edzN+KcjUL/FBMCwrjpOIFo/kTIX2Gj2PgKzJlzM+8NoVTGWvb2gGXBRC31dxdZNwc3EWqYG9+ZDydUpCSld19xzImQExMAR/5tk8tx7tPowqtAcD/+BFvVssssMCFfYdXGIfEc7535fDBq6Acfic/kTpEIeFqoksFcPeXmRDODCoI+9A5St32gO0SlRdBPlUuHdBwqZTrRmvEoVdR5RhHz+Nu/QVZfe7WatK+SI89aOBfbPZaN1lQDYbrBpHoj17lOINnW/gG5zOKsCansdC25NKVlHIK9CfF1PU9CwJysi/2ZzUDUp5ybbb1/9e7kJPqPIYzEnqhqO9Z81TiNMr17QXewo51V5gj4ixiv7XnbLPQakZmrwIRqJkDMyDVDSruPyvZU X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93004095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123562025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BY1PR02MB1129; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BY1PR02MB1129; X-Microsoft-Exchange-Diagnostics: 1; BY1PR02MB1129; 4:UsFREthzrw5cE2M1+nQ4xXhUiwTOjAkXYw+TXeC1udn7Hccm6GF16o2mw6AqCOPuByVQ6Lr4C1jczFgJr011rxY1W4REGqPY2LXP9rcmIiqzN4Hu84twULFdwWfJUyuCOQVedHZkAUxvavWItFAr0GldA8QyLMoYhe8L/guq9fbOrtfVEKLygR5E70hQp3bmLW8rc47GI4z/0JlErO5AUnox0L2dkM2Drjb109/EuUmJGs44wbE1ehqRVx0QikGXiNG1W2WhD0tP0LAWP6pVigYCrfUtNovBWzuhAIFItpA= X-Forefront-PRVS: 04270EF89C X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR02MB1129; 23:ODBSGJb6SAwq2WJbNPcEq+jXhyE2/dZQWVb4BKli9?= 9V3I/4uBf0/ROSTfxUDULFv677o9Dk2Y34oISCe5jZEk5OyTX3+ptPA6rJU35II+pqK00oR8BjyXSaBNbGmf2QUVewSXhch1efLOWS7njrXV7PdNZvFOz4acoqamkrw32ZH85lgPbM+NkMiUtWMwLJ2oetxtFTpzsdqHK/Rx01R5KcNMCqe1MC5z8+vI4hFVkzc2E9DBeEZ4FAtaUj7/d8/mCz5vuMl3g+UjQdx3flotsmcXsMRXvo4+e1ng6aa+5hVxQQzzf/cfdsyUuniaUycwmXQAdaJ7O9/d+60rYuNZoRFAXXKDVueiYrAMEVzMOXwsQdWi53VjbYfLNF+h069FK9cK6CEAJWSeopaICvyZK2fxwMGXkS2nMweZAXROwSMT9RUKOtR06ibETJSC5bI+xmKJxwxg3QQnvwm4InWmAKyVzsBSxnUAshr3lgibXL5ZI7n11jgo6h0yRRHLT5bvAZ6ht4h4xmy+Iwo965hRmQu9LIViSTJ6lzDwNpgU5I7xuhNlFLSYCujVArbGRbdqPveF33gCJfxrGzjpIlTF5JE3ldBlQDZdT0QfUo2bYsCdAH6FMADfX5YkrOXKuThmnDEyGHc6FWW2EoZcjN561v03pRrcWuEJbTYs3yJnPYHfVrn0A4GgPI0JEzjXiqagazseSij5/2IWIso83F2YgY1GhhwQz0iEaVsrm5HwDqfXukwMQ6umcAIGRQrldcVSHEgiOwr0NU0egX2IEi5YQ3qNAW0hSCm2ONjJ2e6W5XK1Cg/1CeJEd9rDcahhrv5aJn+eGHlFViREzz+j4zLp/J0U9qNRpBjR7myV/eHdjavrI8I6z5b26uw5K2Ey1Q57St4c6bRY5kkKK/FWn6EMT0zjZVhL1s223eBB+DhkDP1XnPOlMr1voqhTnE74Zh7JrwPNwqcSFC05XVPsvYmRBro9aWcFbeEeCkZA8tncsbMhiXdq5T5AolsTz/msC7qedlMPPbywQrTSbh1kZpcDSnmUslUlPkVbOn3Di0XviI= X-Microsoft-Exchange-Diagnostics: 1; BY1PR02MB1129; 6:gZjEqzTktMwKt9/JVvJp7sKI/wDYgWN/VvhF2VAiXGjIHrsjL1ONkh95sUsP8EeQdpANWhevu+OT068iu1GZYZRgejtG9M2lDU18rc6aT07EqCNGBZ3gusWcHO6Rar9oOFTJeQ+T96BT5ZRcHfB4eRoftMw/7u77DiLoK3323JY7PsX/oc+x7suyt6zS6SThHUMl+eP5UUcfWud3IEE7Kk6h2Bs6MenGlZjcXosJmUJs6pf2arw+ifzuXF17ejEhNJGNf5zTjhQEZKco/AWkjOPl9N8zoo2tCMCTRnDrLi30EC+OPV5LaIyOGlrIbdj+ZsPQXv0iRLQIFqBAFQQtBw==; 5:eNJcJjRHQL9RZ9P4OTfZ8Bnuj1Slta+fDPokLvYbALtOwYRGqlOWoT8FSuQXE/9/FO2SzEcFp9VChsLEhwQfAIkxFEV4IPjpQyQQ30fM2LQC/60mPFgJW5+GKFZLVKLViaRUHycEfXvAOKqjZV5GPA==; 24:ghmLqMpur1AtkmneIU18Vrh0QZP7YyCPkha5xnZvFL7/yErY2VXnc81JDJHE1i4mZUsJ9gCcC242sAFyt/Eq6WXGLO9bec6wk5n6xqj8Vrk=; 7:taL2RWD2s48pRcLkA6F9eSwCprRMwspBmCgA7Q2kQ+KSkFBQdVENfsCuSIk+eNhpZl4CFqj1TKB7ttvCbcSc98zTy+j92vzQBJRMO5iH2vxb8eBNaOeuSQuEynkx9iUUy+oH8/g2JJC+6Pw8m2N31tVphD+S7W0GScvvWwJ6KsTdWAWUBjzD1lwYHk9dvjqMzxvHjzGR6x0qvh/yjCgbJhvzvuG8+Jc4mt1aaFxZusI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2017 19:56:27.3111 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR02MB1129 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.33.75 Subject: [Qemu-devel] [PATCH v4 1/8] hw/i386: Improve some of the warning messages X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, pbonzini@redhat.com, armbru@redhat.com, Eduardo Habkost , alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Alistair Francis Suggested-by: Eduardo Habkost Cc: Eduardo Habkost Reviewed-by: Eduardo Habkost --- V4: - Fixup pc_q35.c message V3: - Improve the messages hw/i386/acpi-build.c | 15 ++++++++++----- hw/i386/pc.c | 7 +++---- hw/i386/pc_q35.c | 8 +++++--- 3 files changed, 18 insertions(+), 12 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 4d19d91e1b..9776812588 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -2750,17 +2750,22 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine) ACPI_BUILD_ALIGN_SIZE); if (tables_blob->len > legacy_table_size) { /* Should happen only with PCI bridges and -M pc-i440fx-2.0. */ - warn_report("migration may not work."); + warn_report("ACPI table size %u exceeds %d bytes," + " migration may not work", + tables_blob->len, legacy_table_size); + error_printf("Try removing CPUs, NUMA nodes, memory slots" + " or PCI bridges."); } g_array_set_size(tables_blob, legacy_table_size); } else { /* Make sure we have a buffer in case we need to resize the tables. */ if (tables_blob->len > ACPI_BUILD_TABLE_SIZE / 2) { /* As of QEMU 2.1, this fires with 160 VCPUs and 255 memory slots. */ - warn_report("ACPI tables are larger than 64k."); - warn_report("migration may not work."); - warn_report("please remove CPUs, NUMA nodes, " - "memory slots or PCI bridges."); + warn_report("ACPI table size %u exceeds %d bytes," + " migration may not work", + tables_blob->len, ACPI_BUILD_TABLE_SIZE / 2); + error_printf("Try removing CPUs, NUMA nodes, memory slots" + " or PCI bridges."); } acpi_align_size(tables_blob, ACPI_BUILD_TABLE_SIZE); } diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 21081041d5..c882f8c2ea 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -384,7 +384,7 @@ ISADevice *pc_find_fdc0(void) warn_report("multiple floppy disk controllers with " "iobase=0x3f0 have been found"); error_printf("the one being picked for CMOS setup might not reflect " - "your intent\n"); + "your intent"); } return state.floppy; @@ -2098,9 +2098,8 @@ static void pc_machine_set_max_ram_below_4g(Object *obj, Visitor *v, } if (value < (1ULL << 20)) { - warn_report("small max_ram_below_4g(%"PRIu64 - ") less than 1M. BIOS may not work..", - value); + warn_report("Only %" PRIu64 " bytes of RAM below the 4GiB boundary," + "BIOS may not work with less than 1MiB", value); } pcms->max_ram_below_4g = value; diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index c1cba584d1..7947efb680 100644 --- a/hw/i386/pc_q35.c +++ b/hw/i386/pc_q35.c @@ -101,9 +101,11 @@ static void pc_q35_init(MachineState *machine) lowmem = pcms->max_ram_below_4g; if (machine->ram_size - lowmem > lowmem && lowmem & ((1ULL << 30) - 1)) { - warn_report("Large machine and max_ram_below_4g(%"PRIu64 - ") not a multiple of 1G; possible bad performance.", - pcms->max_ram_below_4g); + warn_report("There is possibly poor performance as the ram size " + " (0x%" PRIx64 ") is more then twice the size of" + " max-ram-below-4g (%"PRIu64") and" + " max-ram-below-4g is not a multiple of 1G.", + machine->ram_size, pcms->max_ram_below_4g); } }