| Message ID | 1a724e97cb587624d6f6009c15395496bccfa32b.1456317738.git.mprivozn@redhat.com |
|---|---|
| State | New |
| Headers | show |
Hi ----- Original Message ----- > After 474114b7 the dmabuf feature is enabled whenever spice > greater than or equal to spice 0.13.0 is found. This is because > two new functions are required: spice_qxl_gl_scanout and > spice_qxl_gl_draw_async. These were, however, introduce in 0.13.1 > release. Well, technically they haven't been released yet, but > for sure they are not going to be part of 0.13.0 release (for the > ABI stability sake). > > Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Ack (that was part too of my previous review comments btw) > --- > include/ui/spice-display.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/ui/spice-display.h b/include/ui/spice-display.h > index 69a222b..30ccfe3 100644 > --- a/include/ui/spice-display.h > +++ b/include/ui/spice-display.h > @@ -25,7 +25,7 @@ > #include "sysemu/sysemu.h" > > #if defined(CONFIG_OPENGL_DMABUF) > -# if SPICE_SERVER_VERSION >= 0x000d00 /* release 0.13.0 */ > +# if SPICE_SERVER_VERSION >= 0x000d01 /* release 0.13.1 */ > # define HAVE_SPICE_GL 1 > # include "ui/egl-helpers.h" > # include "ui/egl-context.h" > -- > 2.4.10 > >
On Mi, 2016-02-24 at 13:42 +0100, Michal Privoznik wrote: > After 474114b7 the dmabuf feature is enabled whenever spice > greater than or equal to spice 0.13.0 is found. This is because > two new functions are required: spice_qxl_gl_scanout and > spice_qxl_gl_draw_async. These were, however, introduce in 0.13.1 > release. Well, technically they haven't been released yet, but > for sure they are not going to be part of 0.13.0 release (for the > ABI stability sake). Added to patch queue. thanks, Gerd
diff --git a/include/ui/spice-display.h b/include/ui/spice-display.h index 69a222b..30ccfe3 100644 --- a/include/ui/spice-display.h +++ b/include/ui/spice-display.h @@ -25,7 +25,7 @@ #include "sysemu/sysemu.h" #if defined(CONFIG_OPENGL_DMABUF) -# if SPICE_SERVER_VERSION >= 0x000d00 /* release 0.13.0 */ +# if SPICE_SERVER_VERSION >= 0x000d01 /* release 0.13.1 */ # define HAVE_SPICE_GL 1 # include "ui/egl-helpers.h" # include "ui/egl-context.h"
After 474114b7 the dmabuf feature is enabled whenever spice greater than or equal to spice 0.13.0 is found. This is because two new functions are required: spice_qxl_gl_scanout and spice_qxl_gl_draw_async. These were, however, introduce in 0.13.1 release. Well, technically they haven't been released yet, but for sure they are not going to be part of 0.13.0 release (for the ABI stability sake). Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- include/ui/spice-display.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)