From patchwork Fri Nov 6 12:43:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 540964 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id E74451402A2 for ; Fri, 6 Nov 2015 23:53:09 +1100 (AEDT) Received: from localhost ([::1]:38335 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZugVv-0002A4-Ld for incoming@patchwork.ozlabs.org; Fri, 06 Nov 2015 07:53:07 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZugSf-0005Kf-ME for qemu-devel@nongnu.org; Fri, 06 Nov 2015 07:49:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZugSa-0001T4-Lp for qemu-devel@nongnu.org; Fri, 06 Nov 2015 07:49:45 -0500 Received: from isrv.corpit.ru ([86.62.121.231]:40895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZugSa-0001S3-E2; Fri, 06 Nov 2015 07:49:40 -0500 Received: from tsrv.tls.msk.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 2690F40DD1; Fri, 6 Nov 2015 15:49:39 +0300 (MSK) Received: from tls.msk.ru (mjt.vpn.tls.msk.ru [192.168.177.99]) by tsrv.tls.msk.ru (Postfix) with SMTP id 5BABCAB7; Fri, 6 Nov 2015 15:44:04 +0300 (MSK) Received: (nullmailer pid 31694 invoked by uid 1000); Fri, 06 Nov 2015 12:44:03 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Date: Fri, 6 Nov 2015 15:43:48 +0300 Message-Id: <1a13b27273cdc4f6fd18bc1e83950d47c6b5928b.1446813769.git.mjt@msgid.tls.msk.ru> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, Thomas Huth , Michael Tokarev Subject: [Qemu-devel] [PULL 11/24] hw/dma/pxa2xx: Remove superfluous memset X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Thomas Huth g_malloc0 already clears the memory, so no need for the additional memset here. And while we're at it, also convert the g_malloc0 to the preferred g_new0. Signed-off-by: Thomas Huth Reviewed-by: Eric Blake Signed-off-by: Michael Tokarev --- hw/dma/pxa2xx_dma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/dma/pxa2xx_dma.c b/hw/dma/pxa2xx_dma.c index d4501fb..54cdb25 100644 --- a/hw/dma/pxa2xx_dma.c +++ b/hw/dma/pxa2xx_dma.c @@ -459,9 +459,8 @@ static int pxa2xx_dma_init(SysBusDevice *sbd) return -1; } - s->chan = g_malloc0(sizeof(PXA2xxDMAChannel) * s->channels); + s->chan = g_new0(PXA2xxDMAChannel, s->channels); - memset(s->chan, 0, sizeof(PXA2xxDMAChannel) * s->channels); for (i = 0; i < s->channels; i ++) s->chan[i].state = DCSR_STOPINTR;