From patchwork Tue Jun 22 02:55:33 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Isaku Yamahata X-Patchwork-Id: 56393 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 68687B6F0D for ; Tue, 22 Jun 2010 13:15:27 +1000 (EST) Received: from localhost ([127.0.0.1]:55985 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OQtxM-0003wz-Do for incoming@patchwork.ozlabs.org; Mon, 21 Jun 2010 23:15:24 -0400 Received: from [140.186.70.92] (port=36375 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OQtr7-0000oJ-1U for qemu-devel@nongnu.org; Mon, 21 Jun 2010 23:08:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OQthr-00030j-Pf for qemu-devel@nongnu.org; Mon, 21 Jun 2010 22:59:25 -0400 Received: from mail.valinux.co.jp ([210.128.90.3]:59876) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OQthr-000308-GB for qemu-devel@nongnu.org; Mon, 21 Jun 2010 22:59:23 -0400 Received: from ps.local.valinux.co.jp (vagw.valinux.co.jp [210.128.90.14]) by mail.valinux.co.jp (Postfix) with SMTP id 1A6AD10742A; Tue, 22 Jun 2010 11:59:20 +0900 (JST) Received: (nullmailer pid 4222 invoked by uid 1000); Tue, 22 Jun 2010 02:55:35 -0000 From: Isaku Yamahata To: qemu-devel@nongnu.org Date: Tue, 22 Jun 2010 11:55:33 +0900 Message-Id: <194431c7d3de831a5084a63447401d2a0883d13c.1277174072.git.yamahata@valinux.co.jp> X-Mailer: git-send-email 1.6.6.1 In-Reply-To: References: In-Reply-To: References: X-Virus-Scanned: clamav-milter 0.95.2 at va-mail.local.valinux.co.jp X-Virus-Status: Clean X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: yamahata@valinux.co.jp, kraxel@redhat.com, mst@redhat.com Subject: [Qemu-devel] [PATCH v2 1/3] pci: fix memory leak of PCIDevice::romfile. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org PCIDevice::romfile is allocatedi n pci_qdev_init(). But nowhere freed. Free it in do_pci_unregister_device(). Cc: Gerd Hoffmann Signed-off-by: Isaku Yamahata --- hw/pci.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 7787005..7e5c539 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -650,6 +650,7 @@ static void do_pci_unregister_device(PCIDevice *pci_dev) qemu_free_irqs(pci_dev->irq); pci_dev->bus->devices[pci_dev->devfn] = NULL; pci_config_free(pci_dev); + qemu_free(pci_dev->romfile); } PCIDevice *pci_register_device(PCIBus *bus, const char *name,