| Message ID | 1615275756-129881-1-git-send-email-a_lijiejun@163.com |
|---|---|
| State | New |
| Headers | show |
| Series | virtio-gpu: Add spaces around operator | expand |
(Cc'ing qemu-trivial@) On 3/9/21 8:42 AM, lijiejun wrote: > Fix code style. Operator needs spaces forend sides, and delete line space. "forend"? Otherwise: Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > > Signed-off-by: lijiejun <a_lijiejun@163.com> > --- > hw/display/virtio-gpu-3d.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c > index 9eb4890..d989648 100644 > --- a/hw/display/virtio-gpu-3d.c > +++ b/hw/display/virtio-gpu-3d.c > @@ -438,7 +438,7 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g, > break; > case VIRTIO_GPU_CMD_RESOURCE_FLUSH: > virgl_cmd_resource_flush(g, cmd); > - break; > + break; > case VIRTIO_GPU_CMD_RESOURCE_UNREF: > virgl_cmd_resource_unref(g, cmd); > break; > @@ -456,7 +456,6 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g, > case VIRTIO_GPU_CMD_GET_CAPSET: > virgl_cmd_get_capset(g, cmd); > break; > - > case VIRTIO_GPU_CMD_GET_DISPLAY_INFO: > virtio_gpu_get_display_info(g, cmd); > break; >
At 2021-03-09 17:08:08, "Philippe Mathieu-Daudé" <philmd@redhat.com> wrote: >(Cc'ing qemu-trivial@) > >On 3/9/21 8:42 AM, lijiejun wrote: >> Fix code style. Operator needs spaces forend sides, and delete line space. > >"forend"? done with: Fix code style. Operator needs align with eight spaces, and delete line space. > >Otherwise: >Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > >> >> Signed-off-by: lijiejun <a_lijiejun@163.com> >> --- >> hw/display/virtio-gpu-3d.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c >> index 9eb4890..d989648 100644 >> --- a/hw/display/virtio-gpu-3d.c >> +++ b/hw/display/virtio-gpu-3d.c >> @@ -438,7 +438,7 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g, >> break; >> case VIRTIO_GPU_CMD_RESOURCE_FLUSH: >> virgl_cmd_resource_flush(g, cmd); >> - break; >> + break; >> case VIRTIO_GPU_CMD_RESOURCE_UNREF: >> virgl_cmd_resource_unref(g, cmd); >> break; >> @@ -456,7 +456,6 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g, >> case VIRTIO_GPU_CMD_GET_CAPSET: >> virgl_cmd_get_capset(g, cmd); >> break; >> - >> case VIRTIO_GPU_CMD_GET_DISPLAY_INFO: >> virtio_gpu_get_display_info(g, cmd); >> break; >>
On 3/9/21 1:42 AM, lijiejun wrote: > Fix code style. Operator needs spaces forend sides, and delete line space. What operator? 'break' is a statement, not an operator. > > Signed-off-by: lijiejun <a_lijiejun@163.com> > --- > hw/display/virtio-gpu-3d.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c > index 9eb4890..d989648 100644 > --- a/hw/display/virtio-gpu-3d.c > +++ b/hw/display/virtio-gpu-3d.c > @@ -438,7 +438,7 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g, > break; > case VIRTIO_GPU_CMD_RESOURCE_FLUSH: > virgl_cmd_resource_flush(g, cmd); > - break; > + break; > case VIRTIO_GPU_CMD_RESOURCE_UNREF: > virgl_cmd_resource_unref(g, cmd); > break; > @@ -456,7 +456,6 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g, > case VIRTIO_GPU_CMD_GET_CAPSET: > virgl_cmd_get_capset(g, cmd); > break; > - > case VIRTIO_GPU_CMD_GET_DISPLAY_INFO: > virtio_gpu_get_display_info(g, cmd); > break; >
diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c index 9eb4890..d989648 100644 --- a/hw/display/virtio-gpu-3d.c +++ b/hw/display/virtio-gpu-3d.c @@ -438,7 +438,7 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g, break; case VIRTIO_GPU_CMD_RESOURCE_FLUSH: virgl_cmd_resource_flush(g, cmd); - break; + break; case VIRTIO_GPU_CMD_RESOURCE_UNREF: virgl_cmd_resource_unref(g, cmd); break; @@ -456,7 +456,6 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g, case VIRTIO_GPU_CMD_GET_CAPSET: virgl_cmd_get_capset(g, cmd); break; - case VIRTIO_GPU_CMD_GET_DISPLAY_INFO: virtio_gpu_get_display_info(g, cmd); break;
Fix code style. Operator needs spaces forend sides, and delete line space. Signed-off-by: lijiejun <a_lijiejun@163.com> --- hw/display/virtio-gpu-3d.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)