From patchwork Wed Feb 24 07:55:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jos=C3=A9_Pekkarinen?= <1908832@bugs.launchpad.net> X-Patchwork-Id: 1443734 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DlpKk3Yy4z9sBy for ; Wed, 24 Feb 2021 19:02:02 +1100 (AEDT) Received: from localhost ([::1]:59800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEp7Q-0002CR-I3 for incoming@patchwork.ozlabs.org; Wed, 24 Feb 2021 03:02:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEp6q-0002C7-S5 for qemu-devel@nongnu.org; Wed, 24 Feb 2021 03:01:24 -0500 Received: from indium.canonical.com ([91.189.90.7]:48542) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lEp6o-0004jZ-7O for qemu-devel@nongnu.org; Wed, 24 Feb 2021 03:01:24 -0500 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.86_2 #2 (Debian)) id 1lEp6m-0000zZ-GZ for ; Wed, 24 Feb 2021 08:01:20 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 5FF352E8143 for ; Wed, 24 Feb 2021 08:01:20 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 24 Feb 2021 07:55:07 -0000 From: =?utf-8?q?Jos=C3=A9_Pekkarinen?= <1908832@bugs.launchpad.net> To: qemu-devel@nongnu.org X-Launchpad-Notification-Type: bug X-Launchpad-Bug: product=qemu; status=New; importance=Undecided; assignee=None; X-Launchpad-Bug-Information-Type: Public X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: koalinux schoenebeck X-Launchpad-Bug-Reporter: =?utf-8?q?Jos=C3=A9_Pekkarinen_=28koalinux=29?= X-Launchpad-Bug-Modifier: =?utf-8?q?Jos=C3=A9_Pekkarinen_=28koalinux=29?= References: <160848897234.4298.12739306431901820443.malonedeb@wampee.canonical.com> Message-Id: <161415330721.7209.10377443778673632209.malone@gac.canonical.com> Subject: [Bug 1908832] Re: jack audio dev produces no sound X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml X-Launchpad-Message-For: qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="f759833f01c7f0b01b31b10cf317a55893ebb0ad"; Instance="production" X-Launchpad-Hash: 6eb3f405b273133b88754846fba356b18bb6a6fb Received-SPF: none client-ip=91.189.90.7; envelope-from=bounces@canonical.com; helo=indium.canonical.com X-Spam_score_int: -65 X-Spam_score: -6.6 X-Spam_bar: ------ X-Spam_report: (-6.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bug 1908832 <1908832@bugs.launchpad.net> Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Hi, I spend some time debugging this during the morning, I found that there is a check while connecting the ports that always exits the function without connecting the jack ports, simplifying it as in the following diff lets me build and use the audio outputs correctly in the vm: So, I wonder, what is this c->opt->connect_ports all about, is it needed, or just wrongly initialized so that it caps the port connection? Thanks! Jose. diff --git a/audio/jackaudio.c b/audio/jackaudio.c index 3b7c18443d..f417e4db8a 100644 --- a/audio/jackaudio.c +++ b/audio/jackaudio.c @@ -369,7 +369,7 @@ static size_t qjack_read(HWVoiceIn *hw, void *buf, size_t len) static void qjack_client_connect_ports(QJackClient *c) { - if (!c->connect_ports || !c->opt->connect_ports) { + if (!c->connect_ports) { return; }