Message ID | 161415330721.7209.10377443778673632209.malone@gac.canonical.com |
---|---|
State | New |
Headers | show |
Series | [Bug,1908832] Re: jack audio dev produces no sound | expand |
Patchew URL: https://patchew.org/QEMU/161415330721.7209.10377443778673632209.malone@gac.canonical.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 161415330721.7209.10377443778673632209.malone@gac.canonical.com Subject: [Bug 1908832] Re: jack audio dev produces no sound === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/161415330721.7209.10377443778673632209.malone@gac.canonical.com -> patchew/161415330721.7209.10377443778673632209.malone@gac.canonical.com Switched to a new branch 'test' ee0b5e3 jack audio dev produces no sound === OUTPUT BEGIN === ERROR: Missing Signed-off-by: line(s) total: 1 errors, 0 warnings, 8 lines checked Commit ee0b5e3dbaff (jack audio dev produces no sound) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/161415330721.7209.10377443778673632209.malone@gac.canonical.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
diff --git a/audio/jackaudio.c b/audio/jackaudio.c index 3b7c18443d..f417e4db8a 100644 --- a/audio/jackaudio.c +++ b/audio/jackaudio.c @@ -369,7 +369,7 @@ static size_t qjack_read(HWVoiceIn *hw, void *buf, size_t len) static void qjack_client_connect_ports(QJackClient *c) { - if (!c->connect_ports || !c->opt->connect_ports) { + if (!c->connect_ports) { return; }