diff mbox series

[2/3] acpi/gpex: Fix cca attribute check for pxb device

Message ID 1612490205-48788-3-git-send-email-wangxingang5@huawei.com
State New
Headers show
Series acpi: Add _CCA support for pxb devices | expand

Commit Message

Wang Xingang Feb. 5, 2021, 1:56 a.m. UTC 
From: Xingang Wang <wangxingang5@huawei.com>

When check DMA support for device attached to pxb,
the cache coherency attribute need to be set.
This add _CCA attribute for pxb DSDT.

Fixes: 6f9765fbad ("acpi/gpex: Build tables for pxb")

Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
Signed-off-by: Xingang Wang <wangxingang5@huawei.com>
---
 hw/pci-host/gpex-acpi.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Igor Mammedov Feb. 10, 2021, 2:24 p.m. UTC | #1 
On Fri, 5 Feb 2021 01:56:44 +0000
Wang Xingang <wangxingang5@huawei.com> wrote:

> From: Xingang Wang <wangxingang5@huawei.com>
> 
> When check DMA support for device attached to pxb,
> the cache coherency attribute need to be set.
> This add _CCA attribute for pxb DSDT.
> 
> Fixes: 6f9765fbad ("acpi/gpex: Build tables for pxb")
> 
> Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
> Signed-off-by: Xingang Wang <wangxingang5@huawei.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

I'm not sure about if ARM side if fine with the change, CCed.

> ---
>  hw/pci-host/gpex-acpi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/pci-host/gpex-acpi.c b/hw/pci-host/gpex-acpi.c
> index 446912d771..0f01f13a6e 100644
> --- a/hw/pci-host/gpex-acpi.c
> +++ b/hw/pci-host/gpex-acpi.c
> @@ -175,6 +175,7 @@ void acpi_dsdt_add_gpex(Aml *scope, struct GPEXConfig *cfg)
>              aml_append(dev, aml_name_decl("_BBN", aml_int(bus_num)));
>              aml_append(dev, aml_name_decl("_UID", aml_int(bus_num)));
>              aml_append(dev, aml_name_decl("_STR", aml_unicode("pxb Device")));
> +            aml_append(dev, aml_name_decl("_CCA", aml_int(1)));
>              if (numa_node != NUMA_NODE_UNASSIGNED) {
>                  aml_append(dev, aml_name_decl("_PXM", aml_int(numa_node)));
>              }
diff mbox series

Patch

diff --git a/hw/pci-host/gpex-acpi.c b/hw/pci-host/gpex-acpi.c
index 446912d771..0f01f13a6e 100644
--- a/hw/pci-host/gpex-acpi.c
+++ b/hw/pci-host/gpex-acpi.c
@@ -175,6 +175,7 @@  void acpi_dsdt_add_gpex(Aml *scope, struct GPEXConfig *cfg)
             aml_append(dev, aml_name_decl("_BBN", aml_int(bus_num)));
             aml_append(dev, aml_name_decl("_UID", aml_int(bus_num)));
             aml_append(dev, aml_name_decl("_STR", aml_unicode("pxb Device")));
+            aml_append(dev, aml_name_decl("_CCA", aml_int(1)));
             if (numa_node != NUMA_NODE_UNASSIGNED) {
                 aml_append(dev, aml_name_decl("_PXM", aml_int(numa_node)));
             }