| Message ID | 160459122012.462591.8467906402712875729.stgit@bahia.lan |
|---|---|
| State | New |
| Headers | show |
| Series | [for-5.2?,1/2] Makefile: Don't use $(quiet-@) within the body of a recipe | expand |
On 11/5/20 4:47 PM, Greg Kurz wrote: > It doesn't bring much to have echoing with "make help". Suppress it > unconditionally. > > Signed-off-by: Greg Kurz <groug@kaod.org> > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) 'make help' is not as helpful as it used to be. Still: Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On 05/11/20 16:47, Greg Kurz wrote: > It doesn't bring much to have echoing with "make help". Suppress it > unconditionally. > > Signed-off-by: Greg Kurz <groug@kaod.org> > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index df7a02a61a43..ba6b702107a5 100644 > --- a/Makefile > +++ b/Makefile > @@ -270,7 +270,7 @@ include $(SRC_PATH)/tests/docker/Makefile.include > include $(SRC_PATH)/tests/vm/Makefile.include > > print-help-run = printf " %-30s - %s\\n" "$1" "$2" > -print-help = $(quiet-@)$(call print-help-run,$1,$2) > +print-help = @$(call print-help-run,$1,$2) > > .PHONY: help > help: > > Queued, thanks (the first was already in my tree). Paolo
diff --git a/Makefile b/Makefile index df7a02a61a43..ba6b702107a5 100644 --- a/Makefile +++ b/Makefile @@ -270,7 +270,7 @@ include $(SRC_PATH)/tests/docker/Makefile.include include $(SRC_PATH)/tests/vm/Makefile.include print-help-run = printf " %-30s - %s\\n" "$1" "$2" -print-help = $(quiet-@)$(call print-help-run,$1,$2) +print-help = @$(call print-help-run,$1,$2) .PHONY: help help:
It doesn't bring much to have echoing with "make help". Suppress it unconditionally. Signed-off-by: Greg Kurz <groug@kaod.org> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)