diff mbox series

[PULL,6/6] MAINTAINERS: Add 'Performance Tools and Tests' subsection

Message ID 1593287503-25197-7-git-send-email-aleksandar.qemu.devel@gmail.com
State New
Headers show
Series [PULL,1/6] hw/mips: Implement the kvm_type() hook in MachineClass | expand

Commit Message

Aleksandar Markovic June 27, 2020, 7:51 p.m. UTC 
This commit creates a new 'Miscellaneous' section which hosts a new
'Performance Tools and Tests' subsection. This subsection will contain
the the performance scripts and benchmarks written as a part of the
'TCG Continuous Benchmarking' project. Also, it will be a placeholder
for follow-ups to this project, if any.

Signed-off-by: Ahmed Karaman <ahmedkhaledkaraman@gmail.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
Message-Id: <20200626164546.22102-4-ahmedkhaledkaraman@gmail.com>
---
 MAINTAINERS | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Comments

Philippe Mathieu-Daudé June 29, 2020, 8:13 a.m. UTC | #1 
On 6/27/20 9:51 PM, Aleksandar Markovic wrote:
> This commit creates a new 'Miscellaneous' section which hosts a new
> 'Performance Tools and Tests' subsection. This subsection will contain
> the the performance scripts and benchmarks written as a part of the
> 'TCG Continuous Benchmarking' project. Also, it will be a placeholder
> for follow-ups to this project, if any.
> 
> Signed-off-by: Ahmed Karaman <ahmedkhaledkaraman@gmail.com>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> Message-Id: <20200626164546.22102-4-ahmedkhaledkaraman@gmail.com>
> ---
>  MAINTAINERS | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fe925ea..dec252f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1096,11 +1096,10 @@ F: hw/isa/vt82c686.c
>  F: hw/pci-host/bonito.c
>  F: include/hw/isa/vt82c686.h
>  
> -Loongson-3 Virtual Platform
> +Loongson-3 virtual platforms
>  M: Huacai Chen <chenhc@lemote.com>
>  R: Jiaxun Yang <jiaxun.yang@flygoat.com>
>  S: Maintained
> -F: hw/mips/loongson3_virt.c

Ah, now I see, here you unlist the uncommited file.

It might be easier to manage sending 2 different pull requests,
on for MIPS and one for the performance tools.

>  F: hw/intc/loongson_liointc.c
>  
>  Boston
> @@ -3026,3 +3025,10 @@ M: Peter Maydell <peter.maydell@linaro.org>
>  S: Maintained
>  F: docs/conf.py
>  F: docs/*/conf.py
> +
> +Miscellaneous
> +-------------
> +Performance Tools and Tests
> +M: Ahmed Karaman <ahmedkhaledkaraman@gmail.com>

Aleksandar, don't you want to be listed here with Ahmed?

> +S: Maintained
> +F: scripts/performance/
>
Aleksandar Markovic June 29, 2020, 10:28 a.m. UTC | #2 
понедељак, 29. јун 2020., Philippe Mathieu-Daudé <f4bug@amsat.org> је
написао/ла:

> On 6/27/20 9:51 PM, Aleksandar Markovic wrote:
> > This commit creates a new 'Miscellaneous' section which hosts a new
> > 'Performance Tools and Tests' subsection. This subsection will contain
> > the the performance scripts and benchmarks written as a part of the
> > 'TCG Continuous Benchmarking' project. Also, it will be a placeholder
> > for follow-ups to this project, if any.
> >
> > Signed-off-by: Ahmed Karaman <ahmedkhaledkaraman@gmail.com>
> > Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> > Reviewed-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> > Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> > Message-Id: <20200626164546.22102-4-ahmedkhaledkaraman@gmail.com>
> > ---
> >  MAINTAINERS | 10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index fe925ea..dec252f 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1096,11 +1096,10 @@ F: hw/isa/vt82c686.c
> >  F: hw/pci-host/bonito.c
> >  F: include/hw/isa/vt82c686.h
> >
> > -Loongson-3 Virtual Platform
> > +Loongson-3 virtual platforms
> >  M: Huacai Chen <chenhc@lemote.com>
> >  R: Jiaxun Yang <jiaxun.yang@flygoat.com>
> >  S: Maintained
> > -F: hw/mips/loongson3_virt.c
>
> Ah, now I see, here you unlist the uncommited file.
>
>
This file/machine, for multiple reasons, will not be accepted in 5.1. The
end user will not be able to see, let alone use the machine in question in
5.1. This is on purpose.

This will give enough development time to Huacai to implement missing bits
and pieces, and to possibly improve the whole idea during 5.2 development
cycle.

Even though the support that Huacai introduced in 5.1 is, for many reasons,
not completed, and even though Huacai and I had at times opposing views and
fierce discussions and disagreements - I salute and support his work, and
consider it, by far, the best and the most important contribution to QEMU
for MIPS in years.



> It might be easier to manage sending 2 different pull requests,
> on for MIPS and one for the performance tools.
>
> >  F: hw/intc/loongson_liointc.c
> >
> >  Boston
> > @@ -3026,3 +3025,10 @@ M: Peter Maydell <peter.maydell@linaro.org>
> >  S: Maintained
> >  F: docs/conf.py
> >  F: docs/*/conf.py
> > +
> > +Miscellaneous
> > +-------------
> > +Performance Tools and Tests
> > +M: Ahmed Karaman <ahmedkhaledkaraman@gmail.com>
>
> Aleksandar, don't you want to be listed here with Ahmed?
>
>
Of course not. The project is student's. The mentor just helps and leads
the student. The fruits of the project belong to the community and to the
student - and not to the mentor.

If you were the mentor, my impression is that you would leave your name in
MAINTAINERS whenever you see the slightest opportunity (I remember an
occasion where you were saying "I worked six hours on this" and then
proposing yourself as the maitainer for a particular segment (??)). I don't
have such approach, and I oppose your approach, and I appeal to you to
control your apetite for maintainership.

Regards,
Aleksandar



> > +S: Maintained
> > +F: scripts/performance/
> >
>
>
Philippe Mathieu-Daudé July 1, 2020, 10:32 a.m. UTC | #3 
On 6/29/20 12:28 PM, Aleksandar Markovic wrote:
> понедељак, 29. јун 2020., Philippe Mathieu-Daudé <f4bug@amsat.org
> <mailto:f4bug@amsat.org>> је написао/ла:
> 
>     On 6/27/20 9:51 PM, Aleksandar Markovic wrote:
>     > This commit creates a new 'Miscellaneous' section which hosts a new
>     > 'Performance Tools and Tests' subsection. This subsection will contain
>     > the the performance scripts and benchmarks written as a part of the
>     > 'TCG Continuous Benchmarking' project. Also, it will be a placeholder
>     > for follow-ups to this project, if any.
>     >
>     > Signed-off-by: Ahmed Karaman <ahmedkhaledkaraman@gmail.com
>     <mailto:ahmedkhaledkaraman@gmail.com>>
>     > Reviewed-by: Alex Bennée <alex.bennee@linaro.org
>     <mailto:alex.bennee@linaro.org>>
>     > Reviewed-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com
>     <mailto:aleksandar.qemu.devel@gmail.com>>
>     > Signed-off-by: Aleksandar Markovic
>     <aleksandar.qemu.devel@gmail.com
>     <mailto:aleksandar.qemu.devel@gmail.com>>
>     > Message-Id: <20200626164546.22102-4-ahmedkhaledkaraman@gmail.com
>     <mailto:20200626164546.22102-4-ahmedkhaledkaraman@gmail.com>>
>     > ---
>     >  MAINTAINERS | 10 ++++++++--
>     >  1 file changed, 8 insertions(+), 2 deletions(-)
>     >
>     > diff --git a/MAINTAINERS b/MAINTAINERS
>     > index fe925ea..dec252f 100644
>     > --- a/MAINTAINERS
>     > +++ b/MAINTAINERS
>     > @@ -1096,11 +1096,10 @@ F: hw/isa/vt82c686.c
>     >  F: hw/pci-host/bonito.c
>     >  F: include/hw/isa/vt82c686.h
>     > 
>     > -Loongson-3 Virtual Platform
>     > +Loongson-3 virtual platforms
>     >  M: Huacai Chen <chenhc@lemote.com <mailto:chenhc@lemote.com>>
>     >  R: Jiaxun Yang <jiaxun.yang@flygoat.com
>     <mailto:jiaxun.yang@flygoat.com>>
>     >  S: Maintained
>     > -F: hw/mips/loongson3_virt.c
> 
>     Ah, now I see, here you unlist the uncommited file.
> 
> 
> This file/machine, for multiple reasons, will not be accepted in 5.1.

Ah, so that confirms we have to revert commit c012e0b1f9 ("hw/intc: Add
Loongson LIOINTC support"). Can you send a patch please?

> The end user will not be able to see, let alone use the machine in
> question in 5.1. This is on purpose.
> 
> This will give enough development time to Huacai to implement missing
> bits and pieces, and to possibly improve the whole idea during 5.2
> development cycle.

Sounds reasonable.

> 
> Even though the support that Huacai introduced in 5.1 is, for many
> reasons, not completed, and even though Huacai and I had at times
> opposing views and fierce discussions and disagreements - I salute and
> support his work, and consider it, by far, the best and the most
> important contribution to QEMU for MIPS in years.
> 
>  
> 
>     It might be easier to manage sending 2 different pull requests,
>     on for MIPS and one for the performance tools.
> 
>     >  F: hw/intc/loongson_liointc.c
>     > 
>     >  Boston
>     > @@ -3026,3 +3025,10 @@ M: Peter Maydell <peter.maydell@linaro.org
>     <mailto:peter.maydell@linaro.org>>
>     >  S: Maintained
>     >  F: docs/conf.py
>     >  F: docs/*/conf.py
>     > +
>     > +Miscellaneous
>     > +-------------
>     > +Performance Tools and Tests
>     > +M: Ahmed Karaman <ahmedkhaledkaraman@gmail.com
>     <mailto:ahmedkhaledkaraman@gmail.com>>
> 
>     Aleksandar, don't you want to be listed here with Ahmed?
> 
> 
> Of course not. The project is student's. The mentor just helps and leads
> the student. The fruits of the project belong to the community and to
> the student - and not to the mentor.
> 
> If you were the mentor, my impression is that you would leave your name
> in MAINTAINERS whenever you see the slightest opportunity (I remember an
> occasion where you were saying "I worked six hours on this" and then
> proposing yourself as the maitainer for a particular segment (??)).

'??' means you are not sure? Please link reference to discussions.
I volunteered to help maintaining areas when nobody were doing anything,
if that forces others to step in because they are more qualified, I'm
glad I did it. See for example the Renesas ports have qualified
maintainers!

> I
> don't have such approach, and I oppose your approach, and I appeal to
> you to control your apetite for maintainership.

I am not looking for more maintenance, I'm looking to cover abandonned
areas I use. I have been taught by the do-ocracy principle. I'v not been
dropped in as replacement for someone else position, only trying to keep
things unmodified, scared a minimal change would break.

> 
> Regards,
> Aleksandar
> 
>  
> 
>     > +S: Maintained
>     > +F: scripts/performance/
>     >
>
Philippe Mathieu-Daudé July 1, 2020, 10:49 a.m. UTC | #4 
On 7/1/20 12:32 PM, Philippe Mathieu-Daudé wrote:
> On 6/29/20 12:28 PM, Aleksandar Markovic wrote:
>> понедељак, 29. јун 2020., Philippe Mathieu-Daudé <f4bug@amsat.org
>> <mailto:f4bug@amsat.org>> је написао/ла:
>>
>>     On 6/27/20 9:51 PM, Aleksandar Markovic wrote:
>>     > This commit creates a new 'Miscellaneous' section which hosts a new
>>     > 'Performance Tools and Tests' subsection. This subsection will contain
>>     > the the performance scripts and benchmarks written as a part of the
>>     > 'TCG Continuous Benchmarking' project. Also, it will be a placeholder
>>     > for follow-ups to this project, if any.
>>     >
>>     > Signed-off-by: Ahmed Karaman <ahmedkhaledkaraman@gmail.com
>>     <mailto:ahmedkhaledkaraman@gmail.com>>
>>     > Reviewed-by: Alex Bennée <alex.bennee@linaro.org
>>     <mailto:alex.bennee@linaro.org>>
>>     > Reviewed-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com
>>     <mailto:aleksandar.qemu.devel@gmail.com>>
>>     > Signed-off-by: Aleksandar Markovic
>>     <aleksandar.qemu.devel@gmail.com
>>     <mailto:aleksandar.qemu.devel@gmail.com>>
>>     > Message-Id: <20200626164546.22102-4-ahmedkhaledkaraman@gmail.com
>>     <mailto:20200626164546.22102-4-ahmedkhaledkaraman@gmail.com>>
>>     > ---
>>     >  MAINTAINERS | 10 ++++++++--
>>     >  1 file changed, 8 insertions(+), 2 deletions(-)
>>     >
>>     > diff --git a/MAINTAINERS b/MAINTAINERS
>>     > index fe925ea..dec252f 100644
>>     > --- a/MAINTAINERS
>>     > +++ b/MAINTAINERS
>>     > @@ -1096,11 +1096,10 @@ F: hw/isa/vt82c686.c
>>     >  F: hw/pci-host/bonito.c
>>     >  F: include/hw/isa/vt82c686.h
>>     > 
>>     > -Loongson-3 Virtual Platform
>>     > +Loongson-3 virtual platforms
>>     >  M: Huacai Chen <chenhc@lemote.com <mailto:chenhc@lemote.com>>
>>     >  R: Jiaxun Yang <jiaxun.yang@flygoat.com
>>     <mailto:jiaxun.yang@flygoat.com>>
>>     >  S: Maintained
>>     > -F: hw/mips/loongson3_virt.c
>>
>>     Ah, now I see, here you unlist the uncommited file.
>>
>>
>> This file/machine, for multiple reasons, will not be accepted in 5.1.
> 
> Ah, so that confirms we have to revert commit c012e0b1f9 ("hw/intc: Add
> Loongson LIOINTC support"). Can you send a patch please?
> 
>> The end user will not be able to see, let alone use the machine in
>> question in 5.1. This is on purpose.
>>
>> This will give enough development time to Huacai to implement missing
>> bits and pieces, and to possibly improve the whole idea during 5.2
>> development cycle.
> 
> Sounds reasonable.
> 
>>
>> Even though the support that Huacai introduced in 5.1 is, for many
>> reasons, not completed, and even though Huacai and I had at times
>> opposing views and fierce discussions and disagreements - I salute and
>> support his work, and consider it, by far, the best and the most
>> important contribution to QEMU for MIPS in years.
>>
>>  
>>
>>     It might be easier to manage sending 2 different pull requests,
>>     on for MIPS and one for the performance tools.
>>
>>     >  F: hw/intc/loongson_liointc.c
>>     > 
>>     >  Boston
>>     > @@ -3026,3 +3025,10 @@ M: Peter Maydell <peter.maydell@linaro.org
>>     <mailto:peter.maydell@linaro.org>>
>>     >  S: Maintained
>>     >  F: docs/conf.py
>>     >  F: docs/*/conf.py
>>     > +
>>     > +Miscellaneous
>>     > +-------------
>>     > +Performance Tools and Tests
>>     > +M: Ahmed Karaman <ahmedkhaledkaraman@gmail.com
>>     <mailto:ahmedkhaledkaraman@gmail.com>>
>>
>>     Aleksandar, don't you want to be listed here with Ahmed?
>>
>>
>> Of course not. The project is student's. The mentor just helps and leads
>> the student. The fruits of the project belong to the community and to
>> the student - and not to the mentor.
>>
>> If you were the mentor, my impression is that you would leave your name
>> in MAINTAINERS whenever you see the slightest opportunity (I remember an
>> occasion where you were saying "I worked six hours on this" and then
>> proposing yourself as the maitainer for a particular segment (??)).
> 
> '??' means you are not sure? Please link reference to discussions.
> I volunteered to help maintaining areas when nobody were doing anything,
> if that forces others to step in because they are more qualified, I'm
> glad I did it. See for example the Renesas ports have qualified
> maintainers!
> 
>> I
>> don't have such approach, and I oppose your approach, and I appeal to
>> you to control your apetite for maintainership.

Now I understand your comment here:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg711448.html

"I guess it is just a matter of time Philippe would ask for SPARC
 maintainership. Mark, would you perhaps accept Philippe as a
 co-maintainer?"

It was not ironic, it was a trap. I already asked you why you keep
tracking my contributions, trying to demotivate me. Is this personal?

> 
> I am not looking for more maintenance, I'm looking to cover abandonned
> areas I use. I have been taught by the do-ocracy principle. I'v not been
> dropped in as replacement for someone else position, only trying to keep
> things unmodified, scared a minimal change would break.
> 
>>
>> Regards,
>> Aleksandar
>>
>>  
>>
>>     > +S: Maintained
>>     > +F: scripts/performance/
>>     >
>>
>
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index fe925ea..dec252f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1096,11 +1096,10 @@  F: hw/isa/vt82c686.c
 F: hw/pci-host/bonito.c
 F: include/hw/isa/vt82c686.h
 
-Loongson-3 Virtual Platform
+Loongson-3 virtual platforms
 M: Huacai Chen <chenhc@lemote.com>
 R: Jiaxun Yang <jiaxun.yang@flygoat.com>
 S: Maintained
-F: hw/mips/loongson3_virt.c
 F: hw/intc/loongson_liointc.c
 
 Boston
@@ -3026,3 +3025,10 @@  M: Peter Maydell <peter.maydell@linaro.org>
 S: Maintained
 F: docs/conf.py
 F: docs/*/conf.py
+
+Miscellaneous
+-------------
+Performance Tools and Tests
+M: Ahmed Karaman <ahmedkhaledkaraman@gmail.com>
+S: Maintained
+F: scripts/performance/