Message ID | 1592289944-13727-1-git-send-email-jasowang@redhat.com |
---|---|
State | New |
Headers | show |
On Tue, 16 Jun 2020 at 07:45, Jason Wang <jasowang@redhat.com> wrote: > > The following changes since commit 7d3660e79830a069f1848bb4fa1cdf8f666424fb: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2020-06-12 23:06:22 +0100) > > are available in the git repository at: > > https://github.com/jasowang/qemu.git tags/net-pull-request > > for you to fetch changes up to 955aab203f932b8a7c23ff9c58ba036997cb3ed8: > > net: Drop the NetLegacy structure, always use Netdev instead (2020-06-16 14:40:40 +0800) > > ---------------------------------------------------------------- > > ---------------------------------------------------------------- Hi; I'm afraid this fails to build (all hosts): hw/net/virtio-net.o: In function `virtio_net_device_realize': /home/pm215/qemu/hw/net/virtio-net.c:3380: undefined reference to `net_rx_pkt_init' hw/net/virtio-net.o: In function `virtio_net_device_unrealize': /home/pm215/qemu/hw/net/virtio-net.c:3418: undefined reference to `net_rx_pkt_uninit' hw/net/virtio-net.o: In function `virtio_net_process_rss': /home/pm215/qemu/hw/net/virtio-net.c:1607: undefined reference to `net_rx_pkt_set_protocols' /home/pm215/qemu/hw/net/virtio-net.c:1609: undefined reference to `net_rx_pkt_get_protocols' /home/pm215/qemu/hw/net/virtio-net.c:1625: undefined reference to `net_rx_pkt_calc_rss_hash' /home/pm215/qemu/hw/net/virtio-net.c:1613: undefined reference to `net_rx_pkt_get_ip6_info' /home/pm215/qemu/hw/net/virtio-net.c:1610: undefined reference to `net_rx_pkt_get_ip4_info' collect2: error: ld returned 1 exit status thanks -- PMM
On 2020/6/16 下午8:32, Peter Maydell wrote: > On Tue, 16 Jun 2020 at 07:45, Jason Wang <jasowang@redhat.com> wrote: >> The following changes since commit 7d3660e79830a069f1848bb4fa1cdf8f666424fb: >> >> Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2020-06-12 23:06:22 +0100) >> >> are available in the git repository at: >> >> https://github.com/jasowang/qemu.git tags/net-pull-request >> >> for you to fetch changes up to 955aab203f932b8a7c23ff9c58ba036997cb3ed8: >> >> net: Drop the NetLegacy structure, always use Netdev instead (2020-06-16 14:40:40 +0800) >> >> ---------------------------------------------------------------- >> >> ---------------------------------------------------------------- > Hi; I'm afraid this fails to build (all hosts): > > hw/net/virtio-net.o: In function `virtio_net_device_realize': > /home/pm215/qemu/hw/net/virtio-net.c:3380: undefined reference to > `net_rx_pkt_init' > hw/net/virtio-net.o: In function `virtio_net_device_unrealize': > /home/pm215/qemu/hw/net/virtio-net.c:3418: undefined reference to > `net_rx_pkt_uninit' > hw/net/virtio-net.o: In function `virtio_net_process_rss': > /home/pm215/qemu/hw/net/virtio-net.c:1607: undefined reference to > `net_rx_pkt_set_protocols' > /home/pm215/qemu/hw/net/virtio-net.c:1609: undefined reference to > `net_rx_pkt_get_protocols' > /home/pm215/qemu/hw/net/virtio-net.c:1625: undefined reference to > `net_rx_pkt_calc_rss_hash' > /home/pm215/qemu/hw/net/virtio-net.c:1613: undefined reference to > `net_rx_pkt_get_ip6_info' > /home/pm215/qemu/hw/net/virtio-net.c:1610: undefined reference to > `net_rx_pkt_get_ip4_info' > collect2: error: ld returned 1 exit status > > thanks > -- PMM > Sorry for the failure. This is because net_rx_pkt.c and net_tx_pkt.c are not complied when CONFIG_VIRTIO_NET is set. And it may work by chance if E1000E and VMXNET3 is enabled which is the case I test. Will send V2. Thanks