| Message ID | 1580306781-228371-1-git-send-email-imammedo@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | acpi: cpuhp: document CPHP_GET_CPU_ID_CMD command | expand |
On 01/29/20 15:06, Igor Mammedov wrote: > Commit 3a61c8db9d25 introduced CPHP_GET_CPU_ID_CMD command but > did not sufficiently describe it. Fix it by adding missing command > documentation. > > Fixes: 3a61c8db9d25 ("acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command") > Signed-off-by: Igor Mammedov <imammedo@redhat.com> > Reviewed-by: Laszlo Ersek <lersek@redhat.com> > --- > docs/specs/acpi_cpu_hotplug.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/docs/specs/acpi_cpu_hotplug.txt b/docs/specs/acpi_cpu_hotplug.txt > index a8ce5e7..9bb22d1 100644 > --- a/docs/specs/acpi_cpu_hotplug.txt > +++ b/docs/specs/acpi_cpu_hotplug.txt > @@ -94,6 +94,8 @@ write access: > register in QEMU > 2: following writes to 'Command data' register set OST status > register in QEMU > + 3: following reads from 'Command data' and 'Command data 2' return > + architecture specific CPU ID value for currently selected CPU. > other values: reserved > [0x6-0x7] reserved > [0x8] Command data: (DWORD access) > Thanks!
Michael, On 01/29/20 15:06, Igor Mammedov wrote: > Commit 3a61c8db9d25 introduced CPHP_GET_CPU_ID_CMD command but > did not sufficiently describe it. Fix it by adding missing command > documentation. > > Fixes: 3a61c8db9d25 ("acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command") > Signed-off-by: Igor Mammedov <imammedo@redhat.com> > Reviewed-by: Laszlo Ersek <lersek@redhat.com> > --- > docs/specs/acpi_cpu_hotplug.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/docs/specs/acpi_cpu_hotplug.txt b/docs/specs/acpi_cpu_hotplug.txt > index a8ce5e7..9bb22d1 100644 > --- a/docs/specs/acpi_cpu_hotplug.txt > +++ b/docs/specs/acpi_cpu_hotplug.txt > @@ -94,6 +94,8 @@ write access: > register in QEMU > 2: following writes to 'Command data' register set OST status > register in QEMU > + 3: following reads from 'Command data' and 'Command data 2' return > + architecture specific CPU ID value for currently selected CPU. > other values: reserved > [0x6-0x7] reserved > [0x8] Command data: (DWORD access) > can you please merge this? It's a docs patch, but 3a61c8db9d25 (noted in "Fixes:") had gone in through your tree. Thank you! Laszlo
On Wed, Feb 12, 2020 at 11:27:34PM +0100, Laszlo Ersek wrote: > Michael, > > On 01/29/20 15:06, Igor Mammedov wrote: > > Commit 3a61c8db9d25 introduced CPHP_GET_CPU_ID_CMD command but > > did not sufficiently describe it. Fix it by adding missing command > > documentation. > > > > Fixes: 3a61c8db9d25 ("acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command") > > Signed-off-by: Igor Mammedov <imammedo@redhat.com> > > Reviewed-by: Laszlo Ersek <lersek@redhat.com> > > --- > > docs/specs/acpi_cpu_hotplug.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/docs/specs/acpi_cpu_hotplug.txt b/docs/specs/acpi_cpu_hotplug.txt > > index a8ce5e7..9bb22d1 100644 > > --- a/docs/specs/acpi_cpu_hotplug.txt > > +++ b/docs/specs/acpi_cpu_hotplug.txt > > @@ -94,6 +94,8 @@ write access: > > register in QEMU > > 2: following writes to 'Command data' register set OST status > > register in QEMU > > + 3: following reads from 'Command data' and 'Command data 2' return > > + architecture specific CPU ID value for currently selected CPU. > > other values: reserved > > [0x6-0x7] reserved > > [0x8] Command data: (DWORD access) > > > > can you please merge this? > > It's a docs patch, but 3a61c8db9d25 (noted in "Fixes:") had gone in > through your tree. > > Thank you! > Laszlo Will do, thanks!
diff --git a/docs/specs/acpi_cpu_hotplug.txt b/docs/specs/acpi_cpu_hotplug.txt index a8ce5e7..9bb22d1 100644 --- a/docs/specs/acpi_cpu_hotplug.txt +++ b/docs/specs/acpi_cpu_hotplug.txt @@ -94,6 +94,8 @@ write access: register in QEMU 2: following writes to 'Command data' register set OST status register in QEMU + 3: following reads from 'Command data' and 'Command data 2' return + architecture specific CPU ID value for currently selected CPU. other values: reserved [0x6-0x7] reserved [0x8] Command data: (DWORD access)
Commit 3a61c8db9d25 introduced CPHP_GET_CPU_ID_CMD command but did not sufficiently describe it. Fix it by adding missing command documentation. Fixes: 3a61c8db9d25 ("acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command") Signed-off-by: Igor Mammedov <imammedo@redhat.com> Reviewed-by: Laszlo Ersek <lersek@redhat.com> --- docs/specs/acpi_cpu_hotplug.txt | 2 ++ 1 file changed, 2 insertions(+)