Message ID | 1563766100248.83249@bt.com |
---|---|
State | New |
Headers | show |
Series | configure: Define target access alignment in configure | expand |
Hi, Tony On Mon, Jul 22, 2019 at 5:28 AM <tony.nguyen@bt.com> wrote: > Signed-off-by: Tony Nguyen <tony.nguyen@bt.com> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 8316a16..c07687c 100755 > --- a/configure > +++ b/configure > @@ -7433,7 +7433,7 @@ esac > target_bigendian="no" > case "$target_name" in > > armeb|aarch64_be|hppa|lm32|m68k|microblaze|mips|mipsn32|mips64|moxie|or1k|ppc|ppc64|ppc64abi32|s390x|sh4eb|sparc|sparc64|sparc32plus|xtensaeb) > - target_bigendian=yes > + target_bigendian="yes" > ;; > esac > target_softmmu="no" > -- > 1.8.3.1 > > But, there are loads of similar cases (see 'grep "=yes" configure' output) - what do we do to them? Perhaps not all should be corrected in a similar way, but it looks to me that we should not limit this patch to just an individual case. If we do the cleanup, let's do it to be complete or almost complete. The same, of course, goes for "=no", and other variable assignments. Yours, Aleksandar $ grep "=yes" configure export CCACHE_RECACHE=yes git_update=yes --help|-h) show_help=yes --enable-git-update) git_update=yes --enable-debug-mutex) debug_mutex=yes --enable-libpmem) libpmem=yes *"-softmmu "*) softmmu=yes have_broken_size_max=yes l2tpv3=yes test "$vhost_user" = "" && vhost_user=yes test "$vhost_net_user" = "yes" && vhost_net=yes test "$vhost_kernel" = "yes" && vhost_net=yes xen=yes xen=yes xen=yes xen=yes xen=yes xen=yes xen=yes xen=yes xen=yes xen_pci_passthrough=yes sparse=yes have_x11=yes need_x11=yes gcrypt_hmac=yes tasn1=yes auth_pam=yes have_ifaddrs_h=yes sdl=yes sdl_image=yes need_x11=yes vnc_sasl=yes vnc_jpeg=yes vnc_png=yes xkbcommon=yes vde=yes netmap=yes cap_ng=yes brlapi=yes iconv_found=yes iconv=yes curses_found=yes curses=yes curl=yes bluez=yes gio=yes mpathpersist=yes mpathpersist_new_api=yes mpathpersist=yes cap=yes pthread=yes pthread=yes found=yes pthread_setname_np_w_tid=yes pthread_setname_np_wo_tid=yes rbd=yes libssh=yes linux_aio=yes tpm=yes attr=yes attr=yes libattr=yes iovec=yes preadv=yes fdt_required=yes fdt=yes opengl=yes opengl_dmabuf=yes need_x11=yes inotify=yes inotify1=yes pipe2=yes accept4=yes splice=yes numa=yes signalfd=yes optreset=yes eventfd=yes memfd=yes have_usbfs=yes fallocate=yes fallocate_punch_hole=yes fallocate_zero_range=yes posix_fallocate=yes sync_file_range=yes fiemap=yes dup3=yes ppoll=yes prctl_pr_set_timerslack=yes epoll=yes epoll_create1=yes sendfile=yes timerfd=yes setns=yes clock_adjtime=yes syncfs=yes docs=yes byteswap_h=yes bswap_h=yes guest_agent_ntddscsi=yes fdatasync=yes madvise=yes posix_madvise=yes posix_memalign=yes posix_syslog=yes sem_timedwait=yes strchrnul=yes ucontext_works=yes coroutine_pool=yes open_by_handle_at=yes linux_magic_h=yes pragma_diagnostic_available=yes valgrind_h=yes has_environ=yes cpuid_h=yes int128=yes atomic128=yes cmpxchg128=yes atomic64=yes vector16=yes getauxval=yes ccache_cpp2=yes have_copy_file_range=yes have_fsxattr=yes have_membarrier=yes have_membarrier=yes have_rtnetlink=yes have_af_vsock=yes have_afalg=yes have_sysmacros=yes vxhs=yes have_static_assert=yes have_utmpx=yes have_getrandom=yes have_asan=yes have_ubsan=yes have_asan_iface_h=yes have_asan_iface_fiber=yes ivshmem=yes virtfs=yes mpath=yes guest_agent=yes guest_agent_msi=yes echo "QEMU_GA_MSI_ENABLED=yes" >> $config_host_mak echo "BUILD_DOCS=yes" >> $config_host_mak echo "INSTALL_BLOBS=yes" >> $config_host_mak target_bigendian=yes mttcg=yes mttcg=yes mttcg=yes mttcg=yes mttcg=yes
diff --git a/configure b/configure index 8316a16..c07687c 100755 --- a/configure +++ b/configure @@ -7433,7 +7433,7 @@ esac target_bigendian="no" case "$target_name" in armeb|aarch64_be|hppa|lm32|m68k|microblaze|mips|mipsn32|mips64|moxie|or1k|ppc|ppc64|ppc64abi32|s390x|sh4eb|sparc|sparc64|sparc32plus|xtensaeb) - target_bigendian=yes + target_bigendian="yes" ;; esac target_softmmu="no"
Signed-off-by: Tony Nguyen <tony.nguyen@bt.com> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)