diff mbox series

target/mips: Add implementation of DSPRAM

Message ID 1559828732-23081-2-git-send-email-mateja.marjanovic@rt-rk.com
State New
Headers show
Series target/mips: Add implementation of DSPRAM | expand

Commit Message

Mateja Marjanovic June 6, 2019, 1:45 p.m. UTC
From: Mateja Marjanovic <Mateja.Marjanovic@rt-rk.com>

Add support for DSPRAM (Data Scratch Pad RAM). It still needs
some minor fixing, but the structure is right.

Signed-off-by: Mateja Marjanovic <mateja.marjanovic@rt-rk.com>
---
 default-configs/mips-softmmu-common.mak |   1 +
 hw/mips/cps.c                           |  28 +++++-
 hw/misc/Makefile.objs                   |   1 +
 hw/misc/mips_dspram.c                   | 153 ++++++++++++++++++++++++++++++++
 include/hw/mips/cps.h                   |   2 +
 include/hw/misc/mips_dspram.h           |  46 ++++++++++
 target/mips/cpu.h                       |   9 +-
 target/mips/internal.h                  |   3 +-
 target/mips/op_helper.c                 |  14 +++
 target/mips/translate.c                 |   8 ++
 target/mips/translate_init.inc.c        |   2 +
 11 files changed, 262 insertions(+), 5 deletions(-)
 create mode 100644 hw/misc/mips_dspram.c
 create mode 100644 include/hw/misc/mips_dspram.h

Comments

Aleksandar Markovic June 8, 2019, 5:32 a.m. UTC | #1
On Jun 6, 2019 3:49 PM, "Mateja Marjanovic" <mateja.marjanovic@rt-rk.com>
wrote:
>
> From: Mateja Marjanovic <Mateja.Marjanovic@rt-rk.com>
>
> Add support for DSPRAM (Data Scratch Pad RAM). It still needs
> some minor fixing, but the structure is right.
>
> Signed-off-by: Mateja Marjanovic <mateja.marjanovic@rt-rk.com>
> ---

Please consider splitting the patch into several logical units.

Adding Philippe.

Thanks,
Aleksandar

>  default-configs/mips-softmmu-common.mak |   1 +
>  hw/mips/cps.c                           |  28 +++++-
>  hw/misc/Makefile.objs                   |   1 +
>  hw/misc/mips_dspram.c                   | 153
++++++++++++++++++++++++++++++++
>  include/hw/mips/cps.h                   |   2 +
>  include/hw/misc/mips_dspram.h           |  46 ++++++++++
>  target/mips/cpu.h                       |   9 +-
>  target/mips/internal.h                  |   3 +-
>  target/mips/op_helper.c                 |  14 +++
>  target/mips/translate.c                 |   8 ++
>  target/mips/translate_init.inc.c        |   2 +
>  11 files changed, 262 insertions(+), 5 deletions(-)
>  create mode 100644 hw/misc/mips_dspram.c
>  create mode 100644 include/hw/misc/mips_dspram.h
>
> diff --git a/default-configs/mips-softmmu-common.mak
b/default-configs/mips-softmmu-common.mak
> index ded7498..d3f85b0 100644
> --- a/default-configs/mips-softmmu-common.mak
> +++ b/default-configs/mips-softmmu-common.mak
> @@ -35,6 +35,7 @@ CONFIG_ISA_TESTDEV=y
>  CONFIG_EMPTY_SLOT=y
>  CONFIG_MIPS_CPS=y
>  CONFIG_MIPS_ITU=y
> +CONFIG_MIPS_DSPRAM=y
>  CONFIG_I2C=y
>  CONFIG_R4K=y
>  CONFIG_MALTA=y
> diff --git a/hw/mips/cps.c b/hw/mips/cps.c
> index fc97f59..0205556 100644
> --- a/hw/mips/cps.c
> +++ b/hw/mips/cps.c
> @@ -90,7 +90,8 @@ static void mips_cps_realize(DeviceState *dev, Error
**errp)
>
>      cpu = MIPS_CPU(first_cpu);
>      env = &cpu->env;
> -    saar_present = (bool)env->saarp;
> +    saar_present = env->saarp;
> +    bool dspram_present = env->dspramp;
>
>      /* Inter-Thread Communication Unit */
>      if (itu_present) {
> @@ -102,7 +103,8 @@ static void mips_cps_realize(DeviceState *dev, Error
**errp)
>          object_property_set_bool(OBJECT(&s->itu), saar_present,
"saar-present",
>                                   &err);
>          if (saar_present) {
> -            qdev_prop_set_ptr(DEVICE(&s->itu), "saar", (void
*)&env->CP0_SAAR);
> +            qdev_prop_set_ptr(DEVICE(&s->itu), "saar",
> +                              (void *) &env->CP0_SAAR[0]);
>          }
>          object_property_set_bool(OBJECT(&s->itu), true, "realized",
&err);
>          if (err != NULL) {
> @@ -113,6 +115,28 @@ static void mips_cps_realize(DeviceState *dev, Error
**errp)
>          memory_region_add_subregion(&s->container, 0,
>
sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->itu), 0));
>      }
> +    env->dspram = g_new0(MIPSDSPRAMState, 1);
> +
> +    /* Data Scratch Pad RAM */
> +    if (dspram_present) {
> +        if (!saar_present) {
> +            error_report("%s: DSPRAM requires SAAR registers", __func__);
> +            return;
> +        }
> +        object_initialize(&s->dspram, sizeof(MIPSDSPRAMState),
> +                          TYPE_MIPS_DSPRAM);
> +        qdev_set_parent_bus(DEVICE(&s->dspram), sysbus_get_default());
> +        qdev_prop_set_ptr(DEVICE(&s->dspram), "saar",
> +                          &env->CP0_SAAR[1]);
> +        object_property_set_bool(OBJECT(&s->dspram), true, "realized",
&err);
> +        if (err != NULL) {
> +            error_report("%s: DSPRAM initialisation failed", __func__);
> +            error_propagate(errp, err);
> +            return;
> +        }
> +        memory_region_add_subregion(&s->container, 0,
> +                    sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->dspram),
0));
> +    }
>
>      /* Cluster Power Controller */
>      object_initialize(&s->cpc, sizeof(s->cpc), TYPE_MIPS_CPC);
> diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs
> index 74c91d2..37c4108 100644
> --- a/hw/misc/Makefile.objs
> +++ b/hw/misc/Makefile.objs
> @@ -60,6 +60,7 @@ obj-$(CONFIG_STM32F2XX_SYSCFG) += stm32f2xx_syscfg.o
>  obj-$(CONFIG_MIPS_CPS) += mips_cmgcr.o
>  obj-$(CONFIG_MIPS_CPS) += mips_cpc.o
>  obj-$(CONFIG_MIPS_ITU) += mips_itu.o
> +obj-$(CONFIG_MIPS_DSPRAM) += mips_dspram.o
>  obj-$(CONFIG_MPS2_FPGAIO) += mps2-fpgaio.o
>  obj-$(CONFIG_MPS2_SCC) += mps2-scc.o
>
> diff --git a/hw/misc/mips_dspram.c b/hw/misc/mips_dspram.c
> new file mode 100644
> index 0000000..9bc155b
> --- /dev/null
> +++ b/hw/misc/mips_dspram.c
> @@ -0,0 +1,153 @@
> +/*
> + * Data Scratch Pad RAM
> + *
> + * Copyright (c) 2017 Imagination Technologies
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with this library; if not, see <
http://www.gnu.org/licenses/>.
> + */
> +
> +#include "qemu/osdep.h"
> +#include "qapi/error.h"
> +#include "cpu.h"
> +#include "qemu/log.h"
> +#include "exec/exec-all.h"
> +#include "hw/hw.h"
> +#include "hw/sysbus.h"
> +#include "sysemu/sysemu.h"
> +#include "hw/misc/mips_dspram.h"
> +
> +static void raise_exception(int excp)
> +{
> +    current_cpu->exception_index = excp;
> +    cpu_loop_exit(current_cpu);
> +}
> +
> +static uint64_t dspram_read(void *opaque, hwaddr addr, unsigned size)
> +{
> +    MIPSDSPRAMState *s = (MIPSDSPRAMState *)opaque;
> +
> +    switch (size) {
> +    case 1:
> +    case 2:
> +        raise_exception(EXCP_AdEL);
> +        return 0;
> +    case 4:
> +        return *(uint32_t *) &s->ramblock[addr % (1 << s->size)];
> +    case 8:
> +        return *(uint64_t *) &s->ramblock[addr % (1 << s->size)];
> +    }
> +    return 0;
> +}
> +
> +static void dspram_write(void *opaque, hwaddr addr, uint64_t data,
> +                         unsigned size)
> +{
> +    MIPSDSPRAMState *s = (MIPSDSPRAMState *)opaque;
> +
> +    switch (size) {
> +    case 1:
> +    case 2:
> +        raise_exception(EXCP_AdES);
> +        return;
> +    case 4:
> +        *(uint32_t *) &s->ramblock[addr % (1 << s->size)] = (uint32_t)
data;
> +        break;
> +    case 8:
> +        *(uint64_t *) &s->ramblock[addr % (1 << s->size)] = data;
> +        break;
> +    }
> +}
> +
> +void dspram_reconfigure(struct MIPSDSPRAMState *dspram)
> +{
> +    MemoryRegion *mr = &dspram->mr;
> +    hwaddr address;
> +    bool is_enabled;
> +
> +    address = ((*(uint64_t *) dspram->saar) & 0xFFFFFFFE000ULL) << 4;
> +    is_enabled = *(uint64_t *) dspram->saar & 1;
> +
> +    memory_region_transaction_begin();
> +    memory_region_set_size(mr, (1 << dspram->size));
> +    memory_region_set_address(mr, address);
> +    memory_region_set_enabled(mr, is_enabled);
> +    memory_region_transaction_commit();
> +}
> +
> +static const MemoryRegionOps dspram_ops = {
> +    .read = dspram_read,
> +    .write = dspram_write,
> +    .endianness = DEVICE_NATIVE_ENDIAN,
> +    .valid = {
> +        .unaligned = false,
> +    }
> +};
> +
> +static void mips_dspram_init(Object *obj)
> +{
> +    SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
> +    MIPSDSPRAMState *s = MIPS_DSPRAM(obj);
> +
> +    memory_region_init_io(&s->mr, OBJECT(s), &dspram_ops, s,
> +                          "mips-dspram", (1 << s->size));
> +    sysbus_init_mmio(sbd, &s->mr);
> +}
> +
> +static void mips_dspram_realize(DeviceState *dev, Error **errp)
> +{
> +    MIPSDSPRAMState *s = MIPS_DSPRAM(dev);
> +
> +    /* some error handling here */
> +
> +    s->ramblock = g_malloc0(1 << s->size);
> +}
> +
> +static void mips_dspram_reset(DeviceState *dev)
> +{
> +    MIPSDSPRAMState *s = MIPS_DSPRAM(dev);
> +
> +    *(uint64_t *) s->saar = s->size << 1;
> +    memset(s->ramblock, 0, (1 << s->size));
> +}
> +
> +static Property mips_dspram_properties[] = {
> +    DEFINE_PROP_PTR("saar", MIPSDSPRAMState, saar),
> +    /* default DSPRAM size is 64 KB */
> +    DEFINE_PROP_SIZE("size", MIPSDSPRAMState, size, 0x10),
> +    DEFINE_PROP_END_OF_LIST(),
> +};
> +
> +static void mips_dspram_class_init(ObjectClass *klass, void *data)
> +{
> +    DeviceClass *dc = DEVICE_CLASS(klass);
> +
> +    dc->props = mips_dspram_properties;
> +    dc->realize = mips_dspram_realize;
> +    dc->reset = mips_dspram_reset;
> +}
> +
> +static const TypeInfo mips_dspram_info = {
> +    .name          = TYPE_MIPS_DSPRAM,
> +    .parent        = TYPE_SYS_BUS_DEVICE,
> +    .instance_size = sizeof(MIPSDSPRAMState),
> +    .instance_init = mips_dspram_init,
> +    .class_init    = mips_dspram_class_init,
> +};
> +
> +static void mips_dspram_register_types(void)
> +{
> +    type_register_static(&mips_dspram_info);
> +}
> +
> +type_init(mips_dspram_register_types);
> diff --git a/include/hw/mips/cps.h b/include/hw/mips/cps.h
> index aab1af9..a637036 100644
> --- a/include/hw/mips/cps.h
> +++ b/include/hw/mips/cps.h
> @@ -25,6 +25,7 @@
>  #include "hw/intc/mips_gic.h"
>  #include "hw/misc/mips_cpc.h"
>  #include "hw/misc/mips_itu.h"
> +#include "hw/misc/mips_dspram.h"
>
>  #define TYPE_MIPS_CPS "mips-cps"
>  #define MIPS_CPS(obj) OBJECT_CHECK(MIPSCPSState, (obj), TYPE_MIPS_CPS)
> @@ -41,6 +42,7 @@ typedef struct MIPSCPSState {
>      MIPSGICState gic;
>      MIPSCPCState cpc;
>      MIPSITUState itu;
> +    MIPSDSPRAMState dspram;
>  } MIPSCPSState;
>
>  qemu_irq get_cps_irq(MIPSCPSState *cps, int pin_number);
> diff --git a/include/hw/misc/mips_dspram.h b/include/hw/misc/mips_dspram.h
> new file mode 100644
> index 0000000..ee99e17
> --- /dev/null
> +++ b/include/hw/misc/mips_dspram.h
> @@ -0,0 +1,46 @@
> +/*
> + * Data Scratch Pad RAM
> + *
> + * Copyright (c) 2017 Imagination Technologies
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with this library; if not, see <
http://www.gnu.org/licenses/>.
> + */
> +
> +#ifndef MIPS_DSPRAM_H
> +#define MIPS_DSPRAM_H
> +
> +#include "hw/sysbus.h"
> +
> +#define TYPE_MIPS_DSPRAM "mips-dspram"
> +#define MIPS_DSPRAM(obj) OBJECT_CHECK(MIPSDSPRAMState, (obj),
TYPE_MIPS_DSPRAM)
> +
> +typedef struct MIPSDSPRAMState {
> +    /*< private >*/
> +    SysBusDevice parent_obj;
> +    /*< public >*/
> +
> +    /* 2 ^ SIZE */
> +    uint64_t size;
> +
> +    MemoryRegion mr;
> +
> +    /* SAAR */
> +    bool saar_present;
> +    void *saar;
> +
> +    /* ramblock */
> +    uint8_t *ramblock;
> +} MIPSDSPRAMState;
> +
> +#endif /* MIPS_DSPRAM_H */
> diff --git a/target/mips/cpu.h b/target/mips/cpu.h
> index a10eeb0..8b15e6c 100644
> --- a/target/mips/cpu.h
> +++ b/target/mips/cpu.h
> @@ -445,6 +445,7 @@ struct TCState {
>
>  };
>
> +struct MIPSDSPRAMState;
>  struct MIPSITUState;
>  typedef struct CPUMIPSState CPUMIPSState;
>  struct CPUMIPSState {
> @@ -1021,8 +1022,8 @@ struct CPUMIPSState {
>      uint32_t CP0_Status_rw_bitmask; /* Read/write bits in CP0_Status */
>      uint32_t CP0_TCStatus_rw_bitmask; /* Read/write bits in CP0_TCStatus
*/
>      uint64_t insn_flags; /* Supported instruction set */
> -    int saarp;
> -
> +    bool saarp;
> +    bool dspramp;
>      /* Fields up to this point are cleared by a CPU reset */
>      struct {} end_reset_fields;
>
> @@ -1039,6 +1040,7 @@ struct CPUMIPSState {
>      QEMUTimer *timer; /* Internal timer */
>      struct MIPSITUState *itu;
>      MemoryRegion *itc_tag; /* ITC Configuration Tags */
> +    struct MIPSDSPRAMState *dspram;
>      target_ulong exception_base; /* ExceptionBase input to the core */
>  };
>
> @@ -1181,6 +1183,9 @@ void cpu_mips_soft_irq(CPUMIPSState *env, int irq,
int level);
>  /* mips_itu.c */
>  void itc_reconfigure(struct MIPSITUState *tag);
>
> +/* mips_dspram.c */
> +void dspram_reconfigure(struct MIPSDSPRAMState *dspram);
> +
>  /* helper.c */
>  target_ulong exception_resume_pc (CPUMIPSState *env);
>
> diff --git a/target/mips/internal.h b/target/mips/internal.h
> index 8f6fc91..650bddd 100644
> --- a/target/mips/internal.h
> +++ b/target/mips/internal.h
> @@ -61,7 +61,8 @@ struct mips_def_t {
>      target_ulong CP0_EBaseWG_rw_bitmask;
>      uint64_t insn_flags;
>      enum mips_mmu_types mmu_type;
> -    int32_t SAARP;
> +    bool SAARP;
> +    bool DSPRAMP;
>  };
>
>  extern const struct mips_def_t mips_defs[];
> diff --git a/target/mips/op_helper.c b/target/mips/op_helper.c
> index c921032..5136e33 100644
> --- a/target/mips/op_helper.c
> +++ b/target/mips/op_helper.c
> @@ -1614,7 +1614,14 @@ void helper_mtc0_saar(CPUMIPSState *env,
target_ulong arg1)
>                  itc_reconfigure(env->itu);
>              }
>              break;
> +        case 1:
> +            if (env->dspram) {
> +                dspram_reconfigure(env->dspram);
> +            }
> +            break;
>          }
> +    } else {
> +        helper_raise_exception(env, EXCP_RI);
>      }
>  }
>
> @@ -1631,7 +1638,14 @@ void helper_mthc0_saar(CPUMIPSState *env,
target_ulong arg1)
>                  itc_reconfigure(env->itu);
>              }
>              break;
> +        case 1:
> +            if (env->dspram) {
> +                dspram_reconfigure(env->dspram);
> +            }
> +            break;
>          }
> +    } else {
> +        helper_raise_exception(env, EXCP_RI);
>      }
>  }
>
> diff --git a/target/mips/translate.c b/target/mips/translate.c
> index c79fa1e..40584e9 100644
> --- a/target/mips/translate.c
> +++ b/target/mips/translate.c
> @@ -31383,6 +31383,8 @@ void cpu_state_reset(CPUMIPSState *env)
>      env->active_fpu.fcr31 = env->cpu_model->CP1_fcr31;
>      env->msair = env->cpu_model->MSAIR;
>      env->insn_flags = env->cpu_model->insn_flags;
> +    env->saarp = env->cpu_model->SAARP;
> +    env->dspramp = env->cpu_model->DSPRAMP;
>
>  #if defined(CONFIG_USER_ONLY)
>      env->CP0_Status = (MIPS_HFLAG_UM << CP0St_KSU);
> @@ -31537,6 +31539,12 @@ void cpu_state_reset(CPUMIPSState *env)
>          msa_reset(env);
>      }
>
> +    /* DSPRAM */
> +    if (env->dspramp) {
> +        /* Fixed DSPRAM size with Default Value */
> +        env->CP0_SAAR[1] = 0x10 << 1;
> +    }
> +
>      compute_hflags(env);
>      restore_fp_status(env);
>      restore_pamask(env);
> diff --git a/target/mips/translate_init.inc.c
b/target/mips/translate_init.inc.c
> index bf559af..4c49a0e 100644
> --- a/target/mips/translate_init.inc.c
> +++ b/target/mips/translate_init.inc.c
> @@ -760,6 +760,8 @@ const mips_def_t mips_defs[] =
>          .PABITS = 48,
>          .insn_flags = CPU_MIPS64R6 | ASE_MSA,
>          .mmu_type = MMU_TYPE_R4000,
> +        .SAARP = 1,
> +        .DSPRAMP = 1,
>      },
>      {
>          .name = "Loongson-2E",
> --
> 2.7.4
>
>
Mateja Marjanovic June 10, 2019, 9:43 a.m. UTC | #2
On 8.6.19. 07:32, Aleksandar Markovic wrote:
>
>
> On Jun 6, 2019 3:49 PM, "Mateja Marjanovic" 
> <mateja.marjanovic@rt-rk.com <mailto:mateja.marjanovic@rt-rk.com>> wrote:
> >
> > From: Mateja Marjanovic <Mateja.Marjanovic@rt-rk.com 
> <mailto:Mateja.Marjanovic@rt-rk.com>>
> >
> > Add support for DSPRAM (Data Scratch Pad RAM). It still needs
> > some minor fixing, but the structure is right.
> >
> > Signed-off-by: Mateja Marjanovic <mateja.marjanovic@rt-rk.com 
> <mailto:mateja.marjanovic@rt-rk.com>>
> > ---
>
> Please consider splitting the patch into several logical units.
>
> Adding Philippe.
>
I will do that in v2.

Regards,
Mateja
>
> Thanks,
> Aleksandar
>
> >  default-configs/mips-softmmu-common.mak |   1 +
> >  hw/mips/cps.c                           |  28 +++++-
> >  hw/misc/Makefile.objs                   |   1 +
> >  hw/misc/mips_dspram.c                   | 153 
> ++++++++++++++++++++++++++++++++
> >  include/hw/mips/cps.h                   |   2 +
> >  include/hw/misc/mips_dspram.h           |  46 ++++++++++
> >  target/mips/cpu.h                       |   9 +-
> >  target/mips/internal.h                  |   3 +-
> >  target/mips/op_helper.c                 |  14 +++
> >  target/mips/translate.c                 |   8 ++
> >  target/mips/translate_init.inc.c        |   2 +
> >  11 files changed, 262 insertions(+), 5 deletions(-)
> >  create mode 100644 hw/misc/mips_dspram.c
> >  create mode 100644 include/hw/misc/mips_dspram.h
> >
> > diff --git a/default-configs/mips-softmmu-common.mak 
> b/default-configs/mips-softmmu-common.mak
> > index ded7498..d3f85b0 100644
> > --- a/default-configs/mips-softmmu-common.mak
> > +++ b/default-configs/mips-softmmu-common.mak
> > @@ -35,6 +35,7 @@ CONFIG_ISA_TESTDEV=y
> >  CONFIG_EMPTY_SLOT=y
> >  CONFIG_MIPS_CPS=y
> >  CONFIG_MIPS_ITU=y
> > +CONFIG_MIPS_DSPRAM=y
> >  CONFIG_I2C=y
> >  CONFIG_R4K=y
> >  CONFIG_MALTA=y
> > diff --git a/hw/mips/cps.c b/hw/mips/cps.c
> > index fc97f59..0205556 100644
> > --- a/hw/mips/cps.c
> > +++ b/hw/mips/cps.c
> > @@ -90,7 +90,8 @@ static void mips_cps_realize(DeviceState *dev, 
> Error **errp)
> >
> >      cpu = MIPS_CPU(first_cpu);
> >      env = &cpu->env;
> > -    saar_present = (bool)env->saarp;
> > +    saar_present = env->saarp;
> > +    bool dspram_present = env->dspramp;
> >
> >      /* Inter-Thread Communication Unit */
> >      if (itu_present) {
> > @@ -102,7 +103,8 @@ static void mips_cps_realize(DeviceState *dev, 
> Error **errp)
> >          object_property_set_bool(OBJECT(&s->itu), saar_present, 
> "saar-present",
> >                                   &err);
> >          if (saar_present) {
> > -            qdev_prop_set_ptr(DEVICE(&s->itu), "saar", (void 
> *)&env->CP0_SAAR);
> > +            qdev_prop_set_ptr(DEVICE(&s->itu), "saar",
> > +                              (void *) &env->CP0_SAAR[0]);
> >          }
> >          object_property_set_bool(OBJECT(&s->itu), true, "realized", 
> &err);
> >          if (err != NULL) {
> > @@ -113,6 +115,28 @@ static void mips_cps_realize(DeviceState *dev, 
> Error **errp)
> >          memory_region_add_subregion(&s->container, 0,
> > sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->itu), 0));
> >      }
> > +    env->dspram = g_new0(MIPSDSPRAMState, 1);
> > +
> > +    /* Data Scratch Pad RAM */
> > +    if (dspram_present) {
> > +        if (!saar_present) {
> > +            error_report("%s: DSPRAM requires SAAR registers", 
> __func__);
> > +            return;
> > +        }
> > +        object_initialize(&s->dspram, sizeof(MIPSDSPRAMState),
> > +                          TYPE_MIPS_DSPRAM);
> > +        qdev_set_parent_bus(DEVICE(&s->dspram), sysbus_get_default());
> > +        qdev_prop_set_ptr(DEVICE(&s->dspram), "saar",
> > +                          &env->CP0_SAAR[1]);
> > + object_property_set_bool(OBJECT(&s->dspram), true, "realized", &err);
> > +        if (err != NULL) {
> > +            error_report("%s: DSPRAM initialisation failed", __func__);
> > +            error_propagate(errp, err);
> > +            return;
> > +        }
> > +        memory_region_add_subregion(&s->container, 0,
> > + sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->dspram), 0));
> > +    }
> >
> >      /* Cluster Power Controller */
> >      object_initialize(&s->cpc, sizeof(s->cpc), TYPE_MIPS_CPC);
> > diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs
> > index 74c91d2..37c4108 100644
> > --- a/hw/misc/Makefile.objs
> > +++ b/hw/misc/Makefile.objs
> > @@ -60,6 +60,7 @@ obj-$(CONFIG_STM32F2XX_SYSCFG) += stm32f2xx_syscfg.o
> >  obj-$(CONFIG_MIPS_CPS) += mips_cmgcr.o
> >  obj-$(CONFIG_MIPS_CPS) += mips_cpc.o
> >  obj-$(CONFIG_MIPS_ITU) += mips_itu.o
> > +obj-$(CONFIG_MIPS_DSPRAM) += mips_dspram.o
> >  obj-$(CONFIG_MPS2_FPGAIO) += mps2-fpgaio.o
> >  obj-$(CONFIG_MPS2_SCC) += mps2-scc.o
> >
> > diff --git a/hw/misc/mips_dspram.c b/hw/misc/mips_dspram.c
> > new file mode 100644
> > index 0000000..9bc155b
> > --- /dev/null
> > +++ b/hw/misc/mips_dspram.c
> > @@ -0,0 +1,153 @@
> > +/*
> > + * Data Scratch Pad RAM
> > + *
> > + * Copyright (c) 2017 Imagination Technologies
> > + *
> > + * This library is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU Lesser General Public
> > + * License as published by the Free Software Foundation; either
> > + * version 2 of the License, or (at your option) any later version.
> > + *
> > + * This library is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> > + * Lesser General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU Lesser General Public
> > + * License along with this library; if not, see 
> <http://www.gnu.org/licenses/>.
> > + */
> > +
> > +#include "qemu/osdep.h"
> > +#include "qapi/error.h"
> > +#include "cpu.h"
> > +#include "qemu/log.h"
> > +#include "exec/exec-all.h"
> > +#include "hw/hw.h"
> > +#include "hw/sysbus.h"
> > +#include "sysemu/sysemu.h"
> > +#include "hw/misc/mips_dspram.h"
> > +
> > +static void raise_exception(int excp)
> > +{
> > +    current_cpu->exception_index = excp;
> > +    cpu_loop_exit(current_cpu);
> > +}
> > +
> > +static uint64_t dspram_read(void *opaque, hwaddr addr, unsigned size)
> > +{
> > +    MIPSDSPRAMState *s = (MIPSDSPRAMState *)opaque;
> > +
> > +    switch (size) {
> > +    case 1:
> > +    case 2:
> > +        raise_exception(EXCP_AdEL);
> > +        return 0;
> > +    case 4:
> > +        return *(uint32_t *) &s->ramblock[addr % (1 << s->size)];
> > +    case 8:
> > +        return *(uint64_t *) &s->ramblock[addr % (1 << s->size)];
> > +    }
> > +    return 0;
> > +}
> > +
> > +static void dspram_write(void *opaque, hwaddr addr, uint64_t data,
> > +                         unsigned size)
> > +{
> > +    MIPSDSPRAMState *s = (MIPSDSPRAMState *)opaque;
> > +
> > +    switch (size) {
> > +    case 1:
> > +    case 2:
> > +        raise_exception(EXCP_AdES);
> > +        return;
> > +    case 4:
> > +        *(uint32_t *) &s->ramblock[addr % (1 << s->size)] = 
> (uint32_t) data;
> > +        break;
> > +    case 8:
> > +        *(uint64_t *) &s->ramblock[addr % (1 << s->size)] = data;
> > +        break;
> > +    }
> > +}
> > +
> > +void dspram_reconfigure(struct MIPSDSPRAMState *dspram)
> > +{
> > +    MemoryRegion *mr = &dspram->mr;
> > +    hwaddr address;
> > +    bool is_enabled;
> > +
> > +    address = ((*(uint64_t *) dspram->saar) & 0xFFFFFFFE000ULL) << 4;
> > +    is_enabled = *(uint64_t *) dspram->saar & 1;
> > +
> > +    memory_region_transaction_begin();
> > +    memory_region_set_size(mr, (1 << dspram->size));
> > +    memory_region_set_address(mr, address);
> > +    memory_region_set_enabled(mr, is_enabled);
> > +    memory_region_transaction_commit();
> > +}
> > +
> > +static const MemoryRegionOps dspram_ops = {
> > +    .read = dspram_read,
> > +    .write = dspram_write,
> > +    .endianness = DEVICE_NATIVE_ENDIAN,
> > +    .valid = {
> > +        .unaligned = false,
> > +    }
> > +};
> > +
> > +static void mips_dspram_init(Object *obj)
> > +{
> > +    SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
> > +    MIPSDSPRAMState *s = MIPS_DSPRAM(obj);
> > +
> > +    memory_region_init_io(&s->mr, OBJECT(s), &dspram_ops, s,
> > +                          "mips-dspram", (1 << s->size));
> > +    sysbus_init_mmio(sbd, &s->mr);
> > +}
> > +
> > +static void mips_dspram_realize(DeviceState *dev, Error **errp)
> > +{
> > +    MIPSDSPRAMState *s = MIPS_DSPRAM(dev);
> > +
> > +    /* some error handling here */
> > +
> > +    s->ramblock = g_malloc0(1 << s->size);
> > +}
> > +
> > +static void mips_dspram_reset(DeviceState *dev)
> > +{
> > +    MIPSDSPRAMState *s = MIPS_DSPRAM(dev);
> > +
> > +    *(uint64_t *) s->saar = s->size << 1;
> > +    memset(s->ramblock, 0, (1 << s->size));
> > +}
> > +
> > +static Property mips_dspram_properties[] = {
> > +    DEFINE_PROP_PTR("saar", MIPSDSPRAMState, saar),
> > +    /* default DSPRAM size is 64 KB */
> > +    DEFINE_PROP_SIZE("size", MIPSDSPRAMState, size, 0x10),
> > +    DEFINE_PROP_END_OF_LIST(),
> > +};
> > +
> > +static void mips_dspram_class_init(ObjectClass *klass, void *data)
> > +{
> > +    DeviceClass *dc = DEVICE_CLASS(klass);
> > +
> > +    dc->props = mips_dspram_properties;
> > +    dc->realize = mips_dspram_realize;
> > +    dc->reset = mips_dspram_reset;
> > +}
> > +
> > +static const TypeInfo mips_dspram_info = {
> > +    .name          = TYPE_MIPS_DSPRAM,
> > +    .parent        = TYPE_SYS_BUS_DEVICE,
> > +    .instance_size = sizeof(MIPSDSPRAMState),
> > +    .instance_init = mips_dspram_init,
> > +    .class_init    = mips_dspram_class_init,
> > +};
> > +
> > +static void mips_dspram_register_types(void)
> > +{
> > +    type_register_static(&mips_dspram_info);
> > +}
> > +
> > +type_init(mips_dspram_register_types);
> > diff --git a/include/hw/mips/cps.h b/include/hw/mips/cps.h
> > index aab1af9..a637036 100644
> > --- a/include/hw/mips/cps.h
> > +++ b/include/hw/mips/cps.h
> > @@ -25,6 +25,7 @@
> >  #include "hw/intc/mips_gic.h"
> >  #include "hw/misc/mips_cpc.h"
> >  #include "hw/misc/mips_itu.h"
> > +#include "hw/misc/mips_dspram.h"
> >
> >  #define TYPE_MIPS_CPS "mips-cps"
> >  #define MIPS_CPS(obj) OBJECT_CHECK(MIPSCPSState, (obj), TYPE_MIPS_CPS)
> > @@ -41,6 +42,7 @@ typedef struct MIPSCPSState {
> >      MIPSGICState gic;
> >      MIPSCPCState cpc;
> >      MIPSITUState itu;
> > +    MIPSDSPRAMState dspram;
> >  } MIPSCPSState;
> >
> >  qemu_irq get_cps_irq(MIPSCPSState *cps, int pin_number);
> > diff --git a/include/hw/misc/mips_dspram.h 
> b/include/hw/misc/mips_dspram.h
> > new file mode 100644
> > index 0000000..ee99e17
> > --- /dev/null
> > +++ b/include/hw/misc/mips_dspram.h
> > @@ -0,0 +1,46 @@
> > +/*
> > + * Data Scratch Pad RAM
> > + *
> > + * Copyright (c) 2017 Imagination Technologies
> > + *
> > + * This library is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU Lesser General Public
> > + * License as published by the Free Software Foundation; either
> > + * version 2 of the License, or (at your option) any later version.
> > + *
> > + * This library is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> > + * Lesser General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU Lesser General Public
> > + * License along with this library; if not, see 
> <http://www.gnu.org/licenses/>.
> > + */
> > +
> > +#ifndef MIPS_DSPRAM_H
> > +#define MIPS_DSPRAM_H
> > +
> > +#include "hw/sysbus.h"
> > +
> > +#define TYPE_MIPS_DSPRAM "mips-dspram"
> > +#define MIPS_DSPRAM(obj) OBJECT_CHECK(MIPSDSPRAMState, (obj), 
> TYPE_MIPS_DSPRAM)
> > +
> > +typedef struct MIPSDSPRAMState {
> > +    /*< private >*/
> > +    SysBusDevice parent_obj;
> > +    /*< public >*/
> > +
> > +    /* 2 ^ SIZE */
> > +    uint64_t size;
> > +
> > +    MemoryRegion mr;
> > +
> > +    /* SAAR */
> > +    bool saar_present;
> > +    void *saar;
> > +
> > +    /* ramblock */
> > +    uint8_t *ramblock;
> > +} MIPSDSPRAMState;
> > +
> > +#endif /* MIPS_DSPRAM_H */
> > diff --git a/target/mips/cpu.h b/target/mips/cpu.h
> > index a10eeb0..8b15e6c 100644
> > --- a/target/mips/cpu.h
> > +++ b/target/mips/cpu.h
> > @@ -445,6 +445,7 @@ struct TCState {
> >
> >  };
> >
> > +struct MIPSDSPRAMState;
> >  struct MIPSITUState;
> >  typedef struct CPUMIPSState CPUMIPSState;
> >  struct CPUMIPSState {
> > @@ -1021,8 +1022,8 @@ struct CPUMIPSState {
> >      uint32_t CP0_Status_rw_bitmask; /* Read/write bits in CP0_Status */
> >      uint32_t CP0_TCStatus_rw_bitmask; /* Read/write bits in 
> CP0_TCStatus */
> >      uint64_t insn_flags; /* Supported instruction set */
> > -    int saarp;
> > -
> > +    bool saarp;
> > +    bool dspramp;
> >      /* Fields up to this point are cleared by a CPU reset */
> >      struct {} end_reset_fields;
> >
> > @@ -1039,6 +1040,7 @@ struct CPUMIPSState {
> >      QEMUTimer *timer; /* Internal timer */
> >      struct MIPSITUState *itu;
> >      MemoryRegion *itc_tag; /* ITC Configuration Tags */
> > +    struct MIPSDSPRAMState *dspram;
> >      target_ulong exception_base; /* ExceptionBase input to the core */
> >  };
> >
> > @@ -1181,6 +1183,9 @@ void cpu_mips_soft_irq(CPUMIPSState *env, int 
> irq, int level);
> >  /* mips_itu.c */
> >  void itc_reconfigure(struct MIPSITUState *tag);
> >
> > +/* mips_dspram.c */
> > +void dspram_reconfigure(struct MIPSDSPRAMState *dspram);
> > +
> >  /* helper.c */
> >  target_ulong exception_resume_pc (CPUMIPSState *env);
> >
> > diff --git a/target/mips/internal.h b/target/mips/internal.h
> > index 8f6fc91..650bddd 100644
> > --- a/target/mips/internal.h
> > +++ b/target/mips/internal.h
> > @@ -61,7 +61,8 @@ struct mips_def_t {
> >      target_ulong CP0_EBaseWG_rw_bitmask;
> >      uint64_t insn_flags;
> >      enum mips_mmu_types mmu_type;
> > -    int32_t SAARP;
> > +    bool SAARP;
> > +    bool DSPRAMP;
> >  };
> >
> >  extern const struct mips_def_t mips_defs[];
> > diff --git a/target/mips/op_helper.c b/target/mips/op_helper.c
> > index c921032..5136e33 100644
> > --- a/target/mips/op_helper.c
> > +++ b/target/mips/op_helper.c
> > @@ -1614,7 +1614,14 @@ void helper_mtc0_saar(CPUMIPSState *env, 
> target_ulong arg1)
> >                  itc_reconfigure(env->itu);
> >              }
> >              break;
> > +        case 1:
> > +            if (env->dspram) {
> > +                dspram_reconfigure(env->dspram);
> > +            }
> > +            break;
> >          }
> > +    } else {
> > +        helper_raise_exception(env, EXCP_RI);
> >      }
> >  }
> >
> > @@ -1631,7 +1638,14 @@ void helper_mthc0_saar(CPUMIPSState *env, 
> target_ulong arg1)
> >                  itc_reconfigure(env->itu);
> >              }
> >              break;
> > +        case 1:
> > +            if (env->dspram) {
> > +                dspram_reconfigure(env->dspram);
> > +            }
> > +            break;
> >          }
> > +    } else {
> > +        helper_raise_exception(env, EXCP_RI);
> >      }
> >  }
> >
> > diff --git a/target/mips/translate.c b/target/mips/translate.c
> > index c79fa1e..40584e9 100644
> > --- a/target/mips/translate.c
> > +++ b/target/mips/translate.c
> > @@ -31383,6 +31383,8 @@ void cpu_state_reset(CPUMIPSState *env)
> >      env->active_fpu.fcr31 = env->cpu_model->CP1_fcr31;
> >      env->msair = env->cpu_model->MSAIR;
> >      env->insn_flags = env->cpu_model->insn_flags;
> > +    env->saarp = env->cpu_model->SAARP;
> > +    env->dspramp = env->cpu_model->DSPRAMP;
> >
> >  #if defined(CONFIG_USER_ONLY)
> >      env->CP0_Status = (MIPS_HFLAG_UM << CP0St_KSU);
> > @@ -31537,6 +31539,12 @@ void cpu_state_reset(CPUMIPSState *env)
> >          msa_reset(env);
> >      }
> >
> > +    /* DSPRAM */
> > +    if (env->dspramp) {
> > +        /* Fixed DSPRAM size with Default Value */
> > +        env->CP0_SAAR[1] = 0x10 << 1;
> > +    }
> > +
> >      compute_hflags(env);
> >      restore_fp_status(env);
> >      restore_pamask(env);
> > diff --git a/target/mips/translate_init.inc.c 
> b/target/mips/translate_init.inc.c
> > index bf559af..4c49a0e 100644
> > --- a/target/mips/translate_init.inc.c
> > +++ b/target/mips/translate_init.inc.c
> > @@ -760,6 +760,8 @@ const mips_def_t mips_defs[] =
> >          .PABITS = 48,
> >          .insn_flags = CPU_MIPS64R6 | ASE_MSA,
> >          .mmu_type = MMU_TYPE_R4000,
> > +        .SAARP = 1,
> > +        .DSPRAMP = 1,
> >      },
> >      {
> >          .name = "Loongson-2E",
> > --
> > 2.7.4
> >
> >
>
diff mbox series

Patch

diff --git a/default-configs/mips-softmmu-common.mak b/default-configs/mips-softmmu-common.mak
index ded7498..d3f85b0 100644
--- a/default-configs/mips-softmmu-common.mak
+++ b/default-configs/mips-softmmu-common.mak
@@ -35,6 +35,7 @@  CONFIG_ISA_TESTDEV=y
 CONFIG_EMPTY_SLOT=y
 CONFIG_MIPS_CPS=y
 CONFIG_MIPS_ITU=y
+CONFIG_MIPS_DSPRAM=y
 CONFIG_I2C=y
 CONFIG_R4K=y
 CONFIG_MALTA=y
diff --git a/hw/mips/cps.c b/hw/mips/cps.c
index fc97f59..0205556 100644
--- a/hw/mips/cps.c
+++ b/hw/mips/cps.c
@@ -90,7 +90,8 @@  static void mips_cps_realize(DeviceState *dev, Error **errp)
 
     cpu = MIPS_CPU(first_cpu);
     env = &cpu->env;
-    saar_present = (bool)env->saarp;
+    saar_present = env->saarp;
+    bool dspram_present = env->dspramp;
 
     /* Inter-Thread Communication Unit */
     if (itu_present) {
@@ -102,7 +103,8 @@  static void mips_cps_realize(DeviceState *dev, Error **errp)
         object_property_set_bool(OBJECT(&s->itu), saar_present, "saar-present",
                                  &err);
         if (saar_present) {
-            qdev_prop_set_ptr(DEVICE(&s->itu), "saar", (void *)&env->CP0_SAAR);
+            qdev_prop_set_ptr(DEVICE(&s->itu), "saar",
+                              (void *) &env->CP0_SAAR[0]);
         }
         object_property_set_bool(OBJECT(&s->itu), true, "realized", &err);
         if (err != NULL) {
@@ -113,6 +115,28 @@  static void mips_cps_realize(DeviceState *dev, Error **errp)
         memory_region_add_subregion(&s->container, 0,
                            sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->itu), 0));
     }
+    env->dspram = g_new0(MIPSDSPRAMState, 1);
+
+    /* Data Scratch Pad RAM */
+    if (dspram_present) {
+        if (!saar_present) {
+            error_report("%s: DSPRAM requires SAAR registers", __func__);
+            return;
+        }
+        object_initialize(&s->dspram, sizeof(MIPSDSPRAMState),
+                          TYPE_MIPS_DSPRAM);
+        qdev_set_parent_bus(DEVICE(&s->dspram), sysbus_get_default());
+        qdev_prop_set_ptr(DEVICE(&s->dspram), "saar",
+                          &env->CP0_SAAR[1]);
+        object_property_set_bool(OBJECT(&s->dspram), true, "realized", &err);
+        if (err != NULL) {
+            error_report("%s: DSPRAM initialisation failed", __func__);
+            error_propagate(errp, err);
+            return;
+        }
+        memory_region_add_subregion(&s->container, 0,
+                    sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->dspram), 0));
+    }
 
     /* Cluster Power Controller */
     object_initialize(&s->cpc, sizeof(s->cpc), TYPE_MIPS_CPC);
diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs
index 74c91d2..37c4108 100644
--- a/hw/misc/Makefile.objs
+++ b/hw/misc/Makefile.objs
@@ -60,6 +60,7 @@  obj-$(CONFIG_STM32F2XX_SYSCFG) += stm32f2xx_syscfg.o
 obj-$(CONFIG_MIPS_CPS) += mips_cmgcr.o
 obj-$(CONFIG_MIPS_CPS) += mips_cpc.o
 obj-$(CONFIG_MIPS_ITU) += mips_itu.o
+obj-$(CONFIG_MIPS_DSPRAM) += mips_dspram.o
 obj-$(CONFIG_MPS2_FPGAIO) += mps2-fpgaio.o
 obj-$(CONFIG_MPS2_SCC) += mps2-scc.o
 
diff --git a/hw/misc/mips_dspram.c b/hw/misc/mips_dspram.c
new file mode 100644
index 0000000..9bc155b
--- /dev/null
+++ b/hw/misc/mips_dspram.c
@@ -0,0 +1,153 @@ 
+/*
+ * Data Scratch Pad RAM
+ *
+ * Copyright (c) 2017 Imagination Technologies
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "qemu/osdep.h"
+#include "qapi/error.h"
+#include "cpu.h"
+#include "qemu/log.h"
+#include "exec/exec-all.h"
+#include "hw/hw.h"
+#include "hw/sysbus.h"
+#include "sysemu/sysemu.h"
+#include "hw/misc/mips_dspram.h"
+
+static void raise_exception(int excp)
+{
+    current_cpu->exception_index = excp;
+    cpu_loop_exit(current_cpu);
+}
+
+static uint64_t dspram_read(void *opaque, hwaddr addr, unsigned size)
+{
+    MIPSDSPRAMState *s = (MIPSDSPRAMState *)opaque;
+
+    switch (size) {
+    case 1:
+    case 2:
+        raise_exception(EXCP_AdEL);
+        return 0;
+    case 4:
+        return *(uint32_t *) &s->ramblock[addr % (1 << s->size)];
+    case 8:
+        return *(uint64_t *) &s->ramblock[addr % (1 << s->size)];
+    }
+    return 0;
+}
+
+static void dspram_write(void *opaque, hwaddr addr, uint64_t data,
+                         unsigned size)
+{
+    MIPSDSPRAMState *s = (MIPSDSPRAMState *)opaque;
+
+    switch (size) {
+    case 1:
+    case 2:
+        raise_exception(EXCP_AdES);
+        return;
+    case 4:
+        *(uint32_t *) &s->ramblock[addr % (1 << s->size)] = (uint32_t) data;
+        break;
+    case 8:
+        *(uint64_t *) &s->ramblock[addr % (1 << s->size)] = data;
+        break;
+    }
+}
+
+void dspram_reconfigure(struct MIPSDSPRAMState *dspram)
+{
+    MemoryRegion *mr = &dspram->mr;
+    hwaddr address;
+    bool is_enabled;
+
+    address = ((*(uint64_t *) dspram->saar) & 0xFFFFFFFE000ULL) << 4;
+    is_enabled = *(uint64_t *) dspram->saar & 1;
+
+    memory_region_transaction_begin();
+    memory_region_set_size(mr, (1 << dspram->size));
+    memory_region_set_address(mr, address);
+    memory_region_set_enabled(mr, is_enabled);
+    memory_region_transaction_commit();
+}
+
+static const MemoryRegionOps dspram_ops = {
+    .read = dspram_read,
+    .write = dspram_write,
+    .endianness = DEVICE_NATIVE_ENDIAN,
+    .valid = {
+        .unaligned = false,
+    }
+};
+
+static void mips_dspram_init(Object *obj)
+{
+    SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
+    MIPSDSPRAMState *s = MIPS_DSPRAM(obj);
+
+    memory_region_init_io(&s->mr, OBJECT(s), &dspram_ops, s,
+                          "mips-dspram", (1 << s->size));
+    sysbus_init_mmio(sbd, &s->mr);
+}
+
+static void mips_dspram_realize(DeviceState *dev, Error **errp)
+{
+    MIPSDSPRAMState *s = MIPS_DSPRAM(dev);
+
+    /* some error handling here */
+
+    s->ramblock = g_malloc0(1 << s->size);
+}
+
+static void mips_dspram_reset(DeviceState *dev)
+{
+    MIPSDSPRAMState *s = MIPS_DSPRAM(dev);
+
+    *(uint64_t *) s->saar = s->size << 1;
+    memset(s->ramblock, 0, (1 << s->size));
+}
+
+static Property mips_dspram_properties[] = {
+    DEFINE_PROP_PTR("saar", MIPSDSPRAMState, saar),
+    /* default DSPRAM size is 64 KB */
+    DEFINE_PROP_SIZE("size", MIPSDSPRAMState, size, 0x10),
+    DEFINE_PROP_END_OF_LIST(),
+};
+
+static void mips_dspram_class_init(ObjectClass *klass, void *data)
+{
+    DeviceClass *dc = DEVICE_CLASS(klass);
+
+    dc->props = mips_dspram_properties;
+    dc->realize = mips_dspram_realize;
+    dc->reset = mips_dspram_reset;
+}
+
+static const TypeInfo mips_dspram_info = {
+    .name          = TYPE_MIPS_DSPRAM,
+    .parent        = TYPE_SYS_BUS_DEVICE,
+    .instance_size = sizeof(MIPSDSPRAMState),
+    .instance_init = mips_dspram_init,
+    .class_init    = mips_dspram_class_init,
+};
+
+static void mips_dspram_register_types(void)
+{
+    type_register_static(&mips_dspram_info);
+}
+
+type_init(mips_dspram_register_types);
diff --git a/include/hw/mips/cps.h b/include/hw/mips/cps.h
index aab1af9..a637036 100644
--- a/include/hw/mips/cps.h
+++ b/include/hw/mips/cps.h
@@ -25,6 +25,7 @@ 
 #include "hw/intc/mips_gic.h"
 #include "hw/misc/mips_cpc.h"
 #include "hw/misc/mips_itu.h"
+#include "hw/misc/mips_dspram.h"
 
 #define TYPE_MIPS_CPS "mips-cps"
 #define MIPS_CPS(obj) OBJECT_CHECK(MIPSCPSState, (obj), TYPE_MIPS_CPS)
@@ -41,6 +42,7 @@  typedef struct MIPSCPSState {
     MIPSGICState gic;
     MIPSCPCState cpc;
     MIPSITUState itu;
+    MIPSDSPRAMState dspram;
 } MIPSCPSState;
 
 qemu_irq get_cps_irq(MIPSCPSState *cps, int pin_number);
diff --git a/include/hw/misc/mips_dspram.h b/include/hw/misc/mips_dspram.h
new file mode 100644
index 0000000..ee99e17
--- /dev/null
+++ b/include/hw/misc/mips_dspram.h
@@ -0,0 +1,46 @@ 
+/*
+ * Data Scratch Pad RAM
+ *
+ * Copyright (c) 2017 Imagination Technologies
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef MIPS_DSPRAM_H
+#define MIPS_DSPRAM_H
+
+#include "hw/sysbus.h"
+
+#define TYPE_MIPS_DSPRAM "mips-dspram"
+#define MIPS_DSPRAM(obj) OBJECT_CHECK(MIPSDSPRAMState, (obj), TYPE_MIPS_DSPRAM)
+
+typedef struct MIPSDSPRAMState {
+    /*< private >*/
+    SysBusDevice parent_obj;
+    /*< public >*/
+
+    /* 2 ^ SIZE */
+    uint64_t size;
+
+    MemoryRegion mr;
+
+    /* SAAR */
+    bool saar_present;
+    void *saar;
+
+    /* ramblock */
+    uint8_t *ramblock;
+} MIPSDSPRAMState;
+
+#endif /* MIPS_DSPRAM_H */
diff --git a/target/mips/cpu.h b/target/mips/cpu.h
index a10eeb0..8b15e6c 100644
--- a/target/mips/cpu.h
+++ b/target/mips/cpu.h
@@ -445,6 +445,7 @@  struct TCState {
 
 };
 
+struct MIPSDSPRAMState;
 struct MIPSITUState;
 typedef struct CPUMIPSState CPUMIPSState;
 struct CPUMIPSState {
@@ -1021,8 +1022,8 @@  struct CPUMIPSState {
     uint32_t CP0_Status_rw_bitmask; /* Read/write bits in CP0_Status */
     uint32_t CP0_TCStatus_rw_bitmask; /* Read/write bits in CP0_TCStatus */
     uint64_t insn_flags; /* Supported instruction set */
-    int saarp;
-
+    bool saarp;
+    bool dspramp;
     /* Fields up to this point are cleared by a CPU reset */
     struct {} end_reset_fields;
 
@@ -1039,6 +1040,7 @@  struct CPUMIPSState {
     QEMUTimer *timer; /* Internal timer */
     struct MIPSITUState *itu;
     MemoryRegion *itc_tag; /* ITC Configuration Tags */
+    struct MIPSDSPRAMState *dspram;
     target_ulong exception_base; /* ExceptionBase input to the core */
 };
 
@@ -1181,6 +1183,9 @@  void cpu_mips_soft_irq(CPUMIPSState *env, int irq, int level);
 /* mips_itu.c */
 void itc_reconfigure(struct MIPSITUState *tag);
 
+/* mips_dspram.c */
+void dspram_reconfigure(struct MIPSDSPRAMState *dspram);
+
 /* helper.c */
 target_ulong exception_resume_pc (CPUMIPSState *env);
 
diff --git a/target/mips/internal.h b/target/mips/internal.h
index 8f6fc91..650bddd 100644
--- a/target/mips/internal.h
+++ b/target/mips/internal.h
@@ -61,7 +61,8 @@  struct mips_def_t {
     target_ulong CP0_EBaseWG_rw_bitmask;
     uint64_t insn_flags;
     enum mips_mmu_types mmu_type;
-    int32_t SAARP;
+    bool SAARP;
+    bool DSPRAMP;
 };
 
 extern const struct mips_def_t mips_defs[];
diff --git a/target/mips/op_helper.c b/target/mips/op_helper.c
index c921032..5136e33 100644
--- a/target/mips/op_helper.c
+++ b/target/mips/op_helper.c
@@ -1614,7 +1614,14 @@  void helper_mtc0_saar(CPUMIPSState *env, target_ulong arg1)
                 itc_reconfigure(env->itu);
             }
             break;
+        case 1:
+            if (env->dspram) {
+                dspram_reconfigure(env->dspram);
+            }
+            break;
         }
+    } else {
+        helper_raise_exception(env, EXCP_RI);
     }
 }
 
@@ -1631,7 +1638,14 @@  void helper_mthc0_saar(CPUMIPSState *env, target_ulong arg1)
                 itc_reconfigure(env->itu);
             }
             break;
+        case 1:
+            if (env->dspram) {
+                dspram_reconfigure(env->dspram);
+            }
+            break;
         }
+    } else {
+        helper_raise_exception(env, EXCP_RI);
     }
 }
 
diff --git a/target/mips/translate.c b/target/mips/translate.c
index c79fa1e..40584e9 100644
--- a/target/mips/translate.c
+++ b/target/mips/translate.c
@@ -31383,6 +31383,8 @@  void cpu_state_reset(CPUMIPSState *env)
     env->active_fpu.fcr31 = env->cpu_model->CP1_fcr31;
     env->msair = env->cpu_model->MSAIR;
     env->insn_flags = env->cpu_model->insn_flags;
+    env->saarp = env->cpu_model->SAARP;
+    env->dspramp = env->cpu_model->DSPRAMP;
 
 #if defined(CONFIG_USER_ONLY)
     env->CP0_Status = (MIPS_HFLAG_UM << CP0St_KSU);
@@ -31537,6 +31539,12 @@  void cpu_state_reset(CPUMIPSState *env)
         msa_reset(env);
     }
 
+    /* DSPRAM */
+    if (env->dspramp) {
+        /* Fixed DSPRAM size with Default Value */
+        env->CP0_SAAR[1] = 0x10 << 1;
+    }
+
     compute_hflags(env);
     restore_fp_status(env);
     restore_pamask(env);
diff --git a/target/mips/translate_init.inc.c b/target/mips/translate_init.inc.c
index bf559af..4c49a0e 100644
--- a/target/mips/translate_init.inc.c
+++ b/target/mips/translate_init.inc.c
@@ -760,6 +760,8 @@  const mips_def_t mips_defs[] =
         .PABITS = 48,
         .insn_flags = CPU_MIPS64R6 | ASE_MSA,
         .mmu_type = MMU_TYPE_R4000,
+        .SAARP = 1,
+        .DSPRAMP = 1,
     },
     {
         .name = "Loongson-2E",