diff mbox series

target/riscv: Fix wrong expanding for c.fswsp

Message ID 1553592437-109191-1-git-send-email-kito@andestech.com
State New
Headers show
Series target/riscv: Fix wrong expanding for c.fswsp | expand

Commit Message

Kito Cheng March 26, 2019, 9:27 a.m. UTC 
From: Kito Cheng <kito.cheng@gmail.com>

base register is no rs1 not rs2 for fsw.

Signed-off-by: Kito Cheng <kito.cheng@gmail.com>
---
 target/riscv/insn_trans/trans_rvc.inc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

no-reply@patchew.org March 27, 2019, 9:01 a.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/1553592437-109191-1-git-send-email-kito@andestech.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 1553592437-109191-1-git-send-email-kito@andestech.com
Subject: [Qemu-devel] [PATCH] target/riscv: Fix wrong expanding for c.fswsp
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   7e9a2137ce..49fc899f8d  master     -> master
 t [tag update]            patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com -> patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
 t [tag update]            patchew/1553193630-28611-1-git-send-email-sandra@codesourcery.com -> patchew/1553193630-28611-1-git-send-email-sandra@codesourcery.com
 t [tag update]            patchew/1553351197-14581-1-git-send-email-cafer.abdi@gmail.com -> patchew/1553351197-14581-1-git-send-email-cafer.abdi@gmail.com
 * [new tag]               patchew/1553592437-109191-1-git-send-email-kito@andestech.com -> patchew/1553592437-109191-1-git-send-email-kito@andestech.com
 t [tag update]            patchew/20190307144126.31847-1-richard.henderson@linaro.org -> patchew/20190307144126.31847-1-richard.henderson@linaro.org
 t [tag update]            patchew/20190322162333.17159-1-drjones@redhat.com -> patchew/20190322162333.17159-1-drjones@redhat.com
 t [tag update]            patchew/20190323190925.21324-1-richard.henderson@linaro.org -> patchew/20190323190925.21324-1-richard.henderson@linaro.org
 t [tag update]            patchew/20190324180523.GA23979@erokenlabserver -> patchew/20190324180523.GA23979@erokenlabserver
 t [tag update]            patchew/20190325114554.7388-1-chouteau@adacore.com -> patchew/20190325114554.7388-1-chouteau@adacore.com
 t [tag update]            patchew/20190325161338.6536-1-richard.henderson@linaro.org -> patchew/20190325161338.6536-1-richard.henderson@linaro.org
 t [tag update]            patchew/20190326071233.1947-1-armbru@redhat.com -> patchew/20190326071233.1947-1-armbru@redhat.com
 t [tag update]            patchew/20190326090501.15253-1-armbru@redhat.com -> patchew/20190326090501.15253-1-armbru@redhat.com
Switched to a new branch 'test'

=== OUTPUT BEGIN ===
checkpatch.pl: no revisions returned for revlist '1'
=== OUTPUT END ===

Test command exited with code: 255


The full log is available at
http://patchew.org/logs/1553592437-109191-1-git-send-email-kito@andestech.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
diff mbox series

Patch

diff --git a/target/riscv/insn_trans/trans_rvc.inc.c b/target/riscv/insn_trans/trans_rvc.inc.c
index 5819f53..ebcd977 100644
--- a/target/riscv/insn_trans/trans_rvc.inc.c
+++ b/target/riscv/insn_trans/trans_rvc.inc.c
@@ -337,7 +337,7 @@  static bool trans_c_fswsp_sdsp(DisasContext *ctx, arg_c_fswsp_sdsp *a)
 {
 #ifdef TARGET_RISCV32
     /* C.FSWSP */
-    arg_fsw a_fsw = { .rs1 = a->rs2, .rs2 = 2, .imm = a->uimm_fswsp };
+    arg_fsw a_fsw = { .rs1 = 2, .rs2 = a->rs2, .imm = a->uimm_fswsp };
     return trans_fsw(ctx, &a_fsw);
 #else
     /* C.SDSP */